From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by sourceware.org (Postfix) with ESMTPS id 8C4673858D1E for ; Thu, 3 Aug 2023 13:21:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8C4673858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-wr1-x433.google.com with SMTP id ffacd0b85a97d-316feb137a7so858097f8f.1 for ; Thu, 03 Aug 2023 06:21:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1691068891; x=1691673691; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=VJwKH02ejSHvELgUHHytEoxKbvFhAQyw8lRXU4Pz6mU=; b=AfrSynReJQypq9jmEAAOmPi8DPm+qg8S93VEZ6D5HRumAyOof672WmpjTlGmv+/D5a /WE4wdBUbQWw0q1EsMHefKhp8cPBqL4cAsDZRLwgOmY9m6bquMmfukWPmVMeDhuVvdCY 8/3lm59XQ2Lk44SY5+9jSliC6ZGR943HfT6RGMqtaAvtAeA0spJP4/bVqPONgh7dqGqe kexPGekjBi4FpzbWO2siz0WbuCQs32aShYI9O0DyK/sJhaLTP8yc3y3YiShNqKVBmg6s Mj/Rk4mp8/oTWyvfUulGz/N0sOsxMPZB0O+qDf12N9PBOi4SpOfGGlLsb/17CUM8KEmB SxPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691068891; x=1691673691; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VJwKH02ejSHvELgUHHytEoxKbvFhAQyw8lRXU4Pz6mU=; b=KRIprbYZwlI7Kt9Hv6znY5soTVfvunIzw3OjOmrYNduW4ajswytG4INvUAyLCMRgC3 RS+NbnUydDhGT5k2dC7UsxAph05xpvae9GXcgWffNs3k1xtfIRctgmI0lNC9l8XIK09g bFTEjBi29eryQ2lnWNyMsAatkV5AamR/IPWY+eni20murkI1Ft+aeOD2fIFOb9ueaNpa NW4vW5xI02qbdjMnOKf47G7FnQh8PP5vOfcf8baevsWaloSM1hSaOokYS/lD1ND3Isu1 8eCGzyzZYU93AWeP3hai4NDElBiuvj6ib89/YAsYbXzVleenEXQHQTHRxOvyxGtoP+q3 bNUA== X-Gm-Message-State: ABy/qLYKIXgXb3ilUUx2iJM5I3QjyTuawdDonud/RjkSHncXnnM09bfs egYpHulugq3FaNdzsofrl/zNG3/eR+uLLwb0nJ6Uuw== X-Google-Smtp-Source: APBJJlFN7XtXj+KV2aRMQjNMAzq+6nM7DPR6e4LAhMDp3LJZzl2RoUK7718J0UWKz04j6Cvbz7GERA== X-Received: by 2002:adf:dd85:0:b0:313:e741:1caa with SMTP id x5-20020adfdd85000000b00313e7411caamr7153941wrl.25.1691068891267; Thu, 03 Aug 2023 06:21:31 -0700 (PDT) Received: from [10.32.33.60] ([130.43.161.185]) by smtp.gmail.com with ESMTPSA id z13-20020a5d654d000000b00314398e4dd4sm21792774wrv.54.2023.08.03.06.21.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Aug 2023 06:21:30 -0700 (PDT) Message-ID: <6c6e719e-ffe0-2fed-f0ef-35f61d8679af@linaro.org> Date: Thu, 3 Aug 2023 14:21:30 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v2] gdb/fortran: Align intrinsic/variable precedence To: Tom Tromey , Richard Bunt via Gdb-patches References: <20230802133613.941743-1-richard.bunt@linaro.org> <87zg39e540.fsf@tromey.com> Content-Language: en-US From: Richard Bunt In-Reply-To: <87zg39e540.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 02/08/2023 18:17, Tom Tromey wrote: >>>>>> "Richard" == Richard Bunt via Gdb-patches writes: > > Richard> Fortran allows variables and function to be named after language defined > Richard> intrinsics as they are not reserved keywords. For example, the abs maths > Richard> intrinsic can be hidden by a user declaring a variable called abs. > > Thank you for the patch. > > Richard> +static const struct token f_intrinsics[] = > Richard> +{ > Richard> + /* This is post the symbol search as symbols can hide intrinsics. Also, > Richard> + give Fortran intrinsics priority over C symbols. This prevents > Richard> + non-Fortran symbols from hiding intrinsics, for example abs. */ > Richard> + if (!result.symbol || result.symbol->language () != language_fortran) > Richard> + for (int i = 0; i < ARRAY_SIZE (f_intrinsics); i++) > Richard> + { > > I think it's better to use foreach here, as is done for f_keywords: > > for (const auto &keyword : f_keywords) > ... > Thank you for the review. Posted a v3 with this modification. > Otherwise this looks good, thank you. > > Tom Rich.