From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from YT3PR01CU008.outbound.protection.outlook.com (mail-canadacentralazon11020002.outbound.protection.outlook.com [52.101.189.2]) by sourceware.org (Postfix) with ESMTPS id 7C234384AB5A for ; Thu, 16 May 2024 15:33:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7C234384AB5A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7C234384AB5A Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=52.101.189.2 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1715873612; cv=pass; b=eP4T+1vJMJc9WF5VK+1k1PHaeoKB2bW98EGxRBkVlWQzqGpcCG6mOkHD+dzz1pzB2qBLhKMnqWAovuKZqC8wt8kp/snD73P8NV/OU0MvCtVsQE+p3MnWEakgNvT1wUj0dQsqY+noRexGGNlSAGOhxYSNLiR6obfGovu492EuaDg= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1715873612; c=relaxed/simple; bh=6Db68/1YRcAbNmSLnxIcSRBOzU9w2jOXuE0WwmoAMbM=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=SbJ3OIdrnWmFw09gSkkeO/aBiCkpt2ydAamlA5HAl1Jm8GRqhHrwKiyFx2lPVyPJUJqjhVl/M3cpFxMDvNaWAA+gGQa+zLoelcSNSWigfpFKxomLBGsjToF0UsgIr8RZxh8A8ujwr1he1iGwkApUVysjBWEb6DkHov9g5vbbqc0= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AlPyRsg0wBcrQqK+O20EEmu7GYHwEWbgQl3JPQoqUDdCwBroDzCGeHSN0zKPXtvieAxPOEorGj0qG0jp1Q/3la7i44B2NldUDLsDG9AlYmpzYXnPW2BjRPBU51/imaO2/d8mKqLVBzvL6jHghtjhl5ArGIxZRi8jmRm/FlV8M2J2uHRGhnyq/sXv1NZxjIRI+iBPVcR+nfyshzDDWgobdpZeb1zOmtIIZNY9eNEEgptyP/aDQ1FmqiQKax82AsKqlyK2xN9LKZc/qMD4ON6aorp9qEjvpbx5lxy2Seg1DfK6pDj1qpEs+uJM3nDCp8kOl61b8dtDOCs1/Ej4vPAarA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nhHsw3UAL/xgzDZPdDszWkD4hqcQLS4ezFAyv7q662M=; b=QLRdv8lHod8KT8jM0Rnzapdjx3krIAFy6qt0PFg/hbMdDq/9+oYJJINWwsNajZUHLanRraJxTscO4YeGInl+Pm12pmY5fmgmySUqJTpTMLgVerqufwDjDRYBhyovqyRbbqIyrFdldadN70xbnC4Q6K1Q01wAMNsN3HpS3DT2Tk5wdmIQUk+spwOdo6jJySDPgMSJ4X/EOFZTQHxPPCsFtj3Iz/mHZSbbOPDOrTp0ilnbG6LBB0VnV8Wih4ruyyt/HSTqXdsnRnVpK2KjB/yaIz5pSEcgiVQ+N/SBs3rmgEbNc5+Cr+S5Pkie/mOiFqR4UFFJqMoxSiiUIdf0L99yuQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nhHsw3UAL/xgzDZPdDszWkD4hqcQLS4ezFAyv7q662M=; b=Yh0mgzOCA7HhYimNG+kyYqqs0E85PDbBFZSTpKZh3zWfAjqonW6N2rY+FBP1WUbGD1blEODU1OC1+2j6lszYGiias3xfwKOGvZBUnFI7TS4KEtH7N/nqsTe7IdxxsdIrrCu/GXX8vCz7Z9Lejk2z02xYUqK7koxh417QJ2X/YB+hFWuM+hu56QwE2lVc7MubMJC8hvJsIAN1v5RraQOu/PmWf9YddpTS3IJJYImFm8Lx8FlUXB1vUtXDmUqE+Fwdb0FoO4aJRWt9OyggW9ZDFaKGOU1Y1TWVO7jvdKU9g/XoyLMh/XsHGjEr7G+2GfCQ8NDw6xsW4LCNN+Zy9Awlzw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=efficios.com; Received: from YQXPR01MB5520.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:2e::17) by YQBPR0101MB6363.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:4a::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7587.28; Thu, 16 May 2024 15:33:25 +0000 Received: from YQXPR01MB5520.CANPRD01.PROD.OUTLOOK.COM ([fe80::d278:be5:4197:6627]) by YQXPR01MB5520.CANPRD01.PROD.OUTLOOK.COM ([fe80::d278:be5:4197:6627%4]) with mapi id 15.20.7587.028; Thu, 16 May 2024 15:33:25 +0000 Message-ID: <6ccba0f5-0a3a-4946-9057-e8825b097de8@efficios.com> Date: Thu, 16 May 2024 11:33:24 -0400 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb: move lm_info to solib in dsbt_current_sos To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20240515171332.45675-1-simon.marchi@efficios.com> <87o796x4bi.fsf@tromey.com> Content-Language: en-US From: Simon Marchi In-Reply-To: <87o796x4bi.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YQ1P288CA0014.CANP288.PROD.OUTLOOK.COM (2603:10b6:c01:9e::15) To YQXPR01MB5520.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:2e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YQXPR01MB5520:EE_|YQBPR0101MB6363:EE_ X-MS-Office365-Filtering-Correlation-Id: 24b9fe0f-28e3-47b2-6110-08dc75bd86f4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|376005|1800799015|366007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?MGdXZ0JrVDMwUlpNWEg2czJVQzlrSGJCdlNoWnNlcDNSS0R5T21WU1V6YytY?= =?utf-8?B?MGxzVDgzZitIMCtlbFpUY3NhZVkrV2kxQlpYeHdzcXhaUlV2SmRhd1k3TzhT?= =?utf-8?B?MkpBcDJYWTI3VmFuWm1HWUhUam0rc3ZJOU5LanBXMkN6dzBuVnJZYkxwYTdJ?= =?utf-8?B?QmNZaEF5aXRraFZPcHl4Vkt2eUZwL1RNNFZ1b2JUeHE0aW8wMnZ4Y1ViT2Rq?= =?utf-8?B?Y3lWZnIybWtQWTBvNFpzenMvRFJJRlFDT3Nqbm1lSUFBQ3lQQTVJMnBxbzFO?= =?utf-8?B?cjd5RVlodEg2MEZuTk5uZHB0blZpTC9QcElxRUJBcHppNUwyMGxmNHN4d3Iy?= =?utf-8?B?SjBzRTNCemJ1U2M0amV1cVE5cjNHcHB2V0tvM1IrWklVb3o3OVdTUDlGMGYz?= =?utf-8?B?TE9Td1gzd1ZVRk13NDlhL3lDaTdwTnoySnZxOTBuMkhjM2UxS3J4eGI2SlFL?= =?utf-8?B?bnZkR1ZCd1JldlJUMFduZHVmU0JoZ1g1UUtFVHZ5cEFod3FPakRKMjNwQzN5?= =?utf-8?B?QW95ajRpT2E3NVcxUUpKeEFueTBJbjhhbG9LZmFDTjA3RkNmem5HQmxxTjAx?= =?utf-8?B?Q2VHZU1UaVRXZ1FzUFJjbzNteC9uUTE4VXpqcTRtTTQ3MGlzeDFvT3Q2eUJs?= =?utf-8?B?dDdkRm9xdXEyK0s3TmpuQTRKbWlSMkhhNjY5cmxkODF0MndBRmoweHcxNEtz?= =?utf-8?B?cDB4dkpGemlsSlphMEpsVisxbm1CVzkwMzJDQituWDFhUWJsZHdFWnRtbEU5?= =?utf-8?B?NXBJTXJtNzRDTzZDSmlxSHYrTWkwZEVaQTFTWmNOVjBRc1dhZTh6YVJBNEtM?= =?utf-8?B?MDRvc3BtQ2FQOG9LMnhRVVJVMEZoRGpabjYxQnd1bjhxejZNZWg3TXFOQ1Fr?= =?utf-8?B?UmNuMjV1b3pKaHhyb0FiZzA1YkMwNkJnR1d0VG5DQ2Q1bVJQOFdRb3pERjZp?= =?utf-8?B?WDFLNnhkOG1kazBvNFFwNEVIY0tvRXk5U21vaERoWDFiTnVCMzJiS1dFWS8x?= =?utf-8?B?MTFpSTkvT2RYOTZqWDBnRDhTQXR0ek9wbHVkU3o3MHlCSmFBd2NSVzlxSGtD?= =?utf-8?B?dW9ydFNSaUNZNmcrWWRtaEJsWHhlOVhHcXZpYVhhMEx6bFRCVWl3YWZzR1FK?= =?utf-8?B?ajczbXA3YVVrdXkrazdsL2ZGbWRqZzhpdlJlbEYwUERrL1V1SUwzdlNZaHIz?= =?utf-8?B?Z28xcFpSdWJ4a2F2MGFiK1ROcUxycitTK2pMWk5xOS91RjZoSHZHek9FRUk3?= =?utf-8?B?SUNUK1FmTUF4K1cyVWRubjZGYVhvUTQycURFOUExNnlmOHlITURKWjArNWdu?= =?utf-8?B?ZVZMa0VGbFRvUEJTUFBtSU85UHlPWmVxTSs0SCtHa24za1U1Ti9sbHZCcUw5?= =?utf-8?B?Um52eXBtMDk1OXd2SGYwRTUxR0VIbzJqaTVTeHJtRWFvSGlXV1E5YUVqQTBM?= =?utf-8?B?RW90cWJRZG9tTlA3TjhpMkY4a0ozSjdYN2Rnb2NIZ0wxdmFvQmFuYkpiK1cx?= =?utf-8?B?OU1yZktDTThCakIvRWQ2eUNhR204cG5mRjhEeGtCNjFtYWhjSzJQY1UvcVdM?= =?utf-8?B?a0p6Q2ZybSswTWNwbmtjTVdhZUo3ay9tWG83NGlNMHpwVlFkYXJlbXlZSVRz?= =?utf-8?B?VG94L2hyMnNXWjdxaXNhU1ZFZUZINFE9PQ==?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:YQXPR01MB5520.CANPRD01.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230031)(376005)(1800799015)(366007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U0NKRnlldGZrNy8zVGZOZUZUcEFRaW9LZitoZjY4QWphK1BGRkVqalhYRWFR?= =?utf-8?B?ZjJjWVhOTTBhaU1mMm5acXpkMjkzc2xtQnkvTkxzazBxZ1BBRnFIeno4emhq?= =?utf-8?B?YTRTVTZGS1dkNG8rQUhsTCtackZyVDRUYzZNbWsxWDNMT1JHQVJBY2FXcThF?= =?utf-8?B?Z1Vkb1BQYjhxUmYrV0NPRVhraFMyWUEzdkpVajJaOWZZME1iSWRibnBybXVG?= =?utf-8?B?Z0Q0QzVNYm11eXRjSFJZQ0hhVUdTU21JbmxQT25JcjdzWE5KeFQ4UElPN1Nv?= =?utf-8?B?NXRkMGRhTGUvVjlFb1lqdFNBVnhCbzdWMXI4aForUEhDYzVoc1VzeXF6Y3c4?= =?utf-8?B?d29NYkJuVTBPT285MEJ5eWk1UCsxVVR6cnhsWjNyMHQ5SVFNUEoybFZqUWI5?= =?utf-8?B?NCtYTUxIVjhKUEdtN0Z1Q2tFTjI3bzhneUhjMk0zeHlPWXJIaEl5dklBZGRK?= =?utf-8?B?OFE1VUdFUTJ5NjNXSHBXcDB2OFloL2Z1bEZoZ0lSVUM4UnkzZXQvWVg3ZlhW?= =?utf-8?B?c1YwOHBCNVJMWUsxRUs0OUVYd2VwWWRJalN3RXZ0RVVpWnlWb29RS3ZLVER3?= =?utf-8?B?M3lOM2wxWGtvZHRWYk1iL3ozaTJGcEdmTUVmV0JjeVJNcFlKbmpKUTYvSnpq?= =?utf-8?B?REFvMmQ4L1VmZHdhaHdyQUNKQ1pGSC84K2piS2RCbjdzMTlrZzB0NlkyZEpa?= =?utf-8?B?Wkt1SHNuUG1iMEZkSXZCSmNXRVhINkF6NHpCbXVrWWVzM2RkSmxzRkNwazhu?= =?utf-8?B?cnlLNEUybzBSbDFFMWVqdDkzK0cvRU9PT2tVUmRJT1l3akVqQW9yUGpkblRP?= =?utf-8?B?R1pMRC8way94WjNyTzhsNzhNYnlzQm9hUm5DdHNjaUhWQWQydVBCNmRSS0Ns?= =?utf-8?B?dmRKSlZiRWZ0TEVaVkZWakV5VVhmM3RrRklHcFlxc1FacEhERU9DeWNlNzBq?= =?utf-8?B?NGM3R2hnY2gzSWRVMkV6UFlxVnhCYnM0UC9MZDZxQUdGN1k0M09BT1hJL1ZO?= =?utf-8?B?RGRjUmppUmg4am5HbCt4Q05Ic0hENW9sc004VUo2aUs3ZzJMKzdncGJTY2wx?= =?utf-8?B?clhoV1Fyei9BSnNiZmNIUkdFY241b2Qxam9yZGErSW5wNkJYNlY1OU1tTytM?= =?utf-8?B?eUMxMFRLUGJPL1FHb0FnQlRzSmhMSEVNZmtxdEdhRGlVLzVXd3hJZ0ZkTzhQ?= =?utf-8?B?Q2x3RTBDSXNpaVAxTHRLUVNZdFZaZWo3NU1NWG5JbTEwYlRscXpURkF0VWF4?= =?utf-8?B?cTZsQ0FmRTZob2RYM3JVR0VNR1VpSEsyMkRGdGM1Rm1DVXBCeWhVVmY4Ym5q?= =?utf-8?B?bERBeUIvQThLalR3aXFLVkZmZUZUWXdkM1kvcVZVV0Njd0d2SndVRHZhcm5I?= =?utf-8?B?bU9SQlFYMlo1QTI5SDBVa0NoTEZ2cGVyMDFvRUJyYTJWOVE1Z08ySDFnWHZ4?= =?utf-8?B?MW9YdTdwejhob1kydWNjM082YlZhWjFNbThxTFBwR3M2ZGJCZDlnU2lKaU5x?= =?utf-8?B?eS9sOXg1cUdhTEIwZGs5SWQzVkFWK1RIVnRIclp4eTZqZ29pNlFoL0Z0M3VU?= =?utf-8?B?Z3FVMzZhMHJlYzFjRGNDa0d4R3NGVGduR1R0OThJSzQ2NU1aMnRnZk16SU14?= =?utf-8?B?TDROczRMTER1cjNORjhMTERudy93RDJSeGhmNlFkZG1rZ0piMEs1eXB4djU1?= =?utf-8?B?YkRVQ093WnNDTStJZU54cGNyalNvbHlaTVBOdVVUOFpZRGpVdjRRVUZ1UE9q?= =?utf-8?B?NUFObzhpS3h1QVkwemVwUXdKZkUxdlFIdmgvcGRuVkd0bkgrcTU1aTRvejhI?= =?utf-8?B?cy9XcWdmMTBiMzJ0eElvR2lJNEs3L2FjVkNSVFJMZE9ONWQvN2hBT1Y2RHhY?= =?utf-8?B?UE9oTWpVbEo0ckV6YU5ZdW5STUJjUjFIV1B6MUxpNWxNTml0NWp6UG5qc3kv?= =?utf-8?B?RVh6RzFsMEtkUzYwZ3NIY0lTNHFGdU1xUkZwcVBMbHRHOVdpNTYyNFJJdVdq?= =?utf-8?B?YUJvSS9teEVSSStNWXc4a3dkVklaMmhVOFo2WUN0cVUxRkVGdnhRN3NaenR4?= =?utf-8?B?V2dDd1gwNmlIWnNvb1hBcGhaK3RTMCtjMU5FekNXbHF2Y2E0bUJSVVVLWGZz?= =?utf-8?Q?NMBwuug15xu4I46MCiFjeiVsZ?= X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: 24b9fe0f-28e3-47b2-6110-08dc75bd86f4 X-MS-Exchange-CrossTenant-AuthSource: YQXPR01MB5520.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 May 2024 15:33:25.4607 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LIZ6tMreSkBNTjDHU1myK/r23FUs19irmV1GWMa34Q+6D+4H8q9jnuBUMmZVbD0eMqrgDBF/h9revNmOXRWoLg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YQBPR0101MB6363 X-Spam-Status: No, score=-3032.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2024-05-15 15:28, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > > Simon> Commit 8971d2788e79 ("gdb: link so_list using intrusive_list") > Simon> mistakenly removed the line that moves the lm_info unique pointer to > Simon> sop-> lm_info, probably due to a bad conflict resolution. Restore that > Simon> line. > > Seems reasonable to me. > > Approved-By: Tom Tromey Thanks, will push. > Simon> Unfortunately, this code is only used for TI C66, which is not widely > Simon> tested (if used at all). > > I do wonder how much dead-in-practice code we're carting around. Yeah it's always the same question. Support for c6x has been removed from Linux in 2021: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=a579fcfa8e49cc77ad59211bb18bc5004133e6a0 This means that after some time, tic6x-linux-tdep.c would become obsolete, and solib-dsbt.c too. As for the c6x architecture itself, I find some threads that are not too old of people trying to debug their bare metal program with GDB (through JTAG or emulation or otherwise), for instance: https://e2e.ti.com/support/tools/code-composer-studio-group/ccs/f/code-composer-studio-forum/665959/ccs-debugging-c66-with-host-gdb Simon