From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 726683858C50 for ; Tue, 29 Mar 2022 12:23:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 726683858C50 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 22TCNlKg002379 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 29 Mar 2022 08:23:52 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 22TCNlKg002379 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 3162F1ED17; Tue, 29 Mar 2022 08:23:47 -0400 (EDT) Message-ID: <6cd77dc1-27fc-deef-0d2c-3a8fc1df9ca5@polymtl.ca> Date: Tue, 29 Mar 2022 08:23:46 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH 1/2] Add lld(linker) specific option. Content-Language: en-US To: "Balasubrmanian, Vignesh" , Simon Marchi , "gdb-patches@sourceware.org" Cc: "George, Jini Susan" , "Kumar N, Bhuvanendra" References: <83fea526-a710-4eca-9c62-2bd1b0dc6f13@polymtl.ca> From: Simon Marchi In-Reply-To: <83fea526-a710-4eca-9c62-2bd1b0dc6f13@polymtl.ca> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Tue, 29 Mar 2022 12:23:47 +0000 X-Spam-Status: No, score=-3032.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Mar 2022 12:23:55 -0000 > Like Luis said, I see some failures when running the test with the lld > linker, do you see those too? If so, it would be good to mention it in > the commit message, so that others aren't surprised to see the test case > fail. Getting the test case to compile is already an improvement. Oh, fixing the test is done in patch #2, right? If so, you can mention in the commit message that after this patch (patch #1), the test fails, but it is fixed by the subsequent patch. Simon