From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 1430D398E464 for ; Fri, 2 Oct 2020 18:49:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 1430D398E464 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 092In1Qu000397 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 2 Oct 2020 14:49:06 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 092In1Qu000397 Received: from [172.16.0.95] (192-222-181-218.qc.cable.ebox.net [192.222.181.218]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 67F421E4B5 for ; Fri, 2 Oct 2020 14:49:01 -0400 (EDT) Subject: Re: [PATCH 0/4] Add logging for event loop events To: gdb-patches@sourceware.org References: <20200925154831.2759299-1-simon.marchi@polymtl.ca> From: Simon Marchi Message-ID: <6cde0401-2461-0619-023f-1ce80a8b708f@polymtl.ca> Date: Fri, 2 Oct 2020 14:49:00 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200925154831.2759299-1-simon.marchi@polymtl.ca> Content-Type: text/plain; charset=utf-8 Content-Language: tl Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Fri, 2 Oct 2020 18:49:01 +0000 X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-DCC: sonic: antispam2020.polymtl.ca 1255; Body=1 Fuz1=1 Fuz2=1 X-Spam-Languages: en X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Oct 2020 18:49:12 -0000 On 2020-09-25 11:48 a.m., Simon Marchi wrote: > I currently have both hands in event loop / infrun stuff, and I found > it useful to add debug prints to know when the event loop invoked an > event handler. I would like to propose this for upstream, so that I > don't need to maintain my own patch on the side :). > > Simon Marchi (4): > gdb: give names to event loop file handlers > gdb: give names to async event/signal handlers > gdb: move debug_prefixed_vprintf to gdbsupport > gdb: add debug prints in event loop > > gdb/async-event.c | 49 +++++++++++++++++++++++----- > gdb/async-event.h | 15 ++++++--- > gdb/debug.c | 13 +------- > gdb/debug.h | 32 ------------------ > gdb/event-top.c | 67 +++++++++++++++++++++++++++++++++----- > gdb/infrun.c | 5 +-- > gdb/linux-nat.c | 5 +-- > gdb/record-btrace.c | 2 +- > gdb/record-full.c | 2 +- > gdb/remote-notif.c | 2 +- > gdb/remote.c | 3 +- > gdb/run-on-main-thread.c | 3 +- > gdb/ser-base.c | 6 ++-- > gdb/top.c | 4 +++ > gdb/top.h | 3 ++ > gdb/tui/tui-io.c | 2 +- > gdb/tui/tui-win.c | 3 +- > gdbserver/linux-low.cc | 3 +- > gdbserver/remote-utils.cc | 10 +++--- > gdbserver/server.cc | 15 +++++++++ > gdbsupport/common-debug.cc | 11 +++++++ > gdbsupport/common-debug.h | 6 ++++ > gdbsupport/event-loop.cc | 60 +++++++++++++++++++++++++--------- > gdbsupport/event-loop.h | 54 ++++++++++++++++++++++++++++-- > 24 files changed, 274 insertions(+), 101 deletions(-) > delete mode 100644 gdb/debug.h > > -- > 2.28.0 > I pushed this. Note that I received an informal +1 from Luis on IRC :). Simon