From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 17FAA3858D38 for ; Wed, 10 Jan 2024 17:01:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 17FAA3858D38 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 17FAA3858D38 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704906120; cv=none; b=jJ87Cj2XdKW0SkD1fjWtrKhb6LpghqDIunCWdATwKA3Sgm+iCVQvNJE8UkwkqJbx6TC771oMeZTxgqi1vQNjdkw3WKTmtgV1v/Civ77waRCrU3Ia/rI49TwFn7FYj4vXc9eQ5OYIxJ/Xr/GhWsLze9BWq7ST/McoKb+Hlp6xMYw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704906120; c=relaxed/simple; bh=SlZS4c7CCeTzLS25P0DyeWHwsy/eCbxgPUpj9J2VjVw=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=YSIZW7zCoP47vqGQDykqH759ZJjhnEOEHYovlOJmaqcOKdVNwCjoxbcaJx4Arhu3jCFrY9pK9tCXIf0O+EXBCQEvpVYK5wka+YnivomLLRaFj5HuKx2D+77Kjh9jD7S+ldV1m4K9O5yqiME+LWwCz6eoSdIch821m5hZ5OAg804= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1704906117; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5HeAyTXMrUbWPx37gQ9V/1gblK99uip2QBeenb96iIU=; b=I1CbIVWzSZan1hCW2oWwKDn+ktloFvTfUmN4QLlfN49QlDa7dmOcI5V9EJzzxvPenBCaRX e4zbnxQRXMEXoYEFBmciWp/E5bscySyXz96laSsbkExWWxOq8w8YjLV0H9BA2sGWvgsgrF w2eHCjaEsO2ZWPmeXlGRFGrSbCp8/5A= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-613-ARQTfJYYO2O-XI4yRKPM_Q-1; Wed, 10 Jan 2024 12:01:50 -0500 X-MC-Unique: ARQTfJYYO2O-XI4yRKPM_Q-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-40e53200380so10015245e9.3 for ; Wed, 10 Jan 2024 09:01:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704906109; x=1705510909; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5HeAyTXMrUbWPx37gQ9V/1gblK99uip2QBeenb96iIU=; b=uQ9nEGykNY9NT2eay8iPOhfueCXzfH7fmpApXG2/7pVqCwzfRFiEfWlnFWYFImjeBw f8h3cuBzM04vT8FgHDlvGc0Hfv68mveEBGxm35c8Rwx+lO7ar1HUHGaLCVGwHwFA9PFp 2469k+s5DXMe7OvAJPq3qIk14/8qUU5/r4U6lmauWKfmBJvkQ3y537W014tdViwW5739 VhqpZJhBAaNZd6emr5id+jDpr1sGeE1MMAiIwUz7mqNRR7jZ6o8xlXSkxl+RvZqySXnG jwwkzzkiyrBt10iPN/PFmUrN9O1U8w8VMAqhCZb7WyGO1BDankeQU97XTURYevUc0mk+ T6PA== X-Gm-Message-State: AOJu0Yy1I6y8tFutdq72J5mwdB2VJC/EXNOO9NeCngTc4VXv/Nln3hYl /vviLMWM1UVqg/d9Ju2A5aK0j/lU9rsJwEfA4vh3ETm9rxa8SgZ1+4CmzRvO1ZlzqtjIt4qgB3v en78B0MCe429HX2wr6RC9GAs0KkilHnflTpJqag== X-Received: by 2002:a05:600c:458b:b0:40e:47d6:2012 with SMTP id r11-20020a05600c458b00b0040e47d62012mr753768wmo.20.1704906109321; Wed, 10 Jan 2024 09:01:49 -0800 (PST) X-Google-Smtp-Source: AGHT+IFq71Ehda2u2Hp/nGxveTeMO50v3MmZpr9koOS16npdVYkHBdIW6weO1eWYmgriAIrDzSdqKA== X-Received: by 2002:a05:600c:458b:b0:40e:47d6:2012 with SMTP id r11-20020a05600c458b00b0040e47d62012mr753758wmo.20.1704906108880; Wed, 10 Jan 2024 09:01:48 -0800 (PST) Received: from [192.168.0.129] (ip-94-112-227-180.bb.vodafone.cz. [94.112.227.180]) by smtp.gmail.com with ESMTPSA id v3-20020a05600c470300b0040d8d11bf63sm2789381wmo.41.2024.01.10.09.01.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Jan 2024 09:01:48 -0800 (PST) Message-ID: <6cfe89c3-cff0-4d56-bc96-7d8b358246fb@redhat.com> Date: Wed, 10 Jan 2024 18:01:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb/dwarf2: Add support for DW_LNS_set_epilogue_begin in line-table To: Simon Marchi , gdb-patches@sourceware.org References: <20231221102925.377720-1-blarsen@redhat.com> <3cf538c1-c8a9-404f-a2d2-86fd3d39fb5b@simark.ca> From: Guinevere Larsen In-Reply-To: <3cf538c1-c8a9-404f-a2d2-86fd3d39fb5b@simark.ca> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/01/2024 17:57, Simon Marchi wrote: > On 12/21/23 05:29, Guinevere Larsen wrote: >> This commit adds a mechanism for GDB to detect the linetable opcode >> DW_LNS_set_epilogue_begin. This opcode is set by compilers to indicate >> that a certain instruction marks the point where the frame is destroyed. >> >> While the standard allows for multiple points marked with epilogue_begin >> in the same function, for performance reasons, the function that >> searches for the epilogue address will only find the last address that >> sets this flag for a given block. >> >> This commit also changes amd64_stack_frame_destroyed_p_1 to attempt to >> use the epilogue begin directly, and only if an epilogue can't be found >> will it attempt heuristics based on the current instruction. >> >> Finally, this commit also changes the dwarf assembler to be able to emit >> epilogue-begin instructions, to make it easier to test this patch > Starting with this commit, I see: > > FAIL: gdb.base/unwind-on-each-insn-amd64.exp: foo: instruction 6: $fba_value == $fn_fba > FAIL: gdb.base/unwind-on-each-insn-amd64.exp: foo: instruction 6: check frame-id matches > FAIL: gdb.base/unwind-on-each-insn-amd64.exp: foo: instruction 6: bt 2 > FAIL: gdb.base/unwind-on-each-insn-amd64.exp: foo: instruction 6: up > FAIL: gdb.base/unwind-on-each-insn-amd64.exp: foo: instruction 6: $sp_value == $::main_sp > FAIL: gdb.base/unwind-on-each-insn-amd64.exp: foo: instruction 6: $fba_value == $::main_fba > FAIL: gdb.base/unwind-on-each-insn-amd64.exp: foo: instruction 6: [string equal $fid $::main_fid] > > Do you see it? > Hi Simon, I don't see anything wrong with this test locally, I get 179 expected passes. Could it be some difference in config? -- Cheers, Guinevere Larsen She/Her/Hers