public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Simon Marchi <simon.marchi@polymtl.ca>
To: Enze Li <lienze2010@hotmail.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: Fix build error on macOS
Date: Mon, 4 Oct 2021 12:14:04 -0400	[thread overview]
Message-ID: <6d03de6a-0760-2894-3845-dd9dec5c703a@polymtl.ca> (raw)
In-Reply-To: <MEAP282MB029370891A815AD567B60CBDDDAE9@MEAP282MB0293.AUSP282.PROD.OUTLOOK.COM>



On 2021-10-04 06:03, Enze Li via Gdb-patches wrote:
> PR build/28413 notes that the gdb master fails to build on macOS.
> 
> Based on De Morgan's law, the expression
> !(defined __GNUC__ && !defined __clang__ && __OPTIMIZE__)
> is equal to (!defined __GNUC__ || defined __clang__ || !__OPTIMIZE).
> The expression above looks weird, maybe there are some problems with
> this way of judging. When any one of the conditions is established, the
> subsequent judgment will be ignored.
> 
> This patch works around the issue by rewriting the expression of
> judgment after referring to the nearby notes.
> 
> Tested by building on x86_64-Linux and macOS(Mojave & Catalina).

Thanks for addressing this.  Please send the patch to upstream gnulib,
to the following mailing list:

  https://lists.gnu.org/mailman/listinfo/bug-gnulib

Then we can pull the updated feedback.

Otherwise, we can always have a local patch in
binutils-gdb/gnulib/patches, but if the change is correct, I don't see
why it wouldn't be accepted in upstream gnulib.

Thanks,

Simon

  reply	other threads:[~2021-10-04 16:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-04 10:03 Enze Li
2021-10-04 16:14 ` Simon Marchi [this message]
2021-10-05  8:23   ` Enze Li
2021-10-05  4:51 ` Enze Li
2021-10-06  0:05   ` Bruno Haible

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6d03de6a-0760-2894-3845-dd9dec5c703a@polymtl.ca \
    --to=simon.marchi@polymtl.ca \
    --cc=gdb-patches@sourceware.org \
    --cc=lienze2010@hotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).