From: Pedro Alves <palves@redhat.com>
To: Luis Machado <lgustavo@codesourcery.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH v2 7/8] Fix test names starting with uppercase using multi-line gdb_test_multiple
Date: Wed, 30 Nov 2016 20:47:00 -0000 [thread overview]
Message-ID: <6d3d9103-a7dc-e788-d7cd-596f64b29f8d@redhat.com> (raw)
In-Reply-To: <1480107244-1484-8-git-send-email-lgustavo@codesourcery.com>
On 11/25/2016 08:54 PM, Luis Machado wrote:
> This fixes offender testcases that have test names starting with uppercase
> when using gdb_test_multiple in a multi-line construct.
>
> gdb/testsuite/ChangeLog
> 2016-11-25 Luis Machado <lgustavo@codesourcery.com>
>
> Fix test names starting with uppercase throughout the files.
>
> * gdb/testsuite/gdb.cp/gdb2495.exp
Drop "gdb/testsuite/", and LGTM, but ...
> ---
> gdb/testsuite/gdb.cp/gdb2495.exp | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gdb/testsuite/gdb.cp/gdb2495.exp b/gdb/testsuite/gdb.cp/gdb2495.exp
> index dff5977..7e4dfa8 100644
> --- a/gdb/testsuite/gdb.cp/gdb2495.exp
> +++ b/gdb/testsuite/gdb.cp/gdb2495.exp
> @@ -95,7 +95,7 @@ gdb_test "info breakpoints" \
>
> # Turn off this new behaviour.
> gdb_test_multiple "set unwind-on-terminating-exception off" \
> - "Turn unwind-on-terminating-exception off" {
> + "turn unwind-on-terminating-exception off" {
> -re "$gdb_prompt $" {pass "set unwinn-on-terminating-exception off"}
> timeout {fail "(timeout) set unwind-on-terminating-exception off"}
> }
... I think this could just be:
gdb_test "set unwind-on-terminating-exception off" ""
?
I'd end up fixing two extra things:
- note the typo in the pass case: "unwiNN"
- odd "(timeout)" print position. timeout handling it not necessary
at all with gdb_test_multiple, even.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2016-11-30 20:47 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-25 20:54 [PATCH v2 0/8] Fix gdb's testsuite test names Luis Machado
2016-11-25 20:54 ` [PATCH v2 3/8] Fix test names starting with uppercase using gdb_test_no_output Luis Machado
2016-11-27 16:58 ` Yao Qi
2016-11-25 20:54 ` [PATCH v2 7/8] Fix test names starting with uppercase using multi-line gdb_test_multiple Luis Machado
2016-11-30 20:47 ` Pedro Alves [this message]
2016-11-30 21:05 ` Luis Machado
2016-11-30 22:14 ` Pedro Alves
2016-11-25 20:54 ` [PATCH v2 6/8] Fix test names starting with uppercase using multi-line gdb_test_no_output Luis Machado
2016-11-30 20:12 ` Pedro Alves
2016-11-25 20:55 ` [PATCH v2 8/8] Fixup testcases outputting own name as a test name and standardize failed compilation messages Luis Machado
2016-12-01 11:08 ` Pedro Alves
2016-12-01 13:15 ` Luis Machado
2016-12-01 17:20 ` [PATCH v3 " Luis Machado
2016-12-01 17:35 ` Pedro Alves
2016-12-01 20:52 ` Luis Machado
2016-11-25 20:55 ` [PATCH v2 5/8] Fix test names starting with uppercase using multi-line gdb_test/mi_gdb_test Luis Machado
2016-11-30 20:11 ` Pedro Alves
2016-11-30 20:25 ` Luis Machado
2016-11-25 20:55 ` [PATCH v2 2/8] Fix test names starting with uppercase using gdb_test on a single line Luis Machado
2016-11-27 16:48 ` Yao Qi
2016-11-28 18:13 ` [PATCH v3 " Luis Machado
2016-11-25 20:55 ` [PATCH v2 1/8] Fix test names starting with uppercase output by basic functions Luis Machado
2016-11-29 21:37 ` Yao Qi
2016-11-25 20:55 ` [PATCH v2 4/8] Fix test names starting with uppercase using gdb_test_multiple Luis Machado
2016-11-27 17:10 ` Yao Qi
2016-11-28 16:06 ` Luis Machado
2016-11-29 14:49 ` Yao Qi
2016-11-29 15:07 ` Luis Machado
2016-11-29 20:55 ` Yao Qi
2016-11-29 21:14 ` Luis Machado
2016-11-30 19:56 ` Pedro Alves
2016-11-28 18:57 ` [PATCH v2 0/8] Fix gdb's testsuite test names Sergio Durigan Junior
2016-11-28 19:00 ` Luis Machado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d3d9103-a7dc-e788-d7cd-596f64b29f8d@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=lgustavo@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).