From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) by sourceware.org (Postfix) with ESMTPS id E6EDA3858C56 for ; Fri, 14 Oct 2022 11:45:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E6EDA3858C56 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f46.google.com with SMTP id bv10so7155755wrb.4 for ; Fri, 14 Oct 2022 04:45:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=a6gb1nGLqJT7ue2dYVnzP11VGx8c6MFCN28G24qGZd8=; b=AU6X1k8C94b1cnuoY5LGFRoyPjBXWNCkDo3eTeyDswoZeupFGffL1RkC7kbgoIYJwd uK/+SN1KGfNnPUQXpk0KjIEV1KVPiGOoVTlLGeYyyWcvlAVva6qoHYLF8W6SrTuCUkzO hd5lKN9fZ3JtIp+iTyG5T1aPo+PwS8//o3IXVYgpMeQed1UdJY7UKoiBQ/mCA8Fv+Ct8 s65BLxfX/wVD3zvD2NnEq8GPaj2WYyGpl22/570EYd3UZ8jXuVRx0JA6FcGd8B9cqy4O JXz8Gkn2inHLUFKqQPL5j2Yk4ZdZ89Ks6veZVInjl+t6mkIT3V1D40YWYyWItgLId1CB LSrg== X-Gm-Message-State: ACrzQf340Mw3O4siXuOAaxh5L9iK5yS32j61qL5c2dcS4e50v2xnGw/z KpP9YPQyDSncRkxoWbQaaC8= X-Google-Smtp-Source: AMsMyM4WGKzVuVk5pKGXQeUyWX79QVfmMWp6V09APtaBF3UyrLppfS3rPHXcFNvl9XTG+y44UUibZQ== X-Received: by 2002:a5d:6446:0:b0:22c:df37:4d76 with SMTP id d6-20020a5d6446000000b0022cdf374d76mr3084302wrw.247.1665747929826; Fri, 14 Oct 2022 04:45:29 -0700 (PDT) Received: from ?IPv6:2001:8a0:f93a:3b00:e038:5cdc:b8bf:4653? ([2001:8a0:f93a:3b00:e038:5cdc:b8bf:4653]) by smtp.gmail.com with ESMTPSA id x6-20020a5d54c6000000b0022e2c38f8basm1738073wrv.14.2022.10.14.04.45.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Oct 2022 04:45:28 -0700 (PDT) Subject: Re: [PATCH v4] gdb/arm: Stop unwinding on error, but do not assert To: =?UTF-8?Q?Torbj=c3=b6rn_SVENSSON?= , gdb-patches@sourceware.org References: <20221013181135.688646-1-torbjorn.svensson@foss.st.com> From: Pedro Alves Message-ID: <6d3e2120-15bf-25e6-8914-8ec5b6e67976@palves.net> Date: Fri, 14 Oct 2022 12:45:27 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20221013181135.688646-1-torbjorn.svensson@foss.st.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Oct 2022 11:45:32 -0000 On 2022-10-13 7:11 p.m., Torbjörn SVENSSON wrote: > When it's impossible to read the FPCCR and XPSR, the unwinding is > unpredictable as the it's not possible to determine the correct > frame size or padding. > The only sane thing to do in this condition is to stop the unwinding. > > Example session wihtout this patch: wihtout -> without Thank you, this version LGTM. This way, there's a better chance gdb can distinguish different "outermost" frames, e.g., for watchpoints on local vars, or for stepping from a "broken" frame, to another "broken" frame. I'll defer final approval to Luis. Reviewed-by: Pedro Alves