From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60067.outbound.protection.outlook.com [40.107.6.67]) by sourceware.org (Postfix) with ESMTPS id 6D8103858407 for ; Fri, 29 Apr 2022 08:58:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6D8103858407 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=ljz8UuJvMvI8Ju+oeRjJYGu0CQPLa912bzWZmyYWYCZSEyPYpRQSS35SlU1AuafXR6586VVGDVUrI94ybi+DLSRbbACIViw4UAQcUxEPFjFxx/XPnktrDoqsgvd7NxIg8gixH2GQ2CP6UvHzy1/kD5TE9RZqZ3tdB7Rud5CKE8t/ryezMgB4DNRmaQF+DcCkzweO3UHa9oEqXms+netw1efw7PbkJXLYwyZJNYjqyyvjHaP4Yavj3X5C9WoE2/ngyidZ0kAdlfY7JKKhJcxwbrDkGl8E508HzNSlKU5ZrNpQokly7h2Js9FYdp1/mQT4ZbM/xw7oR/7+INvm/tAuZg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SWiKTy5VR7SQArub1tqa07NVCwCc990j67cnYQk8DAk=; b=U2O87Ydg9adO7IcXKV7HITZCF3jxTaycVsUTArIYxX0Y1g3PkpYdFj+JaDzJd2+fnSymqxcOC72rPrxpGpMjOEaOJEab5VBNAroxEJPnT6xsHHCrhSxfM538ffL03KrKFfMzYp450Yl4tVSXONOjNrHmU5CK9nuikLn3xK9kDyv8llNARC6+PjR/1kRn4FBZXfSZBYkbmGDyBJ1NJYCYAqkZUb2z2jJAGGW9nCxXhtrsooTbXD8Ea84PGfsd9bmDRMZgaTHbt9TC64b4KCwQQzdr1n/R4SPcKv6sQabizI972q+8RmKC+WY2uraa3amF/sU9WhXohoVDSEzrDPTmNQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) Received: from AM6P193CA0097.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:88::38) by DB6PR0802MB2470.eurprd08.prod.outlook.com (2603:10a6:4:a1::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Fri, 29 Apr 2022 08:58:30 +0000 Received: from VE1EUR03FT059.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:88:cafe::e3) by AM6P193CA0097.outlook.office365.com (2603:10a6:209:88::38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.14 via Frontend Transport; Fri, 29 Apr 2022 08:58:30 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT059.mail.protection.outlook.com (10.152.19.60) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.12 via Frontend Transport; Fri, 29 Apr 2022 08:58:29 +0000 Received: ("Tessian outbound facaf1373bbd:v118"); Fri, 29 Apr 2022 08:58:29 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 05821af6199ce5ae X-CR-MTA-TID: 64aa7808 Received: from 31ab9316389b.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 3888A7C4-02D1-4683-AE49-2267BBE00937.1; Fri, 29 Apr 2022 08:58:23 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 31ab9316389b.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 29 Apr 2022 08:58:23 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mjWDfAZS7AFn2Pzdl7DRQgbtvzeMHrulwIf/rmPwuk1/7xD5DAqX/vVasBWs2k3d6DgUdpbkBYVV68DftEY4YB5pfl8wLihl391+meayQLxoAHXFICvhaZPMkOYzzCMx+ww1exL7YyyIkJGWBFWaGWKEMySBS4wUxPvNCxzJRWx2M4BC/6s+Icro6tFYtEYe/0IK1XU2qKl9ZLchLvtgjBYARktD/PWpkvmE0RwOvfci5eCldJrtWZIwvZXwEYkhcQfTqFqzVAP6JdlWqxQpimqW1qf1ZJt1iLtLPbHbvxD9nugNxE8zEqQmNZE5jemRfqVNKYjj4uhC7WBGy99kVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SWiKTy5VR7SQArub1tqa07NVCwCc990j67cnYQk8DAk=; b=YDziLlJYGJTz/IjlG10mHshnKMrTo+IdQiRVuv2quEDNGZ2aWdLQOY+VHUZcmT/sORcUvPWkLICDVRRe27nR/uBciQhydcGD+DzIP5S7mFDM3L/C7CDhgkcHgNih1T4AQ0ZFevF1AK9ofH5DVTN3DLVe9O37neuQyHLlNi1ECKNc0KPnD3VW41uNMtQ7ayNTobtlXECLCK0V01u3f7isGOrzX2C/ynf1Jd9e4NI7XocGMot3++wx1pOPqjypEqi3hh96VbPJwrLIj3T3ggbKAnkKsyhrR3tLGNOMKGn8Cb8o8psePfyTOVpuQsLV50uCVWJ1+CTaigwpEEs+TgN3uw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by HE1PR08MB2922.eurprd08.prod.outlook.com (2603:10a6:7:2e::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.20; Fri, 29 Apr 2022 08:58:20 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::7080:6233:cf8f:a8a6]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::7080:6233:cf8f:a8a6%7]) with mapi id 15.20.5186.023; Fri, 29 Apr 2022 08:58:20 +0000 Message-ID: <6d4bd7ec-89de-c115-3205-b0d1999b3aab@arm.com> Date: Fri, 29 Apr 2022 09:58:18 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH] Fix crash with "maintenance print arc" Content-Language: en-US To: Tom Tromey , Luis Machado via Gdb-patches References: <20220427100753.364631-1-luis.machado@arm.com> <87h76dmdp9.fsf@tromey.com> From: Luis Machado In-Reply-To: <87h76dmdp9.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO3P123CA0013.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:ba::18) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 83848090-cb87-46ab-2674-08da29be6e35 X-MS-TrafficTypeDiagnostic: HE1PR08MB2922:EE_|VE1EUR03FT059:EE_|DB6PR0802MB2470:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: XaKYLCBLqEhPyrlizHN5GuGr6Eg2p7rRnZDfrVYW7Q27RsP4e2bY8g7ynNS8RmLST/bccno0I9H4Bur6EgAtU0jrwuMd/87beEYocGRF1gvI0zPa4JVLkd8RJGTxcqJ0obiJnsblU7up5QBD5/qNNr6FowzmAVVhRdk0Xjdfxg9DwyUPpvXQN+BQrk99yrrosLZsuqOJJ1ZzPJg9A85qLIMNCCuwj9r0aOgXSHsqC1RsmGRuqqUwyt3JXk0ACa6WeGmnpJoxezr2gbA28KkMJRHwe0/9/d2ikhGfZGNcXKBr2Wz2YxoEnRdvqZzaIj+iSZ2c0rBKWnq6YWtBfi1yvtl38uRTd3RYXHFk08W8uzlh3lT6P4NLWZOqjlDAlzhASqLecdnY3ZOlnZqeIqKbMGFIOdMokxciVs7cDWIyCdbgfKQ7REW0EzwFpXdFyfEW1zQxqk/B8qUdiZe2UBPZmHOgh78Nqn7UBlKeHLNwqZM0+jzq3mZnMH0FCJ4iNqJUBXzpHReDlBIvc14ph5JIzAdzlTPp9jOMi9iaieGMP95r6TOAAUFMVheZ9xeCNUcpd/vcbqdLd/p1SLJ27lqkIIkhMfZnzwFunTfMPtE4ElPMhy5xtT0WY9UOy7WRQU1sjnZefDgCaBSMi126CBgfZJ0ctZErxPMtfJ75HrXQHnRdc0t5cLU0rNPyte241F7IZaxuAdd4zETbXRWDdWG0LRt9kLwEXqRiotKDHVl+U8s= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR08MB3919.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(26005)(2616005)(110136005)(6506007)(6486002)(83380400001)(86362001)(38100700002)(186003)(31696002)(53546011)(508600001)(6512007)(5660300002)(316002)(36756003)(2906002)(8936002)(44832011)(8676002)(66946007)(66476007)(66556008)(31686004)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR08MB2922 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT059.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 97db8bdc-e2c0-4be2-68dc-08da29be689f X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 104D95RjA6fdgQLumRTEITHe9DQ2vGlk1Vri1xHNVcoTcyGBJ0QO8OTNkicYCYcZTXWT6rWhQqo4erK8b96BngEtCoDJXZusSQ4cSFz4AJCb1piyUSnXJti+iclgVpNF2QCmfDM8VvDkPo2+XPrm8tYAn97IRb7+WiKCUF7y7hldgVJbWMQaXr4ZLdjOeuOOWZyUg7wRD0unAKYWt2TaZ5JMdnXwlpiQlIkiLFYVQJ58ZOkMepFeethkka643kzbb6YnSNBbMr7gSrc6t5rPVC6IcDTRBIfw2YELzMDeZJM77QwP05HsiykCMhsvmCVUgN9jSUhOXUzFwvPcXtpxibgWXkC3JnVFrLBSNuuYLVhLJOrDVq4wIfN+be9lAnat1TNeyvCzvYMhAfKnOQQGA8TA+pbdrohJVcPnc9Tl9kunsQJNsNnuPYjOgR0/i8fkepqnpQLENwZpiYSr1kl1k1u+SSe2cHwvtfVXCgfilyMX2XzsA3gdsf0CvEAPkGd/2Fxr7zJRsar2OUCj/fJtGVVgYxoxkMBh+mv00SCtahm6xaKHHyu0ePqYSEmkSf5TgyCl3E+S6R3NClY8AaptIEEJYPPOLQCMT1Gmqb5gdKXqVsSDZniyMqr1TW68NkeuH/G228N5MbIpUWYWvHF7qLp04jv6qlxudPt0QIxx6a/7+DWO/tAhg/L9ZSI2BQlCULNC4sJQHNHRPtXxjmfqOQ== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(81166007)(44832011)(6506007)(82310400005)(316002)(8936002)(2616005)(47076005)(36860700001)(26005)(70586007)(70206006)(83380400001)(31696002)(508600001)(336012)(6486002)(110136005)(36756003)(6512007)(8676002)(31686004)(40460700003)(186003)(86362001)(356005)(2906002)(53546011)(5660300002)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2022 08:58:29.4765 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 83848090-cb87-46ab-2674-08da29be6e35 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT059.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2470 X-Spam-Status: No, score=-14.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Apr 2022 08:58:35 -0000 On 4/28/22 16:26, Tom Tromey wrote: >>>>>> "Luis" == Luis Machado via Gdb-patches writes: > > Luis> While doing something else, I noticed GDB crashed with > Luis> "maintenance print arc". > > I think the bug here is that this uses add_show_prefix_cmd and not > add_basic_prefix_cmd. See the appended, which also fixes the crash. Ah, you're right. It did look odd why we were feeding maint commands to code that is supposed to handle show commands. > > Luis> This happens because the code expects to find a "show" string pattern > Luis> within "maintenance print arc", since "arc" here is a prefix, and skip it. > Luis> In this case though, it won't find it, and we will have a bad pointer > Luis> getting dereferenced. > > This looks reasonable to me. Should we prevent further situations like this by asserting that we don't have a class_maintenance prefix being registered as a show prefix? > > Tom > > diff --git a/gdb/arc-tdep.c b/gdb/arc-tdep.c > index 98bd1c4bc0a..3edfd466f3b 100644 > --- a/gdb/arc-tdep.c > +++ b/gdb/arc-tdep.c > @@ -2474,11 +2474,11 @@ _initialize_arc_tdep () > /* Register ARC-specific commands with gdb. */ > > /* Add root prefix command for "maintenance print arc" commands. */ > - add_show_prefix_cmd ("arc", class_maintenance, > - _("ARC-specific maintenance commands for printing GDB " > - "internal state."), > - &maintenance_print_arc_list, > - 0, &maintenanceprintlist); > + add_basic_prefix_cmd ("arc", class_maintenance, > + _("ARC-specific maintenance commands for printing GDB " > + "internal state."), > + &maintenance_print_arc_list, > + 0, &maintenanceprintlist); > > add_cmd ("arc-instruction", class_maintenance, > dump_arc_instruction_command,