From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id DDA92384641C for ; Wed, 8 May 2024 19:40:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DDA92384641C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org DDA92384641C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715197219; cv=none; b=uvqlSNQ2oHbA1ZHFmlmqZYu8XZ8qKBjb2+HFGTtXge+xcQCZnH6GQaCleDnQ0Q46KAcmhPzpA2j8rT0zBOcr67zGc4tzORfY2Im9hGAYypTjfv+2WiAAwxYA+lbHcUpU6CsEbPRA/eg7fAxt++KNbT1u7SnP5t6BP4eRa2lhsxg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715197219; c=relaxed/simple; bh=ctCalTGd7Chng317uSXHJJxLneD5FmkBwhKj5+qiWi4=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=tUyUwA6gLSbrSWeMLN1mYbSZLwb9yG0l2SYToWROijEcg7DYKAlOHmTjNXAr2xwlIud7I3pjR8l0UYmdd5XCp6/hKA4I4VDn85EVF4lHHSEzl/ivMBYdjWFYykALp/52snBnn8B6TWdTmbAxjYYcnyF4W2zqnAb6amQmFV+EJq4= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1715197217; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KMXMXWeA3kDqNGf/U7Qd5F4KDmxExgbf5LOlQ6WXsCE=; b=UENj93bkeH2P6VZ0rZrh3V6ma/0wOq722tsIJfclqnwCuiX++DuU/Z/yPAV5IkixvdiYVQ CmsTjHiyPGxCT/bbbeYwsjxIceHJ5q17dP3HM/VrLebAIOceP9yJ0xDZfNW7ZPYDvOSdlO OFVk2p8UY5bps6v2gAxsW31wwCXvZsQ= Received: from mail-yw1-f200.google.com (mail-yw1-f200.google.com [209.85.128.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-639-SSEpSmmJPGmY2diX9r6ojg-1; Wed, 08 May 2024 15:40:14 -0400 X-MC-Unique: SSEpSmmJPGmY2diX9r6ojg-1 Received: by mail-yw1-f200.google.com with SMTP id 00721157ae682-61be1fcf9abso1611167b3.1 for ; Wed, 08 May 2024 12:40:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715197213; x=1715802013; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KMXMXWeA3kDqNGf/U7Qd5F4KDmxExgbf5LOlQ6WXsCE=; b=D+840AOD/u/iUhU0F+ahC1U6Pe6UTp3S1GpinIy+yoNqjEpNDMXXVFHb1yKkX8Sgo0 ByINn04h88XVDMivR60ZHnnxWABecCCpWBeP6ANbTTNyCZcr41CfKMKyiQcOOyUjcdYF VyUAKp8WCSMbwB34CQcVdlEA30tdZg9ni/j01Kja3S24OjB4APqii8uzuTKpZC0SZr3L Ixve6/sYNG+jdwFrbF/ZYA+YySdB2g//1HPPo/wveDlQbPhwz/f5nPAqL4J27dqyG4Ef G17wwvq5sJrHyiA804y6bPTviGpmYNkyqaU7eaE//iWGCELSFfwtx3Q8iLf8L84u9jo2 i0Fg== X-Gm-Message-State: AOJu0Yx/7LmGVnT/sndXFSVqiWnzGZ28+/hqLK/RBNTjdl53NhlB4lJm 3EY5gbh7fYlF+HAxSJw/vZeIGkeqTS6c3dHFe1wqW4M6R8tvGE/EsXznufEaRKoRiKm5FLSpa4n 8s45PtV+mqt6beD8wsZ1XMABQFQoJNke272070eQ7JRJz3wyRNeSNB8pVTqpVrVgOBJU= X-Received: by 2002:a0d:d986:0:b0:61b:33c8:7bce with SMTP id 00721157ae682-62085ca65bcmr38339697b3.31.1715197213191; Wed, 08 May 2024 12:40:13 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGNKquDBEi3u45BRr/EDeZa0N1R7HDBUUXH8fxf1YQyQk20qm5GwMrjPg3OvdTGAhfXcGMYhw== X-Received: by 2002:a0d:d986:0:b0:61b:33c8:7bce with SMTP id 00721157ae682-62085ca65bcmr38339307b3.31.1715197212270; Wed, 08 May 2024 12:40:12 -0700 (PDT) Received: from ?IPV6:2804:14d:8084:92c5::1000? ([2804:14d:8084:92c5::1000]) by smtp.gmail.com with ESMTPSA id ch9-20020a05622a40c900b00436e193f408sm7977132qtb.28.2024.05.08.12.40.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 May 2024 12:40:11 -0700 (PDT) Message-ID: <6d4e46f2-2e6b-4c4f-acc7-effa93dd34b5@redhat.com> Date: Wed, 8 May 2024 16:40:08 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/5] gdb: add "unwinder class" to frame unwinders To: Eli Zaretskii Cc: gdb-patches@sourceware.org References: <20240508145455.2550696-1-blarsen@redhat.com> <20240508145455.2550696-3-blarsen@redhat.com> <86zft088sm.fsf@gnu.org> From: Guinevere Larsen In-Reply-To: <86zft088sm.fsf@gnu.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 5/8/24 15:20, Eli Zaretskii wrote: >> From: Guinevere Larsen >> Cc: Guinevere Larsen >> Date: Wed, 8 May 2024 11:54:52 -0300 >> >> A future patch will add a way to disable certain unwinders based on >> different characteristics. This patch aims to make it more convenient >> to disable related unwinders in bulk, such as architecture specific >> ones, by indentifying all unwinders by which part of the code adds it. >> The classes, and explanations, are as follows: >> >> * GDB: An internal unwinder, added by GDB core, such as the unwinder >> for dummy frames; >> * EXTENSION: Unwinders added by extension languages; >> * DEBUGINFO: Unwinders installed by the debug info reader; >> * ARCH: Unwinders installed by the architecture specific code. > Thanks. I wonder whether some of the above should in the manual as > well. >> diff --git a/gdb/NEWS b/gdb/NEWS >> index 050f6f96e62..679295f0507 100644 >> --- a/gdb/NEWS >> +++ b/gdb/NEWS >> @@ -32,6 +32,10 @@ maintenance info line-table >> if the line is considered the start of the epilgoue, and thus a point at >> which the frame can be considered destroyed. >> >> +mainenance info frame-unwinders >> + Add a CLASS column to the output. This class is a somewhat arbitrary >> + grouping of unwinders, based on which area of GDB adds the unwinder. > This part is okay. > >> diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo >> index 61f91ef4ad6..3fc0fafa3cd 100644 >> --- a/gdb/doc/gdb.texinfo >> +++ b/gdb/doc/gdb.texinfo >> @@ -42094,7 +42094,7 @@ architecture, then enabling this flag does not cause them to be used. >> >> @kindex maint info frame-unwinders >> @item maint info frame-unwinders >> -List the frame unwinders currently in effect, starting with the highest priority. >> +List the frame unwinders currently in effect, starting with the highest priority. This also lists the unwinder class, which is mostly defined by which area of @value{GDBN} uses it. > This is also okay, but please split the long line into a few, so that > each line is shorter than 79 characters. And also please consider > adding the list of currently known classes to the above description. > > Reviewed-By: Eli Zaretskii > Thanks for the quick review! I added the following diff to fix the comments: diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo index a3226d98ff6..862dd152ab2 100644 --- a/gdb/doc/gdb.texinfo +++ b/gdb/doc/gdb.texinfo @@ -42094,7 +42094,16 @@ architecture, then enabling this flag does not cause them to be used.  @kindex maint info frame-unwinders  @item maint info frame-unwinders -List the frame unwinders currently in effect, starting with the highest priority.  This also lists the unwinder class, which is mostly defined by which area  of @value{GDBN} uses it. +List the frame unwinders currently in effect, starting with the highest +priority.  This also lists the unwinder class, which is mostly defined by +which area  of @value{GDBN} uses it.  The currently available classes are: + +@table @samp +@item GDB: An internal unwinder, added by GDB core; +@item EXTENSION: Unwinders added by extension languages; +@item DEBUGINFO: Unwinders installed by debug information readers; +@item ARCH: Unwinders isntalled by the architecture specific code. +@end table  @kindex maint frame-unwinder disable  @kindex maint frame-unwinder enable -- Cheers, Guinevere Larsen She/Her/Hers