From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id A74AC3858D28 for ; Tue, 2 May 2023 15:38:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A74AC3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id C593C215EF; Tue, 2 May 2023 15:38:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1683041912; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=moPRBOdmdLjbi1NEKqi5rHWt88qEYjIvB4QsXwo5Z48=; b=gp/S318ZDjoRdiY7bY0qf/bjmpfYTeMWUhlf8jgY191Gzu1BaDDWfKLqCACOBbFJWxzPAS zBoozYUZvQ7sZmdY9XJCf1reUfdmANfg57nrHzoTc/D+juWmhFVUjN4WDTZwQ7v2fwI/FG geu+kFiB7TTFDFAboMH5boNHy3uPQcs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1683041912; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=moPRBOdmdLjbi1NEKqi5rHWt88qEYjIvB4QsXwo5Z48=; b=A34MXQAeU/FqJRgsuS+UnZjaBFRdxvi5n3exY1gPrh/e6SidqyAY74rVsUf2m9oM0btjPc J3rsM3JxkHmk/tBQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id ADBC1134FB; Tue, 2 May 2023 15:38:32 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 1tJoKXguUWQTJwAAMHmgww (envelope-from ); Tue, 02 May 2023 15:38:32 +0000 Content-Type: multipart/mixed; boundary="------------MHJIdENr0oKuxA3NYAf7oNcB" Message-ID: <6d526208-a85c-fcdd-700d-3b3d8a5588d6@suse.de> Date: Tue, 2 May 2023 17:38:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [pushed 1/4] [gdb/testsuite] Don't use string cat in gdb.dwarf2/dw2-abs-hi-pc.exp Content-Language: en-US To: Andreas Schwab , Tom de Vries via Gdb-patches Cc: Tom Tromey References: <20230424124846.29580-1-tdevries@suse.de> <874jp5z0n8.fsf@tromey.com> <2a3587b4-98c4-263a-7deb-9530fbf06c57@suse.de> <878refyfgn.fsf@tromey.com> <97d43c1a-45d2-6ec5-001f-e20709342ce3@suse.de> <877ctzjf37.fsf@linux-m68k.org> From: Tom de Vries In-Reply-To: <877ctzjf37.fsf@linux-m68k.org> X-Spam-Status: No, score=-13.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --------------MHJIdENr0oKuxA3NYAf7oNcB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/26/23 09:08, Andreas Schwab wrote: > On Apr 26 2023, Tom de Vries via Gdb-patches wrote: > >> FWIW, reading a bit more about it I get the impression also set is >> idiomatic, so I came up with this: >> ... >> set res [lmap v $l { set v $v/c ; set v }] >> ... >> which works as well. > > You won't need the second set, though, since the first set already > returns the assigned value. > Andreas, thanks for the review. Committed as attached. Thanks, - Tom --------------MHJIdENr0oKuxA3NYAf7oNcB Content-Type: text/x-patch; charset=UTF-8; name="0001-gdb-testsuite-Use-set-in-lmap-in-gdb.dwarf2-dw2-abs-.patch" Content-Disposition: attachment; filename*0="0001-gdb-testsuite-Use-set-in-lmap-in-gdb.dwarf2-dw2-abs-.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSAyY2VmM2VkMTA0MGQ0ZjUxOTFmYmM1M2ViYzgyZmRiM2E2MzVmN2QxIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBUb20gZGUgVnJpZXMgPHRkZXZyaWVzQHN1c2UuZGU+ CkRhdGU6IFR1ZSwgMiBNYXkgMjAyMyAxNzoyODo1MCArMDIwMApTdWJqZWN0OiBbcHVzaGVk XSBbZ2RiL3Rlc3RzdWl0ZV0gVXNlIHNldCBpbiBsbWFwIGluCiBnZGIuZHdhcmYyL2R3Mi1h YnMtaGktcGMuZXhwCgpJbiBnZGIuZHdhcmYyL2R3Mi1hYnMtaGktcGMuZXhwIHdlIGRvOgou Li4Kc2V0IHNvdXJjZXMgW2xtYXAgaSAkc291cmNlcyB7IGV4cHIgeyAiJHNyY2Rpci8kc3Vi ZGlyLyRpIiB9IH1dCi4uLgoKVGhlIHVzZSBvZiBleHByIGlzIG5vdCBpZGlvbWF0aWMuICBG aXggdGhpcyBieSB1c2luZyBzZXQgaW5zdGVhZDoKLi4uCnNldCBzb3VyY2VzIFtsbWFwIGkg JHNvdXJjZXMgeyBzZXQgdG1wICRzcmNkaXIvJHN1YmRpci8kaSB9XQouLi4KClJlcG9ydGVk LUJ5OiBUb20gVHJvbWV5IDx0b21AdHJvbWV5LmNvbT4KUmV2aWV3ZWQtQnk6IEFuZHJlYXMg U2Nod2FiIDxzY2h3YWJAc3VzZS5kZT4KLS0tCiBnZGIvdGVzdHN1aXRlL2dkYi5kd2FyZjIv ZHcyLWFicy1oaS1wYy5leHAgfCAyICstCiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24o KyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9nZGIvdGVzdHN1aXRlL2dkYi5kd2Fy ZjIvZHcyLWFicy1oaS1wYy5leHAgYi9nZGIvdGVzdHN1aXRlL2dkYi5kd2FyZjIvZHcyLWFi cy1oaS1wYy5leHAKaW5kZXggMmVhNmE1Y2VhMDAuLjViNWQ2NzhlYzdhIDEwMDY0NAotLS0g YS9nZGIvdGVzdHN1aXRlL2dkYi5kd2FyZjIvZHcyLWFicy1oaS1wYy5leHAKKysrIGIvZ2Ri L3Rlc3RzdWl0ZS9nZGIuZHdhcmYyL2R3Mi1hYnMtaGktcGMuZXhwCkBAIC0yNCw3ICsyNCw3 IEBAIHNldCBzb3VyY2VzIFwKIAkgJHt0ZXN0ZmlsZX0uYyBcCiAJICR7dGVzdGZpbGV9LWhl bGxvLmMgXAogCSAke3Rlc3RmaWxlfS13b3JsZC5jXQotc2V0IHNvdXJjZXMgW2xtYXAgaSAk c291cmNlcyB7IGV4cHIgeyAiJHNyY2Rpci8kc3ViZGlyLyRpIiB9IH1dCitzZXQgc291cmNl cyBbbG1hcCBpICRzb3VyY2VzIHsgc2V0IHRtcCAkc3JjZGlyLyRzdWJkaXIvJGkgfV0KIAog bGFzc2lnbiBbZnVuY3Rpb25fcmFuZ2UgaGVsbG8gJHNvdXJjZXNdIFwKICAgICBoZWxsb19z dGFydCBoZWxsb19sZW4KCmJhc2UtY29tbWl0OiBiNTQ1ZDQyMzliZWRmOTAwMTkyNmVmZDU1 ZGEyYWEyYmQyYmJiOTRhCi0tIAoyLjM1LjMKCg== --------------MHJIdENr0oKuxA3NYAf7oNcB--