From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 58716 invoked by alias); 18 Oct 2018 12:56:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 58699 invoked by uid 89); 18 Oct 2018 12:56:18 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: =?ISO-8859-1?Q?No, score=-25.5 required=5.0 tests=BAYES_05,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.2 spammy=f90, sk:mi_var_, it.=c2, sk:bp_inli?= X-HELO: mx1.suse.de Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 18 Oct 2018 12:56:17 +0000 Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 9DE63AEF3; Thu, 18 Oct 2018 12:56:14 +0000 (UTC) Subject: Re: Upper case test names To: Simon Marchi Cc: Gary Benson , gdb-patches@sourceware.org, Pedro Alves References: <20181005101122.GA23867@delia> <20181009135155.GB12668@blade.nx> <8f8ffb94-5a0c-8b2b-d541-eaacd7d1f42c@suse.de> <20181010092735.GA29557@blade.nx> <20181010134423.GA23926@blade.nx> <20181011074744.GA7677@delia> <750f69f3ea27d2ca530c896eef51e9eb@polymtl.ca> <3fcc0352796fb53a7d4e5ed06f62aca5@polymtl.ca> From: Tom de Vries Message-ID: <6d61979b-a896-976d-df0a-b056bb4c0e3a@suse.de> Date: Thu, 18 Oct 2018 12:56:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <3fcc0352796fb53a7d4e5ed06f62aca5@polymtl.ca> Content-Type: multipart/mixed; boundary="------------A8CAA7441F81A5752BD0EC49" X-IsSubscribed: yes X-SW-Source: 2018-10/txt/msg00393.txt.bz2 This is a multi-part message in MIME format. --------------A8CAA7441F81A5752BD0EC49 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-length: 365 On 10/17/18 2:07 PM, Simon Marchi wrote: >> Does this need fixing? > > Sure, it would need fixing, if you want to take the time to do it.  > Here's the reference in our wiki where that rule is stated, for reference. > > https://sourceware.org/gdb/wiki/GDBTestcaseCookbook#Follow_the_test_name_convention > Tested on x86_64-linux. OK for trunk? Thanks, - Tom --------------A8CAA7441F81A5752BD0EC49 Content-Type: text/x-patch; name="0001-gdb-testsuite-Fix-capitalized-test-names.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="0001-gdb-testsuite-Fix-capitalized-test-names.patch" Content-length: 5381 [gdb/testsuite] Fix capitalized test names At https://sourceware.org/gdb/wiki/GDBTestcaseCookbook\ #Follow_the_test_name_convention we find: .. Test names should start with a lower case and don't need to end with a period (they are not sentences). ... Fix some capitalized test names. 2018-10-18 Tom de Vries * gdb.ada/bp_inlined_func.exp: Fix capitalized test name. * gdb.ada/excep_handle.exp: Same. * gdb.ada/mi_string_access.exp: Same. * gdb.ada/mi_var_union.exp: Same. * gdb.arch/arc-analyze-prologue.exp: Same. * gdb.arch/arc-decode-insn.exp: Same. * gdb.base/readnever.exp: Same. * gdb.fortran/printing-types.exp: Same. * gdb.guile/scm-lazy-string.exp: Same. --- gdb/testsuite/gdb.ada/bp_inlined_func.exp | 2 +- gdb/testsuite/gdb.ada/excep_handle.exp | 2 +- gdb/testsuite/gdb.ada/mi_string_access.exp | 2 +- gdb/testsuite/gdb.ada/mi_var_union.exp | 2 +- gdb/testsuite/gdb.arch/arc-analyze-prologue.exp | 2 +- gdb/testsuite/gdb.arch/arc-decode-insn.exp | 2 +- gdb/testsuite/gdb.base/readnever.exp | 2 +- gdb/testsuite/gdb.fortran/printing-types.exp | 2 +- gdb/testsuite/gdb.guile/scm-lazy-string.exp | 2 +- 9 files changed, 9 insertions(+), 9 deletions(-) diff --git a/gdb/testsuite/gdb.ada/bp_inlined_func.exp b/gdb/testsuite/gdb.ada/bp_inlined_func.exp index 2013e6be82..f7aa1c38cc 100644 --- a/gdb/testsuite/gdb.ada/bp_inlined_func.exp +++ b/gdb/testsuite/gdb.ada/bp_inlined_func.exp @@ -24,7 +24,7 @@ if {[gdb_compile_ada "${srcfile}" "${binfile}" executable [list debug ]] != "" } clean_restart ${testfile} if ![runto_main] then { - fail "Cannot run to main, testcase aborted" + fail "cannot run to main, testcase aborted" return 0 } diff --git a/gdb/testsuite/gdb.ada/excep_handle.exp b/gdb/testsuite/gdb.ada/excep_handle.exp index c693fd30ea..b7cd6dcd70 100644 --- a/gdb/testsuite/gdb.ada/excep_handle.exp +++ b/gdb/testsuite/gdb.ada/excep_handle.exp @@ -43,7 +43,7 @@ set catchpoint_storage_error_msg \ ############################################ if ![runto_main] then { - fail "Cannot run to main, testcase aborted" + fail "cannot run to main, testcase aborted" return 0 } diff --git a/gdb/testsuite/gdb.ada/mi_string_access.exp b/gdb/testsuite/gdb.ada/mi_string_access.exp index 8ecf907b1e..adae4ab13f 100644 --- a/gdb/testsuite/gdb.ada/mi_string_access.exp +++ b/gdb/testsuite/gdb.ada/mi_string_access.exp @@ -34,7 +34,7 @@ mi_gdb_reinitialize_dir $srcdir/$subdir mi_gdb_load ${binfile} if ![mi_run_to_main] then { - fail "Cannot run to main, testcase aborted" + fail "cannot run to main, testcase aborted" return 0 } diff --git a/gdb/testsuite/gdb.ada/mi_var_union.exp b/gdb/testsuite/gdb.ada/mi_var_union.exp index 26a7ed0dd4..51147a491e 100644 --- a/gdb/testsuite/gdb.ada/mi_var_union.exp +++ b/gdb/testsuite/gdb.ada/mi_var_union.exp @@ -36,7 +36,7 @@ mi_gdb_reinitialize_dir $srcdir/$subdir mi_gdb_load ${binfile} if ![mi_run_to_main] then { - fail "Cannot run to main, testcase aborted" + fail "cannot run to main, testcase aborted" return 0 } diff --git a/gdb/testsuite/gdb.arch/arc-analyze-prologue.exp b/gdb/testsuite/gdb.arch/arc-analyze-prologue.exp index d874515d2b..6a4d60eebc 100644 --- a/gdb/testsuite/gdb.arch/arc-analyze-prologue.exp +++ b/gdb/testsuite/gdb.arch/arc-analyze-prologue.exp @@ -27,7 +27,7 @@ if { [prepare_for_testing "failed to prepare" $testfile $srcfile] } { } if ![runto_main] { - fail "Can't run to main" + fail "can't run to main" return 0 } diff --git a/gdb/testsuite/gdb.arch/arc-decode-insn.exp b/gdb/testsuite/gdb.arch/arc-decode-insn.exp index 7ee666b0d7..a4cd7c7948 100644 --- a/gdb/testsuite/gdb.arch/arc-decode-insn.exp +++ b/gdb/testsuite/gdb.arch/arc-decode-insn.exp @@ -43,7 +43,7 @@ if { [prepare_for_testing "failed to prepare" $testfile $srcfile] } { } if ![runto_main] { - fail "Can't run to main" + fail "can't run to main" return 0 } diff --git a/gdb/testsuite/gdb.base/readnever.exp b/gdb/testsuite/gdb.base/readnever.exp index 805ecd218a..c712dae9e5 100644 --- a/gdb/testsuite/gdb.base/readnever.exp +++ b/gdb/testsuite/gdb.base/readnever.exp @@ -16,7 +16,7 @@ standard_testfile .c if { [build_executable "failed to build" $testfile $srcfile { debug }] == -1 } { - untested "Couldn't compile ${srcfile}" + untested "couldn't compile ${srcfile}" return -1 } diff --git a/gdb/testsuite/gdb.fortran/printing-types.exp b/gdb/testsuite/gdb.fortran/printing-types.exp index 9237907ed6..885bb64f8a 100644 --- a/gdb/testsuite/gdb.fortran/printing-types.exp +++ b/gdb/testsuite/gdb.fortran/printing-types.exp @@ -22,7 +22,7 @@ if {[prepare_for_testing $testfile.exp $testfile $srcfile {debug f90}]} { } if {![runto MAIN__]} then { - untested "Could not run to breakpoint MAIN__" + untested "could not run to breakpoint MAIN__" return -1 } diff --git a/gdb/testsuite/gdb.guile/scm-lazy-string.exp b/gdb/testsuite/gdb.guile/scm-lazy-string.exp index 52211b30f7..13cc885315 100644 --- a/gdb/testsuite/gdb.guile/scm-lazy-string.exp +++ b/gdb/testsuite/gdb.guile/scm-lazy-string.exp @@ -33,7 +33,7 @@ if { [skip_guile_tests] } { continue } # The following tests require execution. if ![gdb_guile_runto_main] { - fail "Can't run to main" + fail "can't run to main" return } --------------A8CAA7441F81A5752BD0EC49--