From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by sourceware.org (Postfix) with ESMTPS id D6E853858D28 for ; Mon, 6 May 2024 11:33:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D6E853858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D6E853858D28 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.85.128.53 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714995227; cv=none; b=tmw4D4ols1YaRzpw9ZErEVCKX2P8dj/drcG5suGrvXxlx4+Iw4cW/XYd08JNfjoLW/onR2FJVPEZs+Rc8xl32YWSuS/0YKMYeWWUAx3gBBBQPQpRW7/pjV1/z83VnaWe+sRYyJfJ/ZbF+N5bKvQ8/0u2VpXzPTgyKw0l+iHUF1o= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714995227; c=relaxed/simple; bh=zUCkgExgi3pxrOQCqw2pGDDjkK3vJujs3bHT6TG2lPo=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=OENhPMUUPFr94JrYMJjU/oItLiO3xtMQgrTkasHQ7y/EYM6MaIvOt+9DMcBkZxHEYxdTnP4poF7HgBiYcjOl/3UjVxbPN6rvoe7ZneAVkIHuJ+D5uv9ItHnMDhH5nUWYKs5T+QJIbQ7H76IGlu6UvUGczUzFlFRPqlU94SMWBgM= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-41b5dd5af48so14736175e9.0 for ; Mon, 06 May 2024 04:33:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714995225; x=1715600025; h=content-transfer-encoding:in-reply-to:content-language:from :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1NTe7t5QzBg5Bg+Xdkhf3fcsDP0kDizan8SC4p3z4dU=; b=ZKj1sEY2b3Rn+wWhKYSAn/nW/wywR/FDcrudrBPraW+we5ILhWG/O9aqhJUbwhN5cR gnfX33qGzKa1yMqnjX2733TLzCdS56e1LWe0Yve8NxPIPVMqBR9MPi7S1IHACUyG0s3f k5Ng3i684ga6evg+pbC68gKPFVPk+rsYZwiVMR4LWfbpqJhjQtyBZjzYmacUdh5RsL2W rnxqWnnZbE8lb1g0pa0WoQoHvfDkbp1rF7nP+KUpYaTmLbjwjnHsRj1FrCEWnhS5BIDp BbCod/vloehW1QMyDIqW7tqiyWPPwXlHv8MNyeRGms0fS15ObZui6JAcfYPMuRiC+62K Pzsg== X-Forwarded-Encrypted: i=1; AJvYcCVuf5cOCHH0YaheQhDkOd5rhM9GAsQeyiDD2Z3JacoKbgl5qoRKO3KGE7jJ33eATl79ltD1EYWJsPMwyzjnY8qdFw1X8Wl06AxVqA== X-Gm-Message-State: AOJu0YzmUCV0YKg+gs3LlV9DTT/aX68kAWLvXl8DyBIz6zAMVUoGlfMH jnM4txjhGSDviKg26rmc+wsQ8WDgYrSt6rJl4bMOnbSKli3eoiiv X-Google-Smtp-Source: AGHT+IEfJFXMjztb7HuOyr0pa10vzcUrjI84MpX4jbnBB7+FPjVb8lSerIJaaEb+cmdHtG4o6s8S7A== X-Received: by 2002:a05:600c:4ece:b0:41c:7ac6:d2e7 with SMTP id g14-20020a05600c4ece00b0041c7ac6d2e7mr7438926wmq.8.1714995224468; Mon, 06 May 2024 04:33:44 -0700 (PDT) Received: from ?IPV6:2001:8a0:f908:4900:9776:3062:4cf6:5141? ([2001:8a0:f908:4900:9776:3062:4cf6:5141]) by smtp.gmail.com with ESMTPSA id t15-20020a05600c198f00b0041c02589a7csm19535704wmq.40.2024.05.06.04.33.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 May 2024 04:33:44 -0700 (PDT) Message-ID: <6d6ae11b-6298-4611-89c9-4dd2a3e789c3@palves.net> Date: Mon, 6 May 2024 12:33:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] [gdb/testsuite] Handle ptrace operation not permitted in can_spawn_for_attach To: Tom de Vries , gdb-patches@sourceware.org References: <20240501083433.19966-1-tdevries@suse.de> From: Pedro Alves Content-Language: en-US In-Reply-To: <20240501083433.19966-1-tdevries@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2024-05-01 09:34, Tom de Vries wrote: > > - # Assume yes. > - return 1 > + # The normal sequence to use for a runtime test like > + # can_spawn_for_attach_1 is: > + # - gdb_exit (don't use a running gdb, we don't know what state it is in), > + # - gdb_start (start a new gdb), and > + # - gdb_exit (cleanup). > + # > + # By making can_spawn_for_attach_1 a gdb_caching_proc, we make it > + # unpredictable which test-case will call it first, and consequently a > + # test-case may pass in say a full test run, but fail when run > + # individually, due to a can_spawn_for_attach call in location where a "in a location", I presume. > + # gdb_exit (as can_spawn_for_attach_1 does) breaks things. Otherwise, Approved-By: Pedro Alves Thank you.