From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 6913A3858C52 for ; Mon, 27 Feb 2023 18:27:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6913A3858C52 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 31RIR90X028678 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 27 Feb 2023 13:27:13 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 31RIR90X028678 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1677522434; bh=gBayCmxXKy5Nmpo77m7TlJkROdX567+5B65DJ9T8KME=; h=Date:Subject:To:References:From:In-Reply-To:From; b=p6vdPy4h+f47dWMSFV23MKNgct2d1TA2xVOGs0XPRxurHkX8u8vf7plft2D9/HYVG cKroGIP7ymn4NFO2esSm4GnJflgJOFqA/q6tnvg6EUJfjw7IgI+Yo5rv4LOx5DBteC J7K/mPhG2ieOMHJfZ1PH6zzJWUMd33PCOnNhep6I= Received: from [172.16.0.192] (192-222-180-24.qc.cable.ebox.net [192.222.180.24]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id D25191E110; Mon, 27 Feb 2023 13:27:08 -0500 (EST) Message-ID: <6da4384b-2e75-643f-982b-2fcc6f20acca@polymtl.ca> Date: Mon, 27 Feb 2023 13:27:08 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v3 00/10] Add typing annotations to gdbarch*.py and make-target-delegates.py Content-Language: fr To: Andrew Burgess , Simon Marchi via Gdb-patches References: <20230227011403.612304-1-simon.marchi@polymtl.ca> <87r0ubhuuu.fsf@redhat.com> From: Simon Marchi In-Reply-To: <87r0ubhuuu.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Mon, 27 Feb 2023 18:27:09 +0000 X-Spam-Status: No, score=-3031.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/27/23 12:38, Andrew Burgess wrote: > Simon Marchi via Gdb-patches writes: > >> This is v3 of: >> >> https://inbox.sourceware.org/gdb-patches/20230225033047.373899-2-simon.marchi@polymtl.ca/T/#mc1d1b386fd1235edb2a331dd0a321cf703a3e67b >> >> Changes are: >> >> - In "gdb: split gdbarch component types to gdbarch_types.py", I had >> introduced one typing annotation by mistake. It should have been in >> the following commit. That is fixed now. >> - For container types (lists and dicts), use the types from the typing >> module, to be compatible with Pythons < 3.9. > > Tested this with my crusty old Python (3.7.9) and can confirm that this > all now runs fine, I see no changes in the generated files after running > your updated gdbarch.py script. Thanks for testing. > This all LGTM. > > Reviewed-By: Andrew Burgess Thanks, will push. I will keep Tom Tromey's Reviewed-By, because the patches didn't fundamentally change since he looked at them. Simon