From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15096 invoked by alias); 5 Mar 2010 14:08:22 -0000 Received: (qmail 15054 invoked by uid 22791); 5 Mar 2010 14:08:20 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40 X-Spam-Check-By: sourceware.org Received: from mail-ww0-f41.google.com (HELO mail-ww0-f41.google.com) (74.125.82.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 05 Mar 2010 14:08:16 +0000 Received: by wwg30 with SMTP id 30so1446399wwg.0 for ; Fri, 05 Mar 2010 06:08:13 -0800 (PST) MIME-Version: 1.0 Received: by 10.216.86.16 with SMTP id v16mr130080wee.162.1267798093826; Fri, 05 Mar 2010 06:08:13 -0800 (PST) In-Reply-To: <83eijz2h3i.fsf@gnu.org> References: <20100304180219.GA10826@intel.com> <20100304180408.GA10869@intel.com> <83eijz2h3i.fsf@gnu.org> Date: Fri, 05 Mar 2010 14:08:00 -0000 Message-ID: <6dc9ffc81003050608t5403a326u319f455475eafee2@mail.gmail.com> Subject: Re: PATCH: 2/6: Add AVX support (Update document) From: "H.J. Lu" To: Eli Zaretskii Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-03/txt/msg00230.txt.bz2 On Fri, Mar 5, 2010 at 2:33 AM, Eli Zaretskii wrote: >> Date: Thu, 4 Mar 2010 10:04:08 -0800 >> From: "H.J. Lu" >> >> This patch updates document for AVX support. =A0OK to install? > > Is it still relevant? > > I will review this anyway, in the hope that it will help you submit > the fixed patch down the way. Thanks. I will keep it in mind. >> +@item x86:xstate=3D@var{bytes}:xcr0=3D@var{value} >> +This feature indicates that @value{GDBN} supports x86 XSAVE extended > > It will look prettier in print if you use @sc{xsave} instead of > XSAVE. =A0(The result in the Info manual is the same.) > >> +state. @var{bytes} specifies the maximum size in bytes of x86 XSAVE > =A0 =A0 =A0 =A0^^ > Two spaces between sentences, please (here and elsewhere in your > patch). > >> +extended state @value{GDBN} supports. @var{value} specifies the >> +maximum value of the extended control register 0 (the >> +XFEATURE_ENABLED_MASK register) @value{GDBN} supports. =A0The stub shou= ld > > XFEATURE_ENABLED_MASK is a C symbol, so it should be in @code. > > Thanks. > --=20 H.J.