From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 049FF385800F for ; Sat, 29 May 2021 01:54:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 049FF385800F Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 14T1rvNX020289 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 28 May 2021 21:54:02 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 14T1rvNX020289 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 2BA781E813; Fri, 28 May 2021 21:53:57 -0400 (EDT) Subject: Re: [PATCH v2 5/5] gdb: mips: Add MIPSR6 support To: Faraz Shahbazker , gdb-patches@sourceware.org, Mike Frysinger Cc: Chao-ying Fu References: <20210524175802.875687-1-fshahbazker@wavecomp.com> <20210524175802.875687-6-fshahbazker@wavecomp.com> From: Simon Marchi Message-ID: <6dcec282-8dff-4a8b-d5c2-ed3c4cf0db51@polymtl.ca> Date: Fri, 28 May 2021 21:53:56 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210524175802.875687-6-fshahbazker@wavecomp.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Sat, 29 May 2021 01:53:57 +0000 X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 29 May 2021 01:54:13 -0000 On 2021-05-24 1:58 p.m., Faraz Shahbazker wrote: > 2021-05-24 Andrew Bennett > Matthew Fortune > Faraz Shahbazker > > gdb/ChangeLog: > * mips-tdep.c (is_mipsr6_isa): New. > (b0s21_imm): New define. > (mips32_relative_offset21, mips32_relative_offset26): New. > (is_add32bit_overflow, is_add64bit_overflow): New. > (mips32_next_pc): Handle r6 compact and fpu coprocessor branches. > Move handling of BLEZ, BGTZ opcode into ... > (mips32_blez_pc): New. > (mips32_instruction_is_compact_branch): New. > (mips32_insn_at_pc_has_forbidden_slot): New. > (mips32_scan_prologue): Ignore pre-r6 addi encoding on r6. > Stop at compact branch also. > (LLSC_R6_OPCODE,LL_R6_FUNCT,LLE_FUNCT, > LLD_R6_FUNCT,SC_R6_FUNCT,SCE_FUNCT, > SCD_R6_FUNCT: New defines. > (is_ll_insn, is_sc_insn): New. > (mips_deal_with_atomic_sequence): Use is_ll_insn/is_sc_insn. > Handle compact branches. > (mips_about_to_return): Handle jrc and macro jr. > (mips32_stack_frame_destroyed_p): Likewise. > (mips32_instruction_has_delay_slot): Don't handle JALX no r6. > Handle compact branches and coprocessor branches. > (mips_adjust_breakpoint_address): Skip forbidden slot for > compact branches. Hi, Please write a commit message describing what this does. Simon