From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3128 invoked by alias); 21 Feb 2019 16:05:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 3099 invoked by uid 89); 21 Feb 2019 16:05:29 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=respond X-HELO: relay.fit.cvut.cz Received: from relay.fit.cvut.cz (HELO relay.fit.cvut.cz) (147.32.232.237) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 21 Feb 2019 16:05:27 +0000 Received: from imap.fit.cvut.cz (imap.fit.cvut.cz [147.32.232.238]) by relay.fit.cvut.cz (8.15.2/8.15.2) with ESMTPS id x1LG5NUv007682 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 21 Feb 2019 17:05:25 +0100 (CET) (envelope-from jan.vrany@fit.cvut.cz) Received: from sao (02795030.bb.sky.com [2.121.80.48] (may be forged)) (authenticated bits=0 as user vranyj1) by imap.fit.cvut.cz (8.15.2/8.15.2) with ESMTPSA id x1LG5MfP019577 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Thu, 21 Feb 2019 17:05:23 +0100 (CET) (envelope-from jan.vrany@fit.cvut.cz) Message-ID: <6de282dee73cb44ae2016cb31254aa35c04e9816.camel@fit.cvut.cz> Subject: Re: [PATCH v2 0/2] MI: Add new command -complete From: Jan Vrany To: Tom Tromey Cc: gdb-patches@sourceware.org, "gdb@sourceware.org" Date: Thu, 21 Feb 2019 16:05:00 -0000 In-Reply-To: <87pnrmnolt.fsf@tromey.com> References: <87imynm3ia.fsf@tromey.com> <20190128124101.26243-1-jan.vrany@fit.cvut.cz> <87pnrmnolt.fsf@tromey.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.5-1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-02/txt/msg00350.txt.bz2 On Wed, 2019-02-20 at 14:20 -0700, Tom Tromey wrote: > > > > > > "Jan" == Jan Vrany writes: > > Jan> respond with something like (proposed change): > > Jan> -complete "br m" > Jan> =^done,text="br m",common="a",matches=["in", "dvise"] > > Jan> The rarionale is that frontend most likely needs these three > Jan> values anyway to implement completion. It can, indeed compute > Jan> them from full list as returned now, but GDB has these values > Jan> already so it would save the frontend doing the same work again. > > Jan> OTOH, current output is more on par with CLI command output. > > Jan> What do you think? > > I think if this form seems more useful to MI users, then it's fine to > implement it. I would say this is more important than making it similar > to the CLI. Are there any other GDB/MI users to comment on this? What would you prefer? Jan