From: Tom de Vries <tdevries@suse.de>
To: Tom Tromey <tromey@adacore.com>
Cc: Simon Marchi <simark@simark.ca>, Tom Tromey <tom@tromey.com>,
gdb-patches@sourceware.org
Subject: Re: [PATCH] Add flake8 and isort to .pre-commit-config.yaml
Date: Wed, 10 Apr 2024 07:38:13 +0200 [thread overview]
Message-ID: <6de479a3-0714-4659-b472-4503b7ae9d5e@suse.de> (raw)
In-Reply-To: <87cyqy5znd.fsf@tromey.com>
On 4/9/24 17:22, Tom Tromey wrote:
>>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
>
> Tom> So, atm I can no longer rebase. I'll try to workaround this by adding
> Tom> a local commit that reverts this change, or something similar, but if
> Tom> anybody has another idea I'd be happy to hear it.
>
> It sounds like you found a fix, but in extremis you can also
> "pre-commit uninstall" and just not use the hook.
Yes, I didn't realize that at the point I ran into the trouble. Perhaps
pre-commit could be improved to advertise considering using SKIP at that
point, that could have helped.
I dropped the approach of installing a second python version alongside,
I probably did something wrong but versions got mixed and things went
downhill from there pretty quickly. Deinstalling the second python
version was easy, but manually purging various files in ~/.local and
~/.cache to get back to a working state took some work.
Anyway, my current approach is to install the hooks and add a line:
...
export SKIP=flake8,isort
...
That way, I'm still running black.
Thanks,
- Tom
prev parent reply other threads:[~2024-04-10 5:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-02 18:11 Tom Tromey
2024-04-02 20:26 ` Simon Marchi
2024-04-03 19:52 ` Tom Tromey
2024-04-03 19:57 ` Simon Marchi
2024-04-09 7:58 ` Tom de Vries
2024-04-09 9:41 ` Kévin Le Gouguec
2024-04-09 12:56 ` Tom de Vries
2024-04-09 13:04 ` Kévin Le Gouguec
2024-04-09 15:22 ` Tom Tromey
2024-04-10 5:38 ` Tom de Vries [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6de479a3-0714-4659-b472-4503b7ae9d5e@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
--cc=tom@tromey.com \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).