From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id 216DC385840E for ; Wed, 10 Apr 2024 05:38:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 216DC385840E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 216DC385840E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712727495; cv=none; b=jQQagIIRQHOevqiWSHTRRAR7kM+hbvcfJApQnmadBoV12gSJTuxtKX7FD7b9vy+yIV9kgI3k0tKDkvYLyCOaQ513v0KL5T6xHovPmHiu8AN4HuhaZX6AiYWPA+6LZgdUOLKXPkCY/RK+qqjX8h9KUmLtczIMUgQQpJKfa6KTzQc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712727495; c=relaxed/simple; bh=hzRnDelbNS+hFW9fil+WF7+rLu74Dc1HHftVdlZfj70=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=vVtf+nQrxaPRKwT1nIqyBeicTefmNQdy2CW7hwRoPFMrnX/TH2sK8C9/uuk7geMXJ7YEh3YMpNIlnJbUgT/4uHNVfC92HJRPv5tHpnM31rtTEZ7reX1Ei3TyGQRmDPs+bxJfPtuqr6eUuC4HaKaXkPsqk06cLvo/fszXakvoW5c= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E6E245C4E5; Wed, 10 Apr 2024 05:38:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1712727492; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5yl8BTyWaazGFS0DUAixbV6+Wek3/KwrXmkpdylOfeg=; b=lVLt5rQrbTt/T0qlD1KA+/0At9cyRQOzQdlGsKOsoEdTqfHp/AGp5835NkDQFy7s4dQh0a A7DGCutSKtal9krYu6vxh7/fdxL3xgEzREY3MgddRdheQPx281yFsFuyDS2BXdf+XR/pGF RN72rpUcpbzL7+yc+u2GXg88WF4OidY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1712727492; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5yl8BTyWaazGFS0DUAixbV6+Wek3/KwrXmkpdylOfeg=; b=hiKt6EaJL2Sbl9s4bgZqZQT2sWZdlKQ6yOTHeZfzzJBbwwqD2MetSBbPnS/aKRMPg12PhM D6UT3jX45v5l0DBA== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1712727491; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5yl8BTyWaazGFS0DUAixbV6+Wek3/KwrXmkpdylOfeg=; b=mWkYPOcdTIn7O5idcE2jfanI+n/o8q6ytbqJOw9abg7Snn898Gbluww4vcN5419sX0AGNB MRuKPzqm60jcL3Wv4LhlRj2BTMAUz6xbi1prKfilfVOMeGJswxjWil15R/bYBwD31nzpzy e4XhDy9s+j9d5MQErP4uKCZcgvGvC0s= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1712727491; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5yl8BTyWaazGFS0DUAixbV6+Wek3/KwrXmkpdylOfeg=; b=Xq7+ZwKDoMHMLXZErduJU48ELJZ14AtyD4tpf74DSxknKABQgXPBm7UOkqI9sfpjDyx/dl MqCerr2YDkP7VLCQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id B038713942; Wed, 10 Apr 2024 05:38:11 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id WV/mKMMlFmZoDwAAD6G6ig (envelope-from ); Wed, 10 Apr 2024 05:38:11 +0000 Message-ID: <6de479a3-0714-4659-b472-4503b7ae9d5e@suse.de> Date: Wed, 10 Apr 2024 07:38:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Add flake8 and isort to .pre-commit-config.yaml To: Tom Tromey Cc: Simon Marchi , Tom Tromey , gdb-patches@sourceware.org References: <20240402181121.1948535-1-tromey@adacore.com> <87il0y6x62.fsf@tromey.com> <93111957-7c0a-4896-8fa2-81ea24d6f9d0@suse.de> <87cyqy5znd.fsf@tromey.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <87cyqy5znd.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Level: X-Spamd-Result: default: False [-2.32 / 50.00]; BAYES_HAM(-1.03)[87.48%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; XM_UA_NO_VERSION(0.01)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+]; TO_DN_SOME(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; ARC_NA(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.de:email] X-Spam-Score: -2.32 X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/9/24 17:22, Tom Tromey wrote: >>>>>> "Tom" == Tom de Vries writes: > > Tom> So, atm I can no longer rebase. I'll try to workaround this by adding > Tom> a local commit that reverts this change, or something similar, but if > Tom> anybody has another idea I'd be happy to hear it. > > It sounds like you found a fix, but in extremis you can also > "pre-commit uninstall" and just not use the hook. Yes, I didn't realize that at the point I ran into the trouble. Perhaps pre-commit could be improved to advertise considering using SKIP at that point, that could have helped. I dropped the approach of installing a second python version alongside, I probably did something wrong but versions got mixed and things went downhill from there pretty quickly. Deinstalling the second python version was easy, but manually purging various files in ~/.local and ~/.cache to get back to a working state took some work. Anyway, my current approach is to install the hooks and add a line: ... export SKIP=flake8,isort ... That way, I'm still running black. Thanks, - Tom