Re: [PATCH][gdb/testsuite] Support .debug_aranges in dwarf assembly

[Keith Seitz <keiths@redhat.com>]

On 8/27/21 8:09 AM, Simon Marchi via Gdb-patches wrote:
> 
> 
> On 2021-08-27 9:35 a.m., Tom Tromey wrote:
>>>>>>> "Tom" == Tom de Vries via Gdb-patches <gdb-patches@sourceware.org> writes:
>>
>> Tom> +    #   arange [-c <comment>] [<segment selector>] <start> <length>
>> Tom> +    #     -- adds an address range.
>>
>> I wonder if there's a way to make this more tcl-ish, say by rearranging
>> the order of arguments so that things can be defaulted.  I think the
>> "args"-parsing style should normally be a last resort.
> 
> I personally don't like this style
> 
>     proc arange { arange_start arange_length {comment ""} {seg_sel ""} }
> 
> ... because if you want to specify the last parameter, you need to give
> all the other optional ones before.

The test suite also contains the convenience proc parse_args which allows
the use of optional arguments using flag-like syntax and default values.

    proc arange {start length args} {

        parse_args {{comment ""} {seg_sel ""}}

        # ...
    }

    arange $start $end -comment "a comment"

See the definition in testsuite/lib/gdb.exp for usage examples.

Keith