From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id A7FC33858D38 for ; Fri, 12 Apr 2024 16:02:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A7FC33858D38 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A7FC33858D38 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712937727; cv=none; b=StJnbU1keSLp+TdK5en8AA0Lv+xv17Q/IV1QtGFJ77g1YsmGIBLZSGE+7V0/R87uTGSXX33CukjnlVburNOY+QCAannvYIXOo8mxlT9GqLDuRH7XY+gSwe7YJoBIAJLw66rRMsN81CXUCJ8Ua9mBALRvRwltrVVL2dV5AFb9kS0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712937727; c=relaxed/simple; bh=pLc5/KzyDH9HSeY/UJLiX4TNjanwJO0oCYTMPs6RL4o=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=QVYxAFsAamsFCadhG/wDA8ontQzMV2vzEq5KZw+M+J7/xGz3Hnoolayort1/EpGRIe+97nlOIrfA4taZMmyHv/ZWQJFdaVNACgcyuEuRa8k4v8F0E+dP9OeaubuyUC90D25KbHhrffukorvZcZygsLzN1cZXUDGujrjw3saNK4s= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1712937725; bh=pLc5/KzyDH9HSeY/UJLiX4TNjanwJO0oCYTMPs6RL4o=; h=Date:Subject:To:References:From:In-Reply-To:From; b=NpGSEPEYp7RK+FUccKMF54l1DpapQrNpF6eKqMsg19aUZLhEJg2wHE00nanABTmB8 199nGBn3NJBFkh1BZg+mHUpZdlqKvRYLe55ifPofJZVhcxilJ8TdgieTK91OXNYDrS 5mwllsNNDNxCDm7Alo+c7Y9atIZOtuI7uscDGJXE= Received: from [172.16.0.192] (192-222-143-198.qc.cable.ebox.net [192.222.143.198]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id DDB6B1E030; Fri, 12 Apr 2024 12:02:04 -0400 (EDT) Message-ID: <6e68aa21-bbcf-4dc7-8688-da1c6ab311b8@simark.ca> Date: Fri, 12 Apr 2024 12:02:04 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Avoid complaint warning on mingw To: Tom Tromey , gdb-patches@sourceware.org References: <20240409154617.1935108-1-tromey@adacore.com> From: Simon Marchi Content-Language: fr In-Reply-To: <20240409154617.1935108-1-tromey@adacore.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/9/24 11:46 AM, Tom Tromey wrote: > @@ -418,7 +429,7 @@ extern warning_hook_handler get_warning_hook_handler (); > instance of this class with the 'warn' function, and all warnings can be > emitted with a single call to 'emit'. */ > > -struct deferred_warnings > +struct deferred_warnings final : public warning_hook_handler_type > { > deferred_warnings () > : m_can_style (gdb_stderr->can_emit_style_escape ()) > @@ -444,18 +455,11 @@ struct deferred_warnings > hook; see scoped_restore_warning_hook. Note that no locking is > done, so users have to be careful to only install this into a > single thread at a time. */ > - void operator() (const char *format, va_list args) > + void warn (const char *format, va_list args) override > + ATTRIBUTE_PRINTF (2, 0) The `warn (const char *format, ...)` method should probably defer to the `warn (const char *format, va_list args)` method, they appear to do the exact same thing. Otherwise, LGTM: Approved-By: Simon Marchi Simon