From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id E9DCE3858D35 for ; Tue, 22 Nov 2022 20:39:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E9DCE3858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca Received: from [172.16.0.64] (192-222-180-24.qc.cable.ebox.net [192.222.180.24]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 857DD1E0CB; Tue, 22 Nov 2022 15:39:06 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1669149546; bh=yEy2s00Xp72dGE6pFGOPbewUWS2JkRmb5ihhMfIaPN8=; h=Date:Subject:To:References:From:In-Reply-To:From; b=cVQ95xDDGkF2fL3HVkNOd6BcPq4kfP9MZbXKj0HazWAYVzbHtarILgHJehQ882wjR e9V+laSYt22MWsd/4Lsh5l7l+taN8rhRS13VpqF7IkXxSWKKxBrTiNiXfeUmLgO5OT hbfaW501ullqHIUILAOm4fdXZNH4Uiwv2abQiK80= Message-ID: <6e6af4ae-83a7-d444-7a79-0934091b77f7@simark.ca> Date: Tue, 22 Nov 2022 15:39:06 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH 4/5] arm-fbsd: Use a static regset for the TLS register set. Content-Language: fr To: John Baldwin , gdb-patches@sourceware.org References: <20220708005816.9408-1-jhb@FreeBSD.org> <20220708005816.9408-5-jhb@FreeBSD.org> From: Simon Marchi In-Reply-To: <20220708005816.9408-5-jhb@FreeBSD.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-11.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > diff --git a/gdb/arm-fbsd-tdep.c b/gdb/arm-fbsd-tdep.c > index 483820c1092..2a73643b763 100644 > --- a/gdb/arm-fbsd-tdep.c > +++ b/gdb/arm-fbsd-tdep.c > @@ -52,6 +52,12 @@ static const struct regcache_map_entry arm_fbsd_vfpregmap[] = > { 0 } > }; > > +static const struct regcache_map_entry arm_fbsd_tls_regmap[] = > + { > + { 1, 0, 4 }, > + { 0 } > + }; I would suggest adding a comment to say that this regno is relative, and relative to what. > + > /* In a signal frame, sp points to a 'struct sigframe' which is > defined as: > > @@ -151,6 +157,34 @@ const struct regset arm_fbsd_vfpregset = > regcache_supply_regset, regcache_collect_regset > }; > > +static void > +arm_fbsd_supply_tls_regset (const struct regset *regset, > + struct regcache *regcache, > + int regnum, const void *buf, size_t size) > +{ > + struct gdbarch *gdbarch = regcache->arch (); > + arm_gdbarch_tdep *tdep = (arm_gdbarch_tdep *) gdbarch_tdep (gdbarch); These can now be changed to: arm_gdbarch_tdep *tdep = gdbarch_tdep (gdbarch); With those fixed, Approved-By: Simon Marchi Simon