From: Phil Muldoon <pmuldoon@redhat.com>
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [RFA] Make "bt N" print correct number of frames when using a frame filter
Date: Wed, 31 May 2017 15:19:00 -0000 [thread overview]
Message-ID: <6e79fd89-6152-4504-3505-f754d0595deb@redhat.com> (raw)
In-Reply-To: <20170423160446.17062-1-tom@tromey.com>
On 23/04/17 17:04, Tom Tromey wrote:
> PR python/16497 notes that using "bt" with a positive argument prints
> the wrong number of frames when a frame filter is in use. Also, in this
> case, the non-frame-filter path will print a message about "More stack
> frames" when there are more; but this is not done in the frame-filter
> case.
>
> The first problem is that backtrace_command_1 passes the wrong value
> to apply_ext_lang_frame_filter -- that function takes the final
> frame's number as an argument, but backtrace_command_1 passes the
> count, which is off by one.
>
> The solution to the second problem is to have the C stack-printing
> code stop at the correct number of frames and then print the message.
Good catch. Patch LGTM.
Cheers
Phil
next prev parent reply other threads:[~2017-05-31 15:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-23 16:04 Tom Tromey
2017-04-25 18:27 ` Sergio Durigan Junior
2017-04-26 0:17 ` Tom Tromey
2017-05-29 17:21 ` Tom Tromey
2017-09-30 20:38 ` Tom Tromey
2018-02-12 16:45 ` Tom Tromey
2018-02-24 17:09 ` Tom Tromey
2018-02-25 18:29 ` Simon Marchi
2018-02-26 16:35 ` Tom Tromey
2017-05-31 15:19 ` Phil Muldoon [this message]
2017-06-27 18:37 ` Pedro Alves
2017-07-14 18:56 ` Tom Tromey
2017-08-14 14:19 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e79fd89-6152-4504-3505-f754d0595deb@redhat.com \
--to=pmuldoon@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).