From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 100493 invoked by alias); 26 Nov 2018 17:22:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 100483 invoked by uid 89); 26 Nov 2018 17:22:50 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=instruct, felt, email!, H*F:D*ca X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 26 Nov 2018 17:22:49 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id wAQHMhuE023157 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 26 Nov 2018 12:22:47 -0500 Received: by simark.ca (Postfix, from userid 112) id 0821D1E992; Mon, 26 Nov 2018 12:22:43 -0500 (EST) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id CB1C41E473; Mon, 26 Nov 2018 12:22:40 -0500 (EST) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 26 Nov 2018 17:22:00 -0000 From: Simon Marchi To: Sergio Durigan Junior Cc: Simon Marchi , GDB Patches , Alan Hayward , nd Subject: Re: [PATCH v2] Implement timestamp'ed output on "make check" In-Reply-To: <87mupv3ir3.fsf@redhat.com> References: <20181122221240.15354-1-sergiodj@redhat.com> <20181123150256.22584-1-sergiodj@redhat.com> <61b6c448-bae1-2dd9-87a7-5c500be0aa09@ericsson.com> <87wop13z2z.fsf@redhat.com> <147c28c03427ad7e1e6a9dfd976b027a@polymtl.ca> <877eh04u8g.fsf@redhat.com> <5417842c2c8843e89f4390cd052c93a5@polymtl.ca> <87mupv3ir3.fsf@redhat.com> Message-ID: <6e9a79a554304065c666c184536f1e1b@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-IsSubscribed: yes X-SW-Source: 2018-11/txt/msg00442.txt.bz2 On 2018-11-26 11:29, Sergio Durigan Junior wrote: >>> And FWIW, I don't really like this part of PEP8 which >>> states that there should be no spaces before parentheses. >> >> If you hate it that much, feel free to propose a change to our >> standards :) > > Sorry if it appeared that I was complaining about your email! Not my > intention at all, and I do appreciate your reviews. No harm felt on this side, my response could be interpreted a bit harshly too, sorry about that. > As for proposing a change to the standards... that's a good idea! > I've > played a little bit with "autopep8" here, and it seems to be a nice > little tool which offers the possibility of ignoring parts of the PEP8 > spec when fixing the file. For example, for the specific case of > "whitespace before '('", if you do: > > autopep8 --ignore E211 -i FILE > > It will not fix the "issue", and will preserve the whitespaces there. > Neat. I think autopep8's goal is to enforce pep8 (hence the name), so you might not be able to have it format the code in different ways (just ignore the warnings, as you pointed out). But there might be other Python formatting tools that are more configurable. If there's one that works well, which we can instruct to add spaces before parentheses (to match how we format C/C++ code), then I think it would be reasonable to do that. But otherwise, it just feels we are just swimming against the current, since pep8 is recommended by the language implementation itself, and most tools revolve around that. > Anyway, I just wanted to document that I found a way to disable this > specific extension. As much as I'd like us to change this specific > thing, I'll focus on other priorities right now. :) Simon