From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60052.outbound.protection.outlook.com [40.107.6.52]) by sourceware.org (Postfix) with ESMTPS id 612593858403 for ; Mon, 25 Jul 2022 07:40:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 612593858403 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=iaTPQyKgiQy9O3OIq7BVGz2jMebOcrCvWGSUdjMJtFKS5f3yIuTMbRzFsJdvP+N+74HXT36YjawzYRUMJqVlNesGjR/lxeJ0yutLM2WiYfOsi7sKjgW3eknJ3kNKd6iiYX7cJNROB7jQsrZ4ujqw7yd+OTT0Zf7LPiPvtqZz2Edcr9uwPFrBU7X8yOZLbYndbzqKqdm6ES12/T3n7FUaWT+PmGKEitm92DP7gAbuIObzreZsUWQPKOwwGCMdBnVB/C+mFCNO6J/kC8U6hyIUmQbPVx+igk/7XdmYaODDvZOhYvxmLTzGT87wGVTM+EtHIfKz2XPT818gKkgoWvMjXw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Y4ZbmF+cfH3pIDR1Fq4fllT/hrnOj3qntvTgFjZQgFs=; b=NayGIoXbOxz3UNGkPkFPsFRziBpCdc4Os7NC/o+OtpR0OGuk62F+EIY8vMWFS8K5cc/UcPuKdc8D1Hgwnwm/9LcjDvdHPKywq8TIJXHWSBLuxuunZTEqwakl75Qi9Ujo/es3JbSHZWkTmXEx7vsk2LymShJl7ZP1z+fSCduHmVzzUd4e7ptI5SiOECqpwZVUw77CdvtnvIfnuUtCLNWahlOqwmyMZGl5aqovB4VxIekYnjaQP9hlZjAjqKnusIdKdBW95UY69NdYG0J4TL7VH4+Lq/MkT1FFZTVeix3DdupkoGgovR1S4u8QdTiqtsXP+3wSPWxRpgqApvtFX2Pfaw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) Received: from DB9PR02CA0005.eurprd02.prod.outlook.com (2603:10a6:10:1d9::10) by AM6PR08MB5110.eurprd08.prod.outlook.com (2603:10a6:20b:d5::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.15; Mon, 25 Jul 2022 07:40:01 +0000 Received: from DBAEUR03FT024.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:1d9:cafe::b4) by DB9PR02CA0005.outlook.office365.com (2603:10a6:10:1d9::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.24 via Frontend Transport; Mon, 25 Jul 2022 07:40:01 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT024.mail.protection.outlook.com (100.127.142.163) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.17 via Frontend Transport; Mon, 25 Jul 2022 07:40:01 +0000 Received: ("Tessian outbound 63c09d5d38ac:v123"); Mon, 25 Jul 2022 07:40:01 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 5642680133fdbcb6 X-CR-MTA-TID: 64aa7808 Received: from 666e2d9cfe3f.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 14F84EEF-A903-4A5D-9BA9-72576BCCF66D.1; Mon, 25 Jul 2022 07:39:54 +0000 Received: from EUR03-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 666e2d9cfe3f.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 25 Jul 2022 07:39:54 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jD1wiukfb8ZKya8PNwzFE16/1ncgYy2T812ev1n4bGjkVkQbZ/JUsZsjJu40UVZDPQlaNMvlYPkFJTXYfXZqYDaT90M5HVa1iHZsAc3LQYQEGlITguMv6156pgHWIKErNxAe9HsHlCrYsQFCCgPP3tBMNd9aYNe0N0CwJhm3eT83Xf1kvqCebUKVlff5tt01RYlsop70rWyTjswWWvYQBJn5BB3AvdkmWMgbpZVu550s/wFLZvJlOtfBiJahVRZXjFCVML6o/bjBPpgMPRZLRDi1hAS/gYZ7ZkL5WYmlx9KvVkIhSLr/VGD9OxgHX2I7H7238K4E8H2Cur7Z62EcbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Y4ZbmF+cfH3pIDR1Fq4fllT/hrnOj3qntvTgFjZQgFs=; b=VVnkljO70MMK/Jk1HU6TObjzOe2HdjdNeWJnTMVQsGOOsbERbpHKC/92Mqn8W1IL3tNp4YNC2v9EcVMi1EV3UgDFNFNMQjT5bM4zJJQxFbFvGsI02wuGiWeql2wGkFRN1PLndoevxhYuyYWTJlgfollr01f54rR0JCmmzQs9WrCCBlGzlz4zS1e/fLrypMzyos9vhhiqO8JHh9BZ2iHQlYWJONaS31qWto5VwwFQsbHWvuJYpUph8tOUkCWnrKhpB6WsD00+1dG+oXajRkW9j+ziIa1G7K3N9JgzmIJbbgCCFg9R4rRsTNPne3a2Ge0lP+JExz/pV+SzP+/t4hSbKA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by DB6PR0801MB1816.eurprd08.prod.outlook.com (2603:10a6:4:3c::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.18; Mon, 25 Jul 2022 07:39:52 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::e866:af0e:2168:5ca7]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::e866:af0e:2168:5ca7%5]) with mapi id 15.20.5458.019; Mon, 25 Jul 2022 07:39:52 +0000 Message-ID: <6ec77420-8123-676c-ebba-20d55a5222fd@arm.com> Date: Mon, 25 Jul 2022 08:39:51 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2] gdb/hurd: pass memory_tagged as false to find_memory_region_ftype Content-Language: en-US To: Enze Li , gdb-patches@sourceware.org Cc: enze.li@gmx.com, jhb@FreeBSD.org References: From: Luis Machado In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0061.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:153::12) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 379222d3-1c09-46d0-93b8-08da6e10e1c2 X-MS-TrafficTypeDiagnostic: DB6PR0801MB1816:EE_|DBAEUR03FT024:EE_|AM6PR08MB5110:EE_ x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: /gvF8eznw4+2iVPCltOy1hMqUaeAzLl0D1YfoJ60Gr1SfvI90Wpjg1ybQzqvSzgK39xZpbYLe6rSbC085w5/hMSiZUWi0+vqIV8/Xl+QxQSKb48hDAP+JKdO+TuQ79uv+VbXf4Qar2XEYJQqoPGfaSnZk20lhVxE8jGfr6G5B3ceRjL+4YGUoahI+e1UxOvcZdG0TQ95f6qVqAS5rnuTWYsf9LsO1T/qrYFmnI/AX/11Fn5O6F1MJ82HkzU5OrFGCnmSERqs2gJZNink4VTkwROZ6Ig3Oi0WXdsXjh+bFnS/Urz0C0ezO31HPwPFeSaryP3WroJg5o3mlexHCLgycuUp+5uIoHVtVaepj3iDjP+Y1HmBHJGbH6R7jv2h8vALQtiYehct8ZzPpXDs9pytjT36CbvO2NaFXq5PEz09b/XIFMtmwXiITE7nkIlTdFXczEK4zAOufz/T6szXNtOMUUpyOPav4bGB3SJp3S/x6O/m2ZTPLBI6cntURuAQrDrSSBTwp+/iUSDLcbvZ3For55v698HhcPeVvjObE0oq3UsfQOohCrkNrWL8NtXfaauQ7y73WTmBWvfpZnO2ZpzOiJBXONwsPB8SFtHMJYC9EfgoLqpGVHV7CTPP5jMODbvXQOUHEZhAb0p5gKq9OV0nNcI+zU2ySkdrjF+ckk4QkddmNBL3+dRWTMWRowsrJR+RjB2/igrptAr2E0F89i/OXZm/Gsmm5hztm3mbwBT298Wu775gkJJgF7B3dYWYboqd4CS49tZSpUxx/O91LW2ooplW2A4nkAbaTdCwB5t6GuuLX2yhqrqXw/rO1LnvIEqWCen6Z6g4t8FRTYVPcGFQbtWIgIjgxWNQ26ptwZS1R/4= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR08MB3919.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(366004)(346002)(136003)(39860400002)(396003)(376002)(186003)(2616005)(83380400001)(8676002)(66946007)(66556008)(4326008)(66476007)(6506007)(6512007)(31686004)(53546011)(36756003)(41300700001)(26005)(2906002)(86362001)(31696002)(38100700002)(5660300002)(44832011)(316002)(8936002)(6486002)(478600001)(37363002)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0801MB1816 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT024.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 1354d6a9-cfe7-4cbe-f39d-08da6e10dc3e X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MtT+BLX3E69K4ZMAAQcWh3QpabynKQnZDo6q9I9pFMxTN3zbfYw/i8s12Xw9/u7C63r0Q3Y+hkqDN9eJdY9Xw1aiq9iQ7wXRlMH8wecum2ypjTc89KXVP6lEUGCD/LvU9+cxhjOQnccAPZF9tZd7+NQCMturEU6+abZ29A70ek4wiKjagM+sxITIFShQ2HaL844AazcC8AaeXRW7kv42ZBWLdVznsbDCIdYlJfqUe2sZqICee7Wvf6bXyGsMBi+uQkmfFTygQ3Uqys9ph2WCWpPL+HeSJdjwHLeNTk+EktvVyQ4axDAGzIKV2q9OsoEW3PvVj3aWIxJ5evUWLqsxU0zEzBAy/UBwgUVeAq8VYUVZQzfVx6VtMHvRA4x2j0RX22sGWhrFZng7TkTr4vb7Dz/Y+zBLwWOd091JOANyrsZWPOREclA9FwBC0z6Vmkdwj3p0UYaaRcw5GM55SZnd3nZcyX/dPUbf0XaOqxibasItTPk2JzLzvZX+nO389l8rLL6FzlUOv073KqI/t5wRdTuNECjCwrbYW4YMZmvDmAGPCz/v4nCtzFSPnxaAVCsI4lTtpjuCGNnTBwAOUpXLiXz0WToXNZXAF125UoQ81EmMZyfgL8M2r/78dBn2HQLkmW9BtpSO71ourq2dfkKV29tUeLQRlNKRnjMeDWopvYFrR72QvjtN3Z7Nss69f6netra29r+heD/7gDvUupoIfWBQY7YYe0ryWzQfzMAq3lJzI06fiubogYIou3ChUZ90z52gez/e0o8oayg4dUXvgquyPd9Ryu53njTg9mP70XVYEUiXtNCff4vyq+xh15MwRQ9RgHGbtwUU3rnoGDZoPfQgMCOS5cFJFE7N+EZzWz8= X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230016)(4636009)(346002)(136003)(396003)(376002)(39860400002)(40470700004)(46966006)(36840700001)(107886003)(53546011)(86362001)(478600001)(186003)(336012)(44832011)(31696002)(40460700003)(316002)(6506007)(2616005)(26005)(41300700001)(6486002)(40480700001)(82310400005)(5660300002)(83380400001)(36860700001)(2906002)(8936002)(70206006)(4326008)(31686004)(81166007)(6512007)(356005)(36756003)(47076005)(82740400003)(70586007)(8676002)(37363002)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jul 2022 07:40:01.2503 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 379222d3-1c09-46d0-93b8-08da6e10e1c2 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT024.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB5110 X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FORGED_SPF_HELO, GIT_PATCH_0, KAM_ASCII_DIVIDERS, KAM_DMARC_NONE, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Jul 2022 07:40:08 -0000 Hi! On 7/24/22 04:40, Enze Li wrote: > I tried building GDB on GNU/Hurd, and ran into this error: > > CXX gnu-nat.o > gnu-nat.c: In member function ‘virtual int gnu_nat_target::find_memory_regions(find_memory_region_ftype, void*)’: > gnu-nat.c:2620:21: error: too few arguments to function > 2620 | (*func) (last_region_address, > | ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~ > 2621 | last_region_end - last_region_address, > | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > 2622 | last_protection & VM_PROT_READ, > | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > 2623 | last_protection & VM_PROT_WRITE, > | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > 2624 | last_protection & VM_PROT_EXECUTE, > | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > 2625 | 1, /* MODIFIED is unknown, pass it as true. */ > | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > 2626 | data); > | ~~~~~ > gnu-nat.c:2635:13: error: too few arguments to function > 2635 | (*func) (last_region_address, last_region_end - last_region_address, > | ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > 2636 | last_protection & VM_PROT_READ, > | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > 2637 | last_protection & VM_PROT_WRITE, > | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > 2638 | last_protection & VM_PROT_EXECUTE, > | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > 2639 | 1, /* MODIFIED is unknown, pass it as true. */ > | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > 2640 | data); > | ~~~~~ > make[2]: *** [Makefile:1926: gnu-nat.o] Error 1 > > This is because in this commit: > > commit 68cffbbd4406b4efe1aa6e18460b1d7ca02549f1 > Date: Thu Mar 31 11:42:35 2022 +0100 > > [AArch64] MTE corefile support > > Added a new argument to find_memory_region_ftype, but did not pass it to > the function in gnu-nat.c. Fix this by passing memory_tagged as false. > > As Luis pointed out, similar bugs may also appear on FreeBSD and NetBSD, > and I have reproduced them on both systems. This patch fixes them > incidentally. > > Tested by rebuilding on GNU/Hurd, FreeBSD/amd64 and NetBSD/amd64. > --- > gdb/fbsd-nat.c | 2 +- > gdb/gnu-nat.c | 2 ++ > gdb/netbsd-nat.c | 2 +- > 3 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/gdb/fbsd-nat.c b/gdb/fbsd-nat.c > index 398f1c18b33..a4ca4a53415 100644 > --- a/gdb/fbsd-nat.c > +++ b/gdb/fbsd-nat.c > @@ -125,7 +125,7 @@ fbsd_nat_target::find_memory_regions (find_memory_region_ftype func, > Pass MODIFIED as true, we do not know the real modification state. */ > func (kve->kve_start, size, kve->kve_protection & KVME_PROT_READ, > kve->kve_protection & KVME_PROT_WRITE, > - kve->kve_protection & KVME_PROT_EXEC, 1, data); > + kve->kve_protection & KVME_PROT_EXEC, 1, false, data); > } > return 0; > } > diff --git a/gdb/gnu-nat.c b/gdb/gnu-nat.c > index 72314824278..5dd4d148c76 100644 > --- a/gdb/gnu-nat.c > +++ b/gdb/gnu-nat.c > @@ -2623,6 +2623,7 @@ gnu_nat_target::find_memory_regions (find_memory_region_ftype func, > last_protection & VM_PROT_WRITE, > last_protection & VM_PROT_EXECUTE, > 1, /* MODIFIED is unknown, pass it as true. */ > + false, /* No memory tags in the object file. */ > data); > last_region_address = region_address; > last_region_end = region_address += region_length; > @@ -2637,6 +2638,7 @@ gnu_nat_target::find_memory_regions (find_memory_region_ftype func, > last_protection & VM_PROT_WRITE, > last_protection & VM_PROT_EXECUTE, > 1, /* MODIFIED is unknown, pass it as true. */ > + false, /* No memory tags in the object file. */ > data); > > return 0; > diff --git a/gdb/netbsd-nat.c b/gdb/netbsd-nat.c > index c45df391afc..d3bf83d35f5 100644 > --- a/gdb/netbsd-nat.c > +++ b/gdb/netbsd-nat.c > @@ -259,7 +259,7 @@ nbsd_nat_target::find_memory_regions (find_memory_region_ftype func, > Pass MODIFIED as true, we do not know the real modification state. */ > func (kve->kve_start, size, kve->kve_protection & KVME_PROT_READ, > kve->kve_protection & KVME_PROT_WRITE, > - kve->kve_protection & KVME_PROT_EXEC, 1, data); > + kve->kve_protection & KVME_PROT_EXEC, 1, false, data); > } > return 0; > } The above LGTM. Thanks again for getting these files fixed. I think this one can go in as it is fairly obvious and addresses broken builds for hurd, fbsd and netbsd