From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) by sourceware.org (Postfix) with ESMTPS id 5402A3898C6F for ; Thu, 21 Apr 2022 18:20:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5402A3898C6F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f54.google.com with SMTP id e2so1552034wrh.7 for ; Thu, 21 Apr 2022 11:20:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=b9geSqNZ00JzQXaMPfKGDoqDsBR0FGH3dmN3kbsvLNk=; b=B8+AsRnce1EQtZVFwS3Nwu8SEE6Xp5WiItrbVRxJHNnHVuLPujVjrAAbBEnO0pUzKT aCRh5p6N6hYHUJLrGtGbp3iw9+8t1htQX91RvioKtIl1Vdh0QAMUfjnbYwAi+vhN/Dy9 eofTQonfG/eRV4vphmfWU//a5KK6cpbwVPtsDxX2taEEK8JZvOsqQHL0Y21ceCzSJm/L ukBOS1ib6QD/urNHHqilMut0MJ5kslwfc6/vcIsZTA+EMDcD9rKprEUwfInmyh/P+DRy 7WXbjo4w0RLUuafhPpqhmpak9doBkiM2HL4qem9P+5n6ytWtsMECLhyGB7qcUL43Cbbi ay3g== X-Gm-Message-State: AOAM531PngM0xoKWNv7yom/1+fc55J6N0zwyVdfCFyYS4YxQ9HvtAlyv xtuO0kw5bvvjorB2QLmb9Ag= X-Google-Smtp-Source: ABdhPJy5JLh8NZTXZWOGS3w2+f98W4Tic2odprDRqZj6waKaspx/qGN4Qu5qkk9JT8frQ3BnFtq34w== X-Received: by 2002:a5d:47ab:0:b0:20a:7f8a:ec69 with SMTP id 11-20020a5d47ab000000b0020a7f8aec69mr736184wrb.504.1650565208130; Thu, 21 Apr 2022 11:20:08 -0700 (PDT) Received: from ?IPV6:2001:8a0:f924:2600:209d:85e2:409e:8726? ([2001:8a0:f924:2600:209d:85e2:409e:8726]) by smtp.gmail.com with ESMTPSA id f1-20020a1c6a01000000b0038c9f6a3634sm2571800wmc.7.2022.04.21.11.20.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Apr 2022 11:20:06 -0700 (PDT) Message-ID: <6efb39b3-2499-2628-2cc2-67dc1d0a7b3b@palves.net> Date: Thu, 21 Apr 2022 19:20:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: "show remote foo-packet" regression (Re: [PATCH v2 1/3] gdb: Make global feature array a per-remote target array) Content-Language: en-US To: Andrew Burgess , Christina Schimpe , gdb-patches@sourceware.org References: <20220329131158.3970228-1-christina.schimpe@intel.com> <20220329131158.3970228-2-christina.schimpe@intel.com> <08fd8bbf-c44e-7313-d7b3-7b0770c2c7d4@palves.net> <7c319441-067e-6f5c-cf80-84d696c9236e@palves.net> <87mtgerawv.fsf@redhat.com> <6fb9a140-0163-ce56-ac78-f5bf3f1b7795@palves.net> <87ilr2r98p.fsf@redhat.com> <87fsm6qu3j.fsf@redhat.com> From: Pedro Alves In-Reply-To: <87fsm6qu3j.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Apr 2022 18:20:10 -0000 On 2022-04-21 17:28, Andrew Burgess wrote: > Andrew Burgess writes: > >> Pedro Alves writes: >> >>> On 2022-04-21 11:25, Andrew Burgess wrote: >>>> Pedro Alves writes: >>>>> >>>>> This commit is present in the GDB 12 branch and not in GDB 11, so it's a regression there. >>>> >>>> Sorry for the regression. I took a look at the code and I honestly have >>>> no idea why I thought the code in the above commit would work :-/ >>>> >>> >>> No worries, happens all the time to me. :-) >>> >>>> Below is a patch that should fix this issue. I probably should write a >>>> test to go along with it, but thought I'd share this for feedback first. >>>> >>>> Let me know what you think, >>> >>> LGTM. Thanks for fixing it. >> >> Thanks, I'll just let a test run complete, and push this later today. > > I pushed the following patch to master and gdb-12-branch. Perfect, thanks for adding the testcase.