From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2610:1c1:1:606c::19:2]) by sourceware.org (Postfix) with ESMTPS id 395C83858C52 for ; Thu, 28 Sep 2023 21:05:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 395C83858C52 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=FreeBSD.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [96.47.72.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mx1.freebsd.org", Issuer "R3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 4RxQwk1VCgz4Tky; Thu, 28 Sep 2023 21:05:10 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RxQwk0Thkz3DfM; Thu, 28 Sep 2023 21:05:10 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1695935110; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fhICQ6UgZkR4ipxm5pV7bLBZTfzifGlvdoCJ1uil+4E=; b=A5LSDzJnpoKMcRqwVbxnBgeywXhBztkiFCpGgER1guLXJcjSQ42dnN15A9dFoGQLKcx0dF IMUJ+dHKPZe/9NsnB1SRlF6yHl/FWI/VpOlPr3oiC2FG5RMjg986OKBT/rY9tMSyfSriVm 23EH31dHBb+YOEEg3yDBeKoEzQw7JYr16c4yjtBzUe9EagnmEXZIV8G7amK7zJaY/tvHfp US6HhISyIiisypAXpkAMjNH1d72xwmiXhi4SzNaW0l8vFnPGMkZ2YZ9Y8Fe9LwBiz8+plv 56lqWGWassUfVEvfZZFk3bwaQf9LXA0acy6xVo3GrDohDYW6n0dGDgIDkKbldQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1695935110; a=rsa-sha256; cv=none; b=XS0mWv5lNXcNEueggD8TGZx6VHRX3Fg4jHCPeTPg3E6HFEHO5fPaftVXUI+/1SVDG4ql7P lOdC+T91kCtD4/hV5mGOkIwM9yD7vjVrujm4JXB/5l/xqJMPUaeNrJVGMN4Usz3J0RWeRn ZNldoiditdrFnvNtwk/cXRFdI/kFr6DAtYEEvZ3CGO1pBILS8t7SGBpBRyA9fjwTEOdTc4 dP4bK57zwbwZUWBKWgYmvYH0CrSY8Nlic/9net/9UcjlIhf78NM6day0J4bk5zLy3fzXa6 lpG+9rP0kJK/L7phiSOX6qUXhlLyiVMl8jDOVhxiOMAYphqcpOVO2P/gwu2caQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1695935110; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fhICQ6UgZkR4ipxm5pV7bLBZTfzifGlvdoCJ1uil+4E=; b=NRneXFYJ0RjJhKWFdbz3BOdq8QirlBWEYJB9vWwicTG4MZbbJpvYDrBvF6gSkB5klvE+46 xmeH6AyDIlnssXepxB+yz+vZlgdjoWoONWuxOw5n4cUOf4aqUALY1LDfVaUVYj0covsi9Q CLux0kCV4ZDzC47DbfD53JNLgCedlVvPaGpTLVqAHSep+9NvKQhggLFSapEecHENfYb57u KoROOp64aC1XBpa8FN6fLhOOxnVxNIcfNSyYRW8cjujZcmy1wkQM35AJRaD/rsjx5Q0cyO 9419mqRPSbLRD3CUvubWnQrmOy8nGHIFG74b0Kw0TRtbWAz+WXejSgW7+tLIHQ== Received: from [IPV6:2601:648:8683:39a0:e1b3:8f1c:ed70:9872] (unknown [IPv6:2601:648:8683:39a0:e1b3:8f1c:ed70:9872]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4RxQwj3XcLzmt9; Thu, 28 Sep 2023 21:05:09 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <6f1d07b2-f309-a7ef-7339-f0fdc38f9764@FreeBSD.org> Date: Thu, 28 Sep 2023 14:05:08 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH 2/2] gdb: remove nbsd_{ilp32, lp64}_solib_svr4_fetch_link_map_offsets Content-Language: en-US To: Simon Marchi , gdb-patches@sourceware.org References: <20230928174752.389177-1-simon.marchi@efficios.com> <20230928174752.389177-2-simon.marchi@efficios.com> From: John Baldwin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 9/28/23 7:24 PM, Simon Marchi wrote: > On 9/28/23 14:07, John Baldwin wrote: >> On 9/28/23 6:47 PM, Simon Marchi via Gdb-patches wrote: >>> They are unused. >>> >>> Change-Id: I9b78837d41126ce1957aa1e8b08c82a422f06cbf >>> --- >>> gdb/netbsd-tdep.c | 15 --------------- >>> gdb/netbsd-tdep.h | 3 --- >>> 2 files changed, 18 deletions(-) >>> >>> diff --git a/gdb/netbsd-tdep.c b/gdb/netbsd-tdep.c >>> index ed60200f958b..15a9e2fd7d4e 100644 >>> --- a/gdb/netbsd-tdep.c >>> +++ b/gdb/netbsd-tdep.c >>> @@ -44,21 +44,6 @@ >>> #define KINFO_VME_FLAG_GROWS_UP 0x00000010 >>> #define KINFO_VME_FLAG_GROWS_DOWN 0x00000020 >>> -/* FIXME: kettenis/20060115: We should really eliminate the next two >>> - functions completely. */ >>> - >>> -struct link_map_offsets * >>> -nbsd_ilp32_solib_svr4_fetch_link_map_offsets (void) >>> -{ >>> - return svr4_ilp32_fetch_link_map_offsets (); >>> -} >>> - >>> -struct link_map_offsets * >>> -nbsd_lp64_solib_svr4_fetch_link_map_offsets (void) >>> -{ >>> - return svr4_lp64_fetch_link_map_offsets (); >>> -} >>> - >>> int >>> nbsd_pc_in_sigtramp (CORE_ADDR pc, const char *func_name) >>> { >>> diff --git a/gdb/netbsd-tdep.h b/gdb/netbsd-tdep.h >>> index ab13e628d582..2adf9a751e3b 100644 >>> --- a/gdb/netbsd-tdep.h >>> +++ b/gdb/netbsd-tdep.h >>> @@ -20,9 +20,6 @@ >>> #ifndef NBSD_TDEP_H >>> #define NBSD_TDEP_H >>> -struct link_map_offsets *nbsd_ilp32_solib_svr4_fetch_link_map_offsets (void); >>> -struct link_map_offsets *nbsd_lp64_solib_svr4_fetch_link_map_offsets (void); >>> - >>> int nbsd_pc_in_sigtramp (CORE_ADDR, const char *); >>> /* NetBSD specific set of ABI-related routines. */ >> >> Both patches seem sensible to me, and the NetBSD one in particular looks right. > > Thanks, I will push them (they could have maybe been considered > obvious). Can I add your Reviewed-By? Sure. -- John Baldwin