From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 84ECF386F474 for ; Thu, 21 Dec 2023 21:26:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 84ECF386F474 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 84ECF386F474 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703194017; cv=none; b=LltOJASgLkLNOsG/l6RBI2WiHGrr2CBe0MGEuGGfB2l8kzQyhmKKz+ECy38azxVUJi5rdH2RV2HRT0y6jt9uz9cPOx6CBty7SqRmiJtYVXCZyo8dW6uJou8zqhF6RVloGZjD9ndTxBpLjBKfE2zAVBWfTiuXNfO/9sfOFoL24To= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703194017; c=relaxed/simple; bh=9Tu1AYRh+X2BDnR86xlkYVZQWIhF1p0jye7qkrWSBYM=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=b+X4h5Y0veQ+eQIGQ3WThsNNHCefF4oV3KGt3Yp+1gvDxId4ro1Sw0vtu46ys+M0EpiILSMjisTv4RSGO8tewCz4Brign5MuwAgywVgnM4cktqbN3Om4xh8Ku60pPgz3w3QYd6+lm3WbrVbKLFtxAAyq9t/7DoKPi2zThWsizCU= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1703194016; bh=9Tu1AYRh+X2BDnR86xlkYVZQWIhF1p0jye7qkrWSBYM=; h=Date:Subject:To:References:From:In-Reply-To:From; b=BCtVuMBxHIEVatqhGV+lr164ttn23SCvChd7yPwg5RYxq9loknhUzcQSQwg30vHNK qXGEy7MlHoAKR+FXY/zqjI6RInOJ59Y017DdbaxyjoCUopXkVCEDHOfb7LBxqKcuf8 lfZYxqvB/DcTx9WgVpFE0wFDc8kRJgbqvzJoqynQ= Received: from [172.16.0.192] (192-222-143-198.qc.cable.ebox.net [192.222.143.198]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 13F261E0AC; Thu, 21 Dec 2023 16:26:55 -0500 (EST) Message-ID: <6f2895c4-a55b-49ee-bb69-b2c3552ccbf2@simark.ca> Date: Thu, 21 Dec 2023 16:26:55 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 13/26] gdbserver: convert register_data into regcache::register_data Content-Language: fr To: Tankut Baris Aktemur , gdb-patches@sourceware.org References: From: Simon Marchi In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/28/23 06:28, Tankut Baris Aktemur via Gdb-patches wrote: > Convert the register_data function to a method of the regcache struct. > --- > gdbserver/regcache.cc | 20 ++++++++++---------- > gdbserver/regcache.h | 3 +++ > 2 files changed, 13 insertions(+), 10 deletions(-) > > diff --git a/gdbserver/regcache.cc b/gdbserver/regcache.cc > index 31f1e7bb3dc..79835ef4ff1 100644 > --- a/gdbserver/regcache.cc > +++ b/gdbserver/regcache.cc > @@ -314,11 +314,11 @@ regcache_register_size (const struct regcache *regcache, int n) > return register_size (regcache->tdesc, n); > } > > -static unsigned char * > -register_data (const struct regcache *regcache, int n) > +unsigned char * > +regcache::register_data (int regnum) const Just a note: post-rebasing, this would return a gdb::array_view. Simon