From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from CAN01-YT3-obe.outbound.protection.outlook.com (mail-yt3can01on2055.outbound.protection.outlook.com [40.107.115.55]) by sourceware.org (Postfix) with ESMTPS id 55A053858C50 for ; Tue, 12 Sep 2023 17:18:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 55A053858C50 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=efficios.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=n51+qTjxk4hIxppn8OLw3TbdfATvK10OBBO5TWrI36CkFC7V27TRV2ueJFbeoR6TIL6yRQsT74/EsBhDpcrcdRXL84AB55GDKI8NU8SFyh6qrDygzJiiyjvb+BC+ItEePjVcC0R2pSCwWjSfV2ASe9ZK7XtD8mJfEyFyAPCy/HPUMFY7PINtC5OWyUmfmZNTInBLMO9jCLEoyrWMi4hy0HVPhqiMWiVqIT2ucdvLSpTpoopg/Dyhm25ZZWJ8BtcYK6EpdztidyGzToFqZeRs22ILseSt1rwhCHeDnH/AkxQ/UxLztvWCdXvNjslpqdGEE01JNVEcYxHa9JCC/cDPTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=w9hq32YtDN5/pAlbcqRVHBOo6O72gIlAVp8q5hSSY40=; b=BzI2MoQValaZ8eiEqdcgjRT5wwL8AECAH7BfQtigvm66Mrieq8CVLaDGBG5rYbjbxcDYbQR5uwGsFgdO5Ofj/WbzNZ+GhOhyO4rQkT5Gl0BFwuJYYpVWNpuLYPtIvmnb56llc4X2pRHdetrTviUPGI9JJpxI5fUx+5IpUr1l3YlaU9DRXROrs4wPe6o2F7xKi18hlQjTkdyPXwZpRsaT3kqqqeLhmKKGKrO0MUOZ72U2KrS9lAT24qMNgt47dfrIv+RoGa17vIZL/YBLN3xX7dGj2vIX2O+QGprlDwYdMvCzau8ZmSv96Jze06ZMsauTrchFwH8PjpGPRl3CZiNOZw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w9hq32YtDN5/pAlbcqRVHBOo6O72gIlAVp8q5hSSY40=; b=sL5kClutH39alYxfAncefVmjg1eFQE8FHMojeQmDZ+Nb6MAw/KDZrMYpxGgUb3pmBSGRG5MvA7MlNBl8/l+Q3h+Lmr8nGEpIVRe2ruEei0w3FrUn/HDprlkhrHv4dCgvK0ktGHXU4PHWiZ/myqCqZ16SVkdFz6/+T0HnMMczpZnW0LI6mLROSchbzlPD8dPXn5UKl3vATjIv1oaCEBsZwgGOauTPdtKiy5BMF7+IP3c20ZqS2Tbfc2iDChFQaeUWkVotJsipnsdnEaBnrjabmgDjmfTh+HTfbqmNYVnBqpzIstEosyvbHbokOrdoa7mdTSKMBSOEgu3ZfWw8yaPr9w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=efficios.com; Received: from YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:a::23) by YT3PR01MB6597.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:70::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.19; Tue, 12 Sep 2023 17:17:58 +0000 Received: from YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM ([fe80::a015:84e9:f0da:66ec]) by YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM ([fe80::a015:84e9:f0da:66ec%4]) with mapi id 15.20.6768.036; Tue, 12 Sep 2023 17:17:58 +0000 Message-ID: <6f366bea-14f8-4ba0-8376-fb3b97a7802b@efficios.com> Date: Tue, 12 Sep 2023 13:17:56 -0400 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 17/21] gdb: pass current_ui down to interp_set Content-Language: fr To: Andrew Burgess , Simon Marchi via Gdb-patches References: <20230908190227.96319-1-simon.marchi@efficios.com> <20230908190227.96319-18-simon.marchi@efficios.com> <878r9bk6f3.fsf@redhat.com> From: Simon Marchi In-Reply-To: <878r9bk6f3.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YQXPR0101CA0054.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c00:14::31) To YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:a::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YT1PR01MB2828:EE_|YT3PR01MB6597:EE_ X-MS-Office365-Filtering-Correlation-Id: 6f6d2064-3652-4835-276d-08dbb3b435eb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Y5nr1C/U75Rv9w0Jhujh92jBi8cT0odwEAiT6tXo7IWtPNudlAMBPcByWIvE1CbgdbA1R7QvhoXfsuaZKzLJwJUsNcjrzSu2HRYs5T2EswQqcsQoVj8eSySChqK2CI/quyxOBug8ijWug+4hiUDEIw6g8X7oZdNBZ40/z527D5SVPFIp2Tk6pXLlsz9qCOw5ZtAASHzhJ2N4XB6C0ZYrwhUky6LTR5TYKvknWdya2Z3BQ5ECVqlY61NFy+aey7uftbPvxoLtyz1CCBAUnqFVsyRP92H+pCwNZjOP3CBVWe2jEuOdAqcdLOJ6WGZkuk/TFK2PNYDPinYAQJorWkB5QsoKy6/WyHsHFioLKrdzDkIHXNSWWYDDLYS9id6h6bbQX7IjKZmC+I8LBTeTv9r24WxYz66m/6qHFwgqhPZ5CEVdWtKNf+KKrl37FftvYzBTvpq/n0aERKp8eGhz5b/566R3y8p44wDh+B6RxBDJ9gqfZ35SV0lrLqpHoaMvzrBgz/3z5p2Ldt9M6vpErMsGv76Yl+57DwH2ZmlhVZJ9neU7nVW4ULqt0AxeuGfYFJVpv1S7q48rMN57rXBgWl8QyiRw4+YpWcvG/t89V8FBbJvfzteISDajzzWhnc73JXZtYTUjdd3+y1JRQEHkqDxcag== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230031)(346002)(39830400003)(376002)(396003)(366004)(136003)(186009)(451199024)(1800799009)(31686004)(66556008)(66476007)(2906002)(38100700002)(36756003)(31696002)(44832011)(5660300002)(478600001)(8676002)(41300700001)(8936002)(83380400001)(26005)(2616005)(6486002)(6512007)(53546011)(6506007)(316002)(66946007)(110136005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Umw5V0JWb2lIZmN6UVh6WEpWV0F5VHYwYjFVWVdja0pDREkvdG0wRkVzNHc4?= =?utf-8?B?ZVR4Vy9TOFZLamkzZDI2S2x1Mk9WdVRwdTgwRFEzZzFmYVhxMDNDV1RRaytG?= =?utf-8?B?SUVXRDUzY1hnUVZCTStJK2d5NU1KMjJHaTNTc0QvUGU2WFlNSnM4RFJiSEdw?= =?utf-8?B?b2lLeVc1eEx5NEpXTHZoeE51TTFjK2ZCUCsxVng1S2JnVzhwSzRTc0h4d3VI?= =?utf-8?B?NWlRTEZqNnhGalFCQldrUWhXZk5MdUh2VHRsK2lNYm93RVhXVk03aEJELzZH?= =?utf-8?B?dUpTV2lqTnR4aWx2aXNxdFZQaWt6d3poR3Rjd2tjR0pCZWd3K1prWkZiWjd3?= =?utf-8?B?dHBQbXNGelZCdGg5WjBWaTBiQVd0aTZUZm9NYU1zZmQwOUZTdU5HOFJ6Nzhm?= =?utf-8?B?REprWGU3bDNDbmo1VWpJY2FKbTVRQzV0VnRzV01UUXFRcHFOVlVEUWhYOWJk?= =?utf-8?B?K1FmaE1Dd2xLa1lsd0t1YkdOOFF6YkpvaDhZOUpEczYvZzRkQzY4SnhqSlpD?= =?utf-8?B?L3VTQVh5d3ovaS8vWHMyQ1llVHBWdE9ubVZKeUQyRnNjRTdrZzRaOGswR3h3?= =?utf-8?B?ZkhmL0Q2M254Q29kZzkzYVJBenRQNFM4bHQ3dHhIQU4rU3BLeFppSHRzVU9J?= =?utf-8?B?ZUVSN0RTcGt2OXNPSzhPWUx1NndmQm13QTdDTnRJaHBGbUZlT3F2OWU1NkhC?= =?utf-8?B?SXZQS3UwbURDOUtxeWEyUHUrTHBMVE1QQWdxZWtDeGRPOFlmQ1lMVFlvTlFV?= =?utf-8?B?MVpvcHVvZVp0V2ZOYk5hMFlLME96dTI1ZWIxYm5QQjN6N0ZIYWc5dG9udzNq?= =?utf-8?B?aEpIV1pyT3BqTFI2QkZGdmJRWm1PaUpHS2tNY3U5ZUdBZFFzZDhFb1I4WnFt?= =?utf-8?B?T2J6alBINDJ5WjhNOGJXMUNVc0Z3bFFHb0JSYmZpNk5keUtKMDlaSkkxTEs5?= =?utf-8?B?MDUvNUtPTEVLNEllZjBqbUxLcndvcTRzOHJjVVVnT0czZTBnTmkvSEtIVVBR?= =?utf-8?B?N0VMcVBGdzlqRUpVcG93RlcrWGExdk82M3E3NmFNeUFQakh3WXZMbmRnZmV1?= =?utf-8?B?aVBtSlVBZWhTSUtSYURid1FwaDh6MHZzL0loRW9tZjVTMVE0VjdzdGtISnZ1?= =?utf-8?B?WGZQVXhYbjhXTi8xMVMyWWx2Q1gwejN1UWh1SUR2eGNPb3h3YlF4VDFiSzNa?= =?utf-8?B?dEdQeWg1dXpwam1VVEZGclhUM29ZVjVkT1hQZVUyTUhXMlpVWUNwSjJnemE2?= =?utf-8?B?OXFCVWUrWkJwbjlHeTh0VHp1NEk0L3MxYjhsbnVRVE9NeEt6SWUzVTlVNm1u?= =?utf-8?B?cEFEcWNLaUxXckJ2OW9VbGlaOVVKMzNtenRMMGcxUTdwSGlaZ2pKOWZPSWxi?= =?utf-8?B?VmpTbExlRDJsTEMxZ3cwVFVSeTA0TllaamQ5aGdJdzh2SjRYMlkxSGVVOWUr?= =?utf-8?B?WmJQeXN5ZFN6UldBU3pzSVc3M3g1N1h5akNQdXNPQmRxL2NZRDd2cG42VFI5?= =?utf-8?B?OG83YWEreUs2ci9HZmlCL1ZPRlgremZSNnlVTEczcm01OXdSN0hhbE1tNzFR?= =?utf-8?B?Y3N1aFZhb0ppaDZGemp2aVNpdCs3SVF0NUQ5ZlVISUJ6WFIrdjlId0dtK2pv?= =?utf-8?B?WXFwajFkL1A1Z3BYQXdLcURTM0pEN1Jmc293SW9oZjhsaVhMcGh5NkEzR2E1?= =?utf-8?B?d0crZTRESUNMZktFVVFPaiszOUMxbldMd3cwWW4vOFRxUW01V25TZndWMkZ0?= =?utf-8?B?WHNkWlVxaXBmUG5VcGx3Mm5TZlFvODdCNCs4YlFkQXFPV0pCZTZNRVA3a3A2?= =?utf-8?B?T0ZVb3JVTkg0K3pBdmI2d2NpT1dpckhIRW9lS0dnTE9iYjlRUFFDZXJDdkIx?= =?utf-8?B?S3lqL1RvUFhYVlY1di9UQTNXNWRoVWM3bHNKcXJQVjhpSm1KNFdXcmdUQzNo?= =?utf-8?B?WURobTRlN3JVeE5xcnYvNmNkSnRZSVluejhuVFB6Q1MyanIzMVJlS3dLV0JY?= =?utf-8?B?YVkvNnBKUkErUjU5bk81NkNhM1VoNjlJMGo2eVhzakZYRytCQUpXWmh4ZzdV?= =?utf-8?B?SFgrNXVWZ2Z4Tmw3WHdMMHNtUnlhNkYwdjQ1RHRlc3BJRWpOcllFc05GM1lt?= =?utf-8?Q?rJZpIHCLPjyPfzU62X9UsLMEp?= X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6f6d2064-3652-4835-276d-08dbb3b435eb X-MS-Exchange-CrossTenant-AuthSource: YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Sep 2023 17:17:58.5214 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cXywtXlllfokubEOPvxD4iv0MoRJCzfu0oAFtw6kCotTNbBkaVo/5ILUSO+nh77SOf14O+rNDg8hX1S7RC1UrQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YT3PR01MB6597 X-Spam-Status: No, score=-3038.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 9/12/23 06:54, Andrew Burgess wrote: > Simon Marchi via Gdb-patches writes: > >> In preparation for making interp_set a method of struct ui. No behavior >> changes expected. >> >> Change-Id: I507c7701438967502d714ecda99401d785806cab >> --- >> gdb/interps.c | 22 +++++++++++----------- >> 1 file changed, 11 insertions(+), 11 deletions(-) >> >> diff --git a/gdb/interps.c b/gdb/interps.c >> index 0575128b8124..18758f1f7af6 100644 >> --- a/gdb/interps.c >> +++ b/gdb/interps.c >> @@ -92,24 +92,24 @@ find_interp_factory (const char *name) >> are caused by CLI commands. */ >> >> static void >> -interp_set (struct interp *interp, bool top_level) >> +interp_set (ui *ui, struct interp *interp, bool top_level) >> { > > Given where you're going, I'm fine with this. If we planned to stop > here then I'd say, lets use interp->m_ui instead of passing in a > separate ui parameter, but I see why this helps. Ack. This patch basically adds the equivalent of "this", in preparation to making this a method, so it indeed disappears in the next patch. However, this makes me realize it's possible to do: ui->set_current_interpreter (interp) with an INTERP that doesn't belong to UI, and that would be a mistake (that's nothing new, it could happen with interp_set today). Perhaps I can add an assert in set_current_interpreter to ensure we don't try to add set an interp on a UI that belongs to another UI. Simon