From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 75509 invoked by alias); 30 Mar 2018 21:20:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 75500 invoked by uid 89); 30 Mar 2018 21:20:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 30 Mar 2018 21:20:03 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w2ULJsDW004639 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 30 Mar 2018 17:19:59 -0400 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 088461E4B2; Fri, 30 Mar 2018 17:19:54 -0400 (EDT) Subject: Re: [PATCH 1/3] Use std::vector in uploaded_tp To: Simon Marchi , gdb-patches@sourceware.org References: <1521667509-303-1-git-send-email-simon.marchi@ericsson.com> From: Simon Marchi Message-ID: <6f39ae8c-f738-a281-e66f-d96f75483732@polymtl.ca> Date: Fri, 30 Mar 2018 21:20:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <1521667509-303-1-git-send-email-simon.marchi@ericsson.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Fri, 30 Mar 2018 21:19:54 +0000 X-IsSubscribed: yes X-SW-Source: 2018-03/txt/msg00618.txt.bz2 On 2018-03-21 05:25 PM, Simon Marchi wrote: > From: Simon Marchi > > This patch changes the VEC(char_ptr) fields in uploaded_tp to use > std::vector. At first, I wanted to creep in more changes, like > using std::string, but it was making the patch too big and less focused, > so I decided to keep it to just that. > > It also looks like the strings in those vectors are never free'd. If > so, we can fix that in another patch. I pushed this series. Simon