From: Tom de Vries <tdevries@suse.de>
To: Hannes Domani <ssbssa@yahoo.de>,
Hannes Domani via Gdb-patches <gdb-patches@sourceware.org>,
Tom Tromey <tom@tromey.com>
Subject: Re: [PATCHv2] Restore gdb.SYMBOL_STRUCT_DOMAIN constant
Date: Sat, 5 Jun 2021 14:27:17 +0200 [thread overview]
Message-ID: <6f5127bc-9967-4b17-b851-2f14276e3b5e@suse.de> (raw)
In-Reply-To: <2129329660.4623528.1622725230456@mail.yahoo.com>
On 6/3/21 3:00 PM, Hannes Domani via Gdb-patches wrote:
> Am Mittwoch, 2. Juni 2021, 20:39:58 MESZ hat Tom Tromey <tom@tromey.com> Folgendes geschrieben:
>
>>>>>>> "Hannes" == Hannes Domani via Gdb-patches <gdb-patches@sourceware.org> writes:
>>
>> Hannes> It was removed (probably by mistake) in
>> Hannes> 51e78fc5fa21870d415c52f90b93e3c6ad57be46.
>>
>> Yes, sorry about that.
>>
>> Hannes> gdb/ChangeLog:
>>
>> Hannes> 2021-05-26 Hannes Domani <ssbssa@yahoo.de>
>>
>> Hannes> * python/py-symbol.c (gdbpy_initialize_symbols): Restore
>> Hannes> gdb.SYMBOL_LABEL_DOMAIN constant.
>>
>> Hannes> gdb/testsuite/ChangeLog:
>>
>> Hannes> 2021-05-26 Hannes Domani <ssbssa@yahoo.de>
>>
>> Hannes> * gdb.python/py-symbol.exp: Test symbol constants.
>>
>> This is ok. Thank you.
>>
>> Hannes> +# Test gdb.Symbol domain categories
>> Hannes> +gdb_test "python print gdb.SYMBOL_UNDEF_DOMAIN" \
>> Hannes> + "0" "test gdb.SYMBOL_UNDEF_DOMAIN"
>> Hannes> +gdb_test "python print gdb.SYMBOL_VAR_DOMAIN" \
>> Hannes> + "1" "test gdb.SYMBOL_VAR_DOMAIN"
>>
>> While we don't want people to rely on the values of these constants, it
>> seems harmless in the test suite. If someone changes one, they can just
>> update the test.
>
> Pushed, thanks.
With python 3, I'm running into:
...
(gdb) PASS: gdb.python/py-symbol.exp: test symbol destructor
python print gdb.SYMBOL_UNDEF_DOMAIN^M
File "<string>", line 1^M
print gdb.SYMBOL_UNDEF_DOMAIN^M
^^M
SyntaxError: Missing parentheses in call to 'print'. Did you mean
print(gdb.SYMBOL_UNDEF_DOMAIN)?^M
Error while executing Python code.^M
(gdb) FAIL: gdb.python/py-symbol.exp: test gdb.SYMBOL_UNDEF_DOMAIN
...
Thanks,
- Tom
next prev parent reply other threads:[~2021-06-05 12:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210526170536.657-1-ssbssa.ref@yahoo.de>
2021-05-26 17:05 ` Hannes Domani
2021-05-26 18:13 ` Andreas Schwab
2021-05-26 18:19 ` Hannes Domani
2021-05-29 3:19 ` Simon Marchi
2021-06-02 18:39 ` Tom Tromey
2021-06-03 13:00 ` Hannes Domani
2021-06-05 12:27 ` Tom de Vries [this message]
2021-06-05 12:43 ` Hannes Domani
2021-06-05 13:57 ` Tom Tromey
2021-06-05 22:36 ` Tom de Vries
2021-06-10 18:48 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f5127bc-9967-4b17-b851-2f14276e3b5e@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
--cc=ssbssa@yahoo.de \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).