From: Simon Marchi <simon.marchi@polymtl.ca>
To: Andrew Burgess <andrew.burgess@embecosm.com>,
Simon Marchi <simon.marchi@efficios.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] gdb: remove current_top_target function
Date: Wed, 24 Mar 2021 18:11:56 -0400 [thread overview]
Message-ID: <6f60a5b8-489c-e39d-95e1-b7423c9bd30c@polymtl.ca> (raw)
In-Reply-To: <20210324110233.GJ5520@embecosm.com>
On 2021-03-24 7:02 a.m., Andrew Burgess wrote:
> * Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> [2021-03-23 14:41:38 -0400]:
>
>> From: Simon Marchi <simon.marchi@polymtl.ca>
>>
>> The current_top_target function is a hidden dependency on the current
>> inferior. Since I'd like to slowly move towards reducing our dependency
>> on the global current state, remove this function and make callers use
>>
>> current_inferior ()->top_target ()
>>
>> There is no expected change in behavior, but this one step towards
>> making those callers use the inferior from their context, rather than
>> refer to the global current inferior.
>
> LGTM.
>
> Thanks,
> Andrew
Thanks, I pushed both patches.
Simon
next prev parent reply other threads:[~2021-03-24 22:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-23 18:41 [PATCH 1/2] gdb: move all "current target" wrapper implementations to target.c Simon Marchi
2021-03-23 18:41 ` [PATCH 2/2] gdb: remove current_top_target function Simon Marchi
2021-03-24 11:02 ` Andrew Burgess
2021-03-24 22:11 ` Simon Marchi [this message]
2021-03-24 9:29 ` [PATCH 1/2] gdb: move all "current target" wrapper implementations to target.c Andrew Burgess
2021-03-24 14:04 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f60a5b8-489c-e39d-95e1-b7423c9bd30c@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).