From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <simon.marchi@polymtl.ca>
Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11])
 by sourceware.org (Postfix) with ESMTPS id 8EDBA3861034
 for <gdb-patches@sourceware.org>; Wed, 24 Mar 2021 22:12:09 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 8EDBA3861034
Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0)
 by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 12OMBvsf014509
 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); 
 Wed, 24 Mar 2021 18:12:02 -0400
DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 12OMBvsf014509
Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by simark.ca (Postfix) with ESMTPSA id DA2181EF5D;
 Wed, 24 Mar 2021 18:11:56 -0400 (EDT)
Subject: Re: [PATCH 2/2] gdb: remove current_top_target function
To: Andrew Burgess <andrew.burgess@embecosm.com>,
 Simon Marchi <simon.marchi@efficios.com>
Cc: gdb-patches@sourceware.org
References: <20210323184138.876503-1-simon.marchi@efficios.com>
 <20210323184138.876503-2-simon.marchi@efficios.com>
 <20210324110233.GJ5520@embecosm.com>
From: Simon Marchi <simon.marchi@polymtl.ca>
Message-ID: <6f60a5b8-489c-e39d-95e1-b7423c9bd30c@polymtl.ca>
Date: Wed, 24 Mar 2021 18:11:56 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.7.1
MIME-Version: 1.0
In-Reply-To: <20210324110233.GJ5520@embecosm.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Wed, 24 Mar 2021 22:11:57 +0000
X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3,
 RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Wed, 24 Mar 2021 22:12:10 -0000

On 2021-03-24 7:02 a.m., Andrew Burgess wrote:
> * Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> [2021-03-23 14:41:38 -0400]:
> 
>> From: Simon Marchi <simon.marchi@polymtl.ca>
>>
>> The current_top_target function is a hidden dependency on the current
>> inferior.  Since I'd like to slowly move towards reducing our dependency
>> on the global current state, remove this function and make callers use
>>
>>   current_inferior ()->top_target ()
>>
>> There is no expected change in behavior, but this one step towards
>> making those callers use the inferior from their context, rather than
>> refer to the global current inferior.
> 
> LGTM.
> 
> Thanks,
> Andrew

Thanks, I pushed both patches.

Simon