From: Simon Marchi <simark@simark.ca>
To: Andrew Burgess <aburgess@redhat.com>, gdb-patches@sourceware.org
Cc: Tom Tromey <tom@tromey.com>, Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCHv3] gdb: add support for %V to printf command
Date: Fri, 12 May 2023 09:47:48 -0400 [thread overview]
Message-ID: <6f6ef435-d4a9-0a80-066e-9c786c42b191@simark.ca> (raw)
In-Reply-To: <f3cac405a83da4c27506a3ad58f0966f6f8b30fd.1683896221.git.aburgess@redhat.com>
On 5/12/23 09:01, Andrew Burgess via Gdb-patches wrote:
> In v3:
>
> - Addressed all Eli's doc feedback. It was pretty minor, so I don't
> think another doc review is required,
>
> - Rebased, and fixed a minor merge conflict in the testsuite,
>
> - No other code changes since v2,
>
> - Still need to check that Tom's query is satisfied (see V2 email):
> https://sourceware.org/pipermail/gdb-patches/2023-April/199178.html
I've skimmed the patch, the idea looks fine to me. Not sure if we typically
use Acked-By, but I think it's pretty standard:
Acked-By: Simon Marchi <simon.marchi@efficios.com>
Simon
next prev parent reply other threads:[~2023-05-12 13:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-30 12:22 [PATCH] " Andrew Burgess
2023-03-30 14:20 ` Eli Zaretskii
2023-04-11 12:34 ` Andrew Burgess
2023-04-17 15:47 ` Tom Tromey
2023-04-28 13:14 ` [PATCHv2] " Andrew Burgess
2023-04-28 15:34 ` Eli Zaretskii
2023-05-12 13:01 ` [PATCHv3] " Andrew Burgess
2023-05-12 13:47 ` Simon Marchi [this message]
2023-05-26 20:44 ` Tom Tromey
2023-05-30 20:56 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f6ef435-d4a9-0a80-066e-9c786c42b191@simark.ca \
--to=simark@simark.ca \
--cc=aburgess@redhat.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).