* Small typo in iconv.m4
@ 2018-11-06 16:37 Hafiz Abid Qadeer
2018-11-07 15:27 ` Simon Marchi
2018-11-07 22:41 ` Jeff Law
0 siblings, 2 replies; 7+ messages in thread
From: Hafiz Abid Qadeer @ 2018-11-06 16:37 UTC (permalink / raw)
To: gcc-patches; +Cc: gdb-patches, binutils
[-- Attachment #1: Type: text/plain, Size: 705 bytes --]
Hi All,
I was investigating a character set related problem with windows hosted
GDB and I tracked it down to a typo in iconv.m4. This typo caused
libiconv detection to fail and related support was not built into gdb.
The problem is with the following line.
CPPFLAGS="$LIBS $INCICONV"
which should have been
CPPFLAGS="$CPPFLAGS $INCICONV"
OK to commit the attached patch?
2018-11-06 Hafiz Abid Qadeer <abidh@codesourcery.com>
* config/iconv.m4 (AM_ICONV_LINK): Don't overwrite CPPFLAGS.
Append $INCICONV to it.
* gcc/configure: Regenerate.
* libcpp/configure: Likewise.
* libstdc++-v3/configure: Likewise.
* intl/configure: Likewise.
Thanks,
--
Hafiz Abid Qadeer
Mentor Embedded/CodeSourcery
[-- Attachment #2: iconv.patch --]
[-- Type: text/x-patch, Size: 445 bytes --]
diff --git a/config/iconv.m4 b/config/iconv.m4
index 5f9304a6ba..f1e54c5aed 100644
--- a/config/iconv.m4
+++ b/config/iconv.m4
@@ -73,7 +73,7 @@ AC_DEFUN([AM_ICONV_LINK],
if test "$am_cv_func_iconv" != yes; then
am_save_CPPFLAGS="$CPPFLAGS"
am_save_LIBS="$LIBS"
- CPPFLAGS="$LIBS $INCICONV"
+ CPPFLAGS="$CPPFLAGS $INCICONV"
LIBS="$LIBS $LIBICONV"
AC_TRY_LINK([#include <stdlib.h>
#include <iconv.h>],
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: Small typo in iconv.m4
2018-11-06 16:37 Small typo in iconv.m4 Hafiz Abid Qadeer
@ 2018-11-07 15:27 ` Simon Marchi
2018-11-07 22:41 ` Jeff Law
1 sibling, 0 replies; 7+ messages in thread
From: Simon Marchi @ 2018-11-07 15:27 UTC (permalink / raw)
To: Hafiz Abid Qadeer; +Cc: gcc-patches, gdb-patches, binutils
On 2018-11-06 11:37, Hafiz Abid Qadeer wrote:
> Hi All,
> I was investigating a character set related problem with windows hosted
> GDB and I tracked it down to a typo in iconv.m4. This typo caused
> libiconv detection to fail and related support was not built into gdb.
>
> The problem is with the following line.
> CPPFLAGS="$LIBS $INCICONV"
> which should have been
> CPPFLAGS="$CPPFLAGS $INCICONV"
>
> OK to commit the attached patch?
>
> 2018-11-06 Hafiz Abid Qadeer <abidh@codesourcery.com>
>
> * config/iconv.m4 (AM_ICONV_LINK): Don't overwrite CPPFLAGS.
> Append $INCICONV to it.
> * gcc/configure: Regenerate.
> * libcpp/configure: Likewise.
> * libstdc++-v3/configure: Likewise.
> * intl/configure: Likewise.
>
> Thanks,
Seems good from my point of view, but I can't approve.
Simon
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Small typo in iconv.m4
2018-11-06 16:37 Small typo in iconv.m4 Hafiz Abid Qadeer
2018-11-07 15:27 ` Simon Marchi
@ 2018-11-07 22:41 ` Jeff Law
2018-11-09 17:57 ` Eric Gallager
1 sibling, 1 reply; 7+ messages in thread
From: Jeff Law @ 2018-11-07 22:41 UTC (permalink / raw)
To: Hafiz Abid Qadeer, gcc-patches; +Cc: gdb-patches, binutils
On 11/6/18 9:37 AM, Hafiz Abid Qadeer wrote:
> Hi All,
> I was investigating a character set related problem with windows hosted
> GDB and I tracked it down to a typo in iconv.m4. This typo caused
> libiconv detection to fail and related support was not built into gdb.
>
> The problem is with the following line.
> CPPFLAGS="$LIBS $INCICONV"
> which should have been
> CPPFLAGS="$CPPFLAGS $INCICONV"
>
> OK to commit the attached patch?
>
> 2018-11-06 Hafiz Abid Qadeer <abidh@codesourcery.com>
>
> * config/iconv.m4 (AM_ICONV_LINK): Don't overwrite CPPFLAGS.
> Append $INCICONV to it.
> * gcc/configure: Regenerate.
> * libcpp/configure: Likewise.
> * libstdc++-v3/configure: Likewise.
> * intl/configure: Likewise.
>
> Thanks,
>
THanks. I wasn't sure if you had commit privs, so I went ahead and
installed the patch.
Jeff
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Small typo in iconv.m4
2018-11-07 22:41 ` Jeff Law
@ 2018-11-09 17:57 ` Eric Gallager
2018-11-09 18:28 ` Jeff Law
0 siblings, 1 reply; 7+ messages in thread
From: Eric Gallager @ 2018-11-09 17:57 UTC (permalink / raw)
To: Jeff Law; +Cc: Hafiz Abid Qadeer, gcc-patches, gdb-patches, binutils
On 11/7/18, Jeff Law <law@redhat.com> wrote:
> On 11/6/18 9:37 AM, Hafiz Abid Qadeer wrote:
>> Hi All,
>> I was investigating a character set related problem with windows hosted
>> GDB and I tracked it down to a typo in iconv.m4. This typo caused
>> libiconv detection to fail and related support was not built into gdb.
>>
>> The problem is with the following line.
>> CPPFLAGS="$LIBS $INCICONV"
>> which should have been
>> CPPFLAGS="$CPPFLAGS $INCICONV"
>>
>> OK to commit the attached patch?
>>
>> 2018-11-06 Hafiz Abid Qadeer <abidh@codesourcery.com>
>>
>> * config/iconv.m4 (AM_ICONV_LINK): Don't overwrite CPPFLAGS.
>> Append $INCICONV to it.
>> * gcc/configure: Regenerate.
>> * libcpp/configure: Likewise.
>> * libstdc++-v3/configure: Likewise.
>> * intl/configure: Likewise.
>>
>> Thanks,
>>
> THanks. I wasn't sure if you had commit privs, so I went ahead and
> installed the patch.
>
> Jeff
>
Does this have any effect on GCC bug 78251?
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78251
Or any of the related bugs under "See Also" for that matter?
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Small typo in iconv.m4
2018-11-09 17:57 ` Eric Gallager
@ 2018-11-09 18:28 ` Jeff Law
0 siblings, 0 replies; 7+ messages in thread
From: Jeff Law @ 2018-11-09 18:28 UTC (permalink / raw)
To: Eric Gallager; +Cc: Hafiz Abid Qadeer, gcc-patches, gdb-patches, binutils
On 11/9/18 10:57 AM, Eric Gallager wrote:
> On 11/7/18, Jeff Law <law@redhat.com> wrote:
>> On 11/6/18 9:37 AM, Hafiz Abid Qadeer wrote:
>>> Hi All,
>>> I was investigating a character set related problem with windows hosted
>>> GDB and I tracked it down to a typo in iconv.m4. This typo caused
>>> libiconv detection to fail and related support was not built into gdb.
>>>
>>> The problem is with the following line.
>>> CPPFLAGS="$LIBS $INCICONV"
>>> which should have been
>>> CPPFLAGS="$CPPFLAGS $INCICONV"
>>>
>>> OK to commit the attached patch?
>>>
>>> 2018-11-06 Hafiz Abid Qadeer <abidh@codesourcery.com>
>>>
>>> * config/iconv.m4 (AM_ICONV_LINK): Don't overwrite CPPFLAGS.
>>> Append $INCICONV to it.
>>> * gcc/configure: Regenerate.
>>> * libcpp/configure: Likewise.
>>> * libstdc++-v3/configure: Likewise.
>>> * intl/configure: Likewise.
>>>
>>> Thanks,
>>>
>> THanks. I wasn't sure if you had commit privs, so I went ahead and
>> installed the patch.
>>
>> Jeff
>>
>
> Does this have any effect on GCC bug 78251?
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78251
> Or any of the related bugs under "See Also" for that matter?
Certainly looks related. Though I think we're still going to see
pollution, just in a slightly different way.
jeff
^ permalink raw reply [flat|nested] 7+ messages in thread
* Small typo in iconv.m4
@ 2018-11-09 10:18 Hafiz Abid Qadeer
2018-11-09 12:59 ` Nick Clifton
0 siblings, 1 reply; 7+ messages in thread
From: Hafiz Abid Qadeer @ 2018-11-09 10:18 UTC (permalink / raw)
To: gdb-patches, binutils
[-- Attachment #1: Type: text/plain, Size: 410 bytes --]
Hi All,
Attached config/ patch was approved and committed in gcc repo. Ok to
commit it in the binutils-gdb repo?
2018-11-09 Hafiz Abid Qadeer <abidh@codesourcery.com>
* config/iconv.m4 (AM_ICONV_LINK): Don't overwrite CPPFLAGS.
Append $INCICONV to it.
* gdb/configure: Regenerate.
* binutils/configure: Likewise.
* intl/configure: Likewise.
Thanks,
--
Hafiz Abid Qadeer
Mentor Embedded/CodeSourcery
[-- Attachment #2: iconv.patch --]
[-- Type: text/x-patch, Size: 445 bytes --]
diff --git a/config/iconv.m4 b/config/iconv.m4
index 5f9304a6ba..f1e54c5aed 100644
--- a/config/iconv.m4
+++ b/config/iconv.m4
@@ -73,7 +73,7 @@ AC_DEFUN([AM_ICONV_LINK],
if test "$am_cv_func_iconv" != yes; then
am_save_CPPFLAGS="$CPPFLAGS"
am_save_LIBS="$LIBS"
- CPPFLAGS="$LIBS $INCICONV"
+ CPPFLAGS="$CPPFLAGS $INCICONV"
LIBS="$LIBS $LIBICONV"
AC_TRY_LINK([#include <stdlib.h>
#include <iconv.h>],
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: Small typo in iconv.m4
2018-11-09 10:18 Hafiz Abid Qadeer
@ 2018-11-09 12:59 ` Nick Clifton
0 siblings, 0 replies; 7+ messages in thread
From: Nick Clifton @ 2018-11-09 12:59 UTC (permalink / raw)
To: Hafiz Abid Qadeer, gdb-patches, binutils
Hi Hafiz,
> Hi All,
> Attached config/ patch was approved and committed in gcc repo. Ok to
> commit it in the binutils-gdb repo?
>
> 2018-11-09 Hafiz Abid Qadeer <abidh@codesourcery.com>
>
> * config/iconv.m4 (AM_ICONV_LINK): Don't overwrite CPPFLAGS.
> Append $INCICONV to it.
> * gdb/configure: Regenerate.
> * binutils/configure: Likewise.
> * intl/configure: Likewise.
Approved, please apply. I should note however that the changelog
entry probably should be split up and added to the respective
subdirectories ChangeLog files. In particular I was confused because
I could not find a mention on the change in gcc's config/ChangeLog
file, and was rather surprised when I found it in the top level
ChangeLog file instead.
Cheers
Nick
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-11-09 18:28 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-06 16:37 Small typo in iconv.m4 Hafiz Abid Qadeer
2018-11-07 15:27 ` Simon Marchi
2018-11-07 22:41 ` Jeff Law
2018-11-09 17:57 ` Eric Gallager
2018-11-09 18:28 ` Jeff Law
2018-11-09 10:18 Hafiz Abid Qadeer
2018-11-09 12:59 ` Nick Clifton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).