From: Tom de Vries <tdevries@suse.de>
To: Tom Tromey <tom@tromey.com>,
Tom de Vries via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 2/6] [gdb/symtab] Factor out type::{alloc_fields,copy_fields}
Date: Thu, 31 Aug 2023 09:57:44 +0200 [thread overview]
Message-ID: <6fb0a077-43c6-d122-7c23-df9aa1d8862f@suse.de> (raw)
In-Reply-To: <87r0nkqo7x.fsf@tromey.com>
On 8/30/23 22:17, Tom Tromey wrote:
>>>>>> "Tom" == Tom de Vries via Gdb-patches <gdb-patches@sourceware.org> writes:
>
> Tom> After finding this code in buildsym_compunit::finish_block_internal:
> Tom> ...
> ftype-> set_fields
> Tom> ((struct field *)
> Tom> TYPE_ALLOC (ftype, nparams * sizeof (struct field)));
> Tom> ...
> Tom> and fixing PR30810 by using TYPE_ZALLOC, I wondered if there were more
> Tom> locations that needed fixing.
>
> Tom> I decided to make things easier to spot by factoring out a new function
> Tom> alloc_fields:
>
> Thanks. Seems like a good idea to me.
>
> Tom> +void type::alloc_fields (unsigned int nfields, bool init)
>
> gdb style is a newline after the return type.
> There's a few cases of this.
Ack, fixed and pushed the series.
Thanks for the reviews.
- Tom
next prev parent reply other threads:[~2023-08-31 7:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-30 19:13 [PATCH 1/6] [gdb/symtab] Fix uninitialized memory in buildsym_compunit::finish_block_internal Tom de Vries
2023-08-30 19:13 ` [PATCH 2/6] [gdb/symtab] Factor out type::{alloc_fields,copy_fields} Tom de Vries
2023-08-30 20:17 ` Tom Tromey
2023-08-31 7:57 ` Tom de Vries [this message]
2023-08-30 19:13 ` [PATCH 3/6] [gdb/symtab] Do more zero-initialization of type::fields Tom de Vries
2023-08-30 20:19 ` Tom Tromey
2023-08-30 19:13 ` [PATCH 4/6] [gdb/symtab] Replace TYPE_ALLOC + memset with TYPE_ZALLOC Tom de Vries
2023-08-30 20:20 ` Tom Tromey
2023-08-30 19:13 ` [PATCH 5/6] [gdb/symtab] Replace TYPE_ALLOC + B_CLRALL " Tom de Vries
2023-08-30 20:21 ` Tom Tromey
2023-08-31 8:00 ` Tom de Vries
2023-08-30 19:13 ` [PATCH 6/6] [gdb/symtab] Replace TYPE_ALLOC with TYPE_ZALLOC where required Tom de Vries
2023-08-30 20:26 ` Tom Tromey
2023-08-30 20:15 ` [PATCH 1/6] [gdb/symtab] Fix uninitialized memory in buildsym_compunit::finish_block_internal Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6fb0a077-43c6-d122-7c23-df9aa1d8862f@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).