From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) by sourceware.org (Postfix) with ESMTPS id 9895B3857369 for ; Thu, 21 Apr 2022 10:31:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9895B3857369 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f47.google.com with SMTP id g18so6013836wrb.10 for ; Thu, 21 Apr 2022 03:31:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=R8eHiaY111EtG6VJk7wINw4efLmRckca6a9RVcGHOEA=; b=z9nbwKQaK3U5+OUBDi8HCcodeqqHYXSydUlYg63SXgACZz07cHFUOEP85x6A4+vQVy 3wOQ11/w84Acc9kmtloXxPRt8lTs0Gi80628DtM6zxMReevHkLjwfIV1jjrDovEP+P4R DPtt94iA9trHOdga3sIj2CmswwEaagFPswalmls4KOj/x7l5LErRWFMSEWmbjTilD3hb XvnFuriED1Uo8zJ4RP3we7eUMhZyfaomecd1eN/APE+/qYeuzSPPhj+7SEAzRLgpNZ48 IFmtQBuC035pWqWqAGmdKj8dXXohTMxyNH+vyFHvQsrRVE17y+5kIDG5WtxNUrh7YNab 4DMg== X-Gm-Message-State: AOAM533aIwWX4k0JNxiaGRryLU/41qDv2yGzWL99U9cuPu9iCbVFrg7N LSpzB9B5rxdTUMXXrkILTxg= X-Google-Smtp-Source: ABdhPJwKwmxuAiwft8XFepQGBuQjN/kfXz7OWxNgM/8fJGzTysX9Or6UJnxddqwXmuvcOJucDuwG3A== X-Received: by 2002:a05:6000:144c:b0:20a:818d:e3c0 with SMTP id v12-20020a056000144c00b0020a818de3c0mr18510971wrx.584.1650537085499; Thu, 21 Apr 2022 03:31:25 -0700 (PDT) Received: from ?IPV6:2001:8a0:f924:2600:209d:85e2:409e:8726? ([2001:8a0:f924:2600:209d:85e2:409e:8726]) by smtp.gmail.com with ESMTPSA id bi26-20020a05600c3d9a00b0038ed39dbf00sm1708104wmb.0.2022.04.21.03.31.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Apr 2022 03:31:24 -0700 (PDT) Message-ID: <6fb9a140-0163-ce56-ac78-f5bf3f1b7795@palves.net> Date: Thu, 21 Apr 2022 11:31:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: "show remote foo-packet" regression (Re: [PATCH v2 1/3] gdb: Make global feature array a per-remote target array) Content-Language: en-US To: Andrew Burgess , Christina Schimpe , gdb-patches@sourceware.org References: <20220329131158.3970228-1-christina.schimpe@intel.com> <20220329131158.3970228-2-christina.schimpe@intel.com> <08fd8bbf-c44e-7313-d7b3-7b0770c2c7d4@palves.net> <7c319441-067e-6f5c-cf80-84d696c9236e@palves.net> <87mtgerawv.fsf@redhat.com> From: Pedro Alves In-Reply-To: <87mtgerawv.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Apr 2022 10:31:28 -0000 On 2022-04-21 11:25, Andrew Burgess wrote: > Pedro Alves writes: >> >> This commit is present in the GDB 12 branch and not in GDB 11, so it's a regression there. > > Sorry for the regression. I took a look at the code and I honestly have > no idea why I thought the code in the above commit would work :-/ > No worries, happens all the time to me. :-) > Below is a patch that should fix this issue. I probably should write a > test to go along with it, but thought I'd share this for feedback first. > > Let me know what you think, LGTM. Thanks for fixing it.