Re: [PATCH 0/2 Version 2] Add recording support for the ISA 3.1 Powerpc instructions

[Carl Love <cel@us.ibm.com>]

Joel Brobecker:

On Fri, 2022-03-04 at 11:46 -0800, Carl Love wrote:
> GDB maintainers:
> 
> The gdb record functionality does not have support for the the
> Powerpc
> ISA 3.1 instructions.  
> 
> The first patch in this series will add the missing support to record
> the registers for each of the ISA 3.1 instructions.
> 
> The second patch in the series adds two test cases.  The first test
> case verifies the recording works for a few of the ISA 2.06
> instructions.  The second case verifies recording of a few ISA 3.1
> instructions.
> 
> I have used the Valgrind ISA 3.1 testsuite to verify that all of the
> ISA 3.1 instructions are recognized by gdb record.  Additionally, I
> manually ran gdb stoping at the Valgrind test function for each of
> the
> new instructions.  I then verified that all of the expected registers
> changed and were then restored when the instruction was executed in
> reverse.  Basically, the test process consisted of stopping at the
> isa
> instruction, issue the gdb command record command, info registers all
> saving the output file 1, si,  info registers all saving the output
> file 2, reverse-stepi, info registers all saving the output file
> 3.  I
> then diffed files 1 and 2 to verify the test changed all of the
> registers specified in the ISA. Finally, diff files 1 and 3 to verify
> all of the registers were restored.

Sorry it took so long to get this updated.  I initially missed your
response as it went to my gdb account not cel@us.ibm.com.  I have
addressed your comments with both of the testcase patches.  The
regression tests have been rerun on Power 10 to verify the tests still
run correctly.

                      Carl Love