From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id CD73D3858D28 for ; Tue, 12 Apr 2022 17:09:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CD73D3858D28 Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 23CFBu7f015430; Tue, 12 Apr 2022 17:09:51 GMT Received: from ppma01wdc.us.ibm.com (fd.55.37a9.ip4.static.sl-reverse.com [169.55.85.253]) by mx0a-001b2d01.pphosted.com with ESMTP id 3fdbur2kwt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 12 Apr 2022 17:09:50 +0000 Received: from pps.filterd (ppma01wdc.us.ibm.com [127.0.0.1]) by ppma01wdc.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 23CGsCK0026311; Tue, 12 Apr 2022 17:09:48 GMT Received: from b03cxnp07027.gho.boulder.ibm.com (b03cxnp07027.gho.boulder.ibm.com [9.17.130.14]) by ppma01wdc.us.ibm.com with ESMTP id 3fb1s91kf5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 12 Apr 2022 17:09:48 +0000 Received: from b03ledav003.gho.boulder.ibm.com (b03ledav003.gho.boulder.ibm.com [9.17.130.234]) by b03cxnp07027.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 23CH9kUX35389706 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 12 Apr 2022 17:09:46 GMT Received: from b03ledav003.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9EDB96A047; Tue, 12 Apr 2022 17:09:46 +0000 (GMT) Received: from b03ledav003.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 355566A04D; Tue, 12 Apr 2022 17:09:46 +0000 (GMT) Received: from li-e362e14c-2378-11b2-a85c-87d605f3c641.ibm.com (unknown [9.211.50.167]) by b03ledav003.gho.boulder.ibm.com (Postfix) with ESMTP; Tue, 12 Apr 2022 17:09:46 +0000 (GMT) Message-ID: <6fcdd54547e753dd64baac21618c7ef2cc4844f4.camel@us.ibm.com> Subject: Re: [PATCH 0/2 Version 2] Add recording support for the ISA 3.1 Powerpc instructions From: Carl Love To: gdb-patches@sourceware.org, Ulrich Weigand , Joel Brobecker , cel@us.ibm.com Cc: Will Schmidt , Tulio Magno , Rogerio Alves Date: Tue, 12 Apr 2022 10:09:45 -0700 In-Reply-To: <7ff0655bead2a8245018fbf9624f207cd38a5b7f.camel@us.ibm.com> References: <7ff0655bead2a8245018fbf9624f207cd38a5b7f.camel@us.ibm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-18.el8) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: 0ew8T3j7VO6ySCHbAERZ7g5TrRCjZIaO X-Proofpoint-GUID: 0ew8T3j7VO6ySCHbAERZ7g5TrRCjZIaO X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-04-12_06,2022-04-12_02,2022-02-23_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 lowpriorityscore=0 mlxlogscore=722 spamscore=0 adultscore=0 bulkscore=0 phishscore=0 priorityscore=1501 mlxscore=0 suspectscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2204120081 X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Apr 2022 17:09:55 -0000 Joel Brobecker: On Fri, 2022-03-04 at 11:46 -0800, Carl Love wrote: > GDB maintainers: > > The gdb record functionality does not have support for the the > Powerpc > ISA 3.1 instructions. > > The first patch in this series will add the missing support to record > the registers for each of the ISA 3.1 instructions. > > The second patch in the series adds two test cases. The first test > case verifies the recording works for a few of the ISA 2.06 > instructions. The second case verifies recording of a few ISA 3.1 > instructions. > > I have used the Valgrind ISA 3.1 testsuite to verify that all of the > ISA 3.1 instructions are recognized by gdb record. Additionally, I > manually ran gdb stoping at the Valgrind test function for each of > the > new instructions. I then verified that all of the expected registers > changed and were then restored when the instruction was executed in > reverse. Basically, the test process consisted of stopping at the > isa > instruction, issue the gdb command record command, info registers all > saving the output file 1, si, info registers all saving the output > file 2, reverse-stepi, info registers all saving the output file > 3. I > then diffed files 1 and 2 to verify the test changed all of the > registers specified in the ISA. Finally, diff files 1 and 3 to verify > all of the registers were restored. Sorry it took so long to get this updated. I initially missed your response as it went to my gdb account not cel@us.ibm.com. I have addressed your comments with both of the testcase patches. The regression tests have been rerun on Power 10 to verify the tests still run correctly. Carl Love