From: "Wallin, Henrik" <Henrik.Wallin@windriver.com>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: RE: [RFC][PATCH 10/15] gdb: Add arm_fast_tracepoint_valid_at
Date: Thu, 29 Oct 2015 22:36:00 -0000 [thread overview]
Message-ID: <7014C13F3D22A944AFC3200B12FB0A11765B49F8@ALA-MBA.corp.ad.wrs.com> (raw)
In-Reply-To: <86io5szh7r.fsf@gmail.com>
2015-10-27 12:25 GMT+01:00 Yao Qi <qiyaoltc@gmail.com>:
> henrik.wallin@windriver.com writes:
>
>> + if (arm_pc_is_thumb (gdbarch, addr))
>> + {
>> + len = gdb_print_insn (gdbarch, addr, gdb_null, NULL);
>
> We don't need to call gdb_print_insn to know the instruction size.
> Instead, we can do something simpler,
>
> if (arm_pc_is_thumb (gdbarch, pc))
> {
> len = thumb_insn_size (inst1);
> }
> else
> len = 4;
yes, that looks better.
thanks,
/ Henrik
next prev parent reply other threads:[~2015-10-29 17:51 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-14 11:14 [RFC][PATCH 00/15] Fast tracepoint support for ARMv7 henrik.wallin
2015-10-14 11:14 ` [RFC][PATCH 02/15] Fix internal error when saving fast tracepoint definitions henrik.wallin
2015-10-15 17:19 ` Pedro Alves
2015-10-14 11:14 ` [RFC][PATCH 04/15] Fix crash in tstatus after detach henrik.wallin
2015-10-14 11:48 ` Gary Benson
2015-10-29 18:45 ` Wallin, Henrik
2015-10-30 14:15 ` Gary Benson
2015-10-15 17:22 ` Pedro Alves
2015-10-29 18:31 ` Wallin, Henrik
2015-10-14 11:14 ` [RFC][PATCH 01/15] Fix endian problem for tracepoint enabled flag henrik.wallin
2015-10-15 17:16 ` Pedro Alves
2015-10-29 18:20 ` Wallin, Henrik
2015-10-14 15:07 ` [RFC][PATCH 12/15] gdbserver: Add help functions to get arm/thumb mode henrik.wallin
2015-10-14 15:07 ` [RFC][PATCH 06/15] Add possibility to restart trace after tfind henrik.wallin
2015-10-15 17:26 ` Pedro Alves
2015-10-14 15:07 ` [RFC][PATCH 05/15] Fix crash when tstart after detach henrik.wallin
2015-10-15 17:24 ` Pedro Alves
2015-10-14 15:07 ` [RFC][PATCH 03/15] Fix crash in enable/disable " henrik.wallin
2015-10-15 16:30 ` Pedro Alves
2015-10-29 18:29 ` Wallin, Henrik
2015-10-14 15:07 ` [RFC][PATCH 08/15] gdbserver: Move pointer dereference to after assert checks henrik.wallin
2015-10-15 17:29 ` Pedro Alves
2015-10-29 19:01 ` Wallin, Henrik
2015-10-30 0:20 ` Antoine Tremblay
2015-10-30 5:25 ` Antoine Tremblay
2015-10-14 15:07 ` [RFC][PATCH 10/15] gdb: Add arm_fast_tracepoint_valid_at henrik.wallin
2015-10-27 13:36 ` Yao Qi
2015-10-29 22:36 ` Wallin, Henrik [this message]
2015-10-14 15:07 ` [RFC][PATCH 07/15] Fix mmap usage of MAP_FIXED for multiple pages henrik.wallin
2015-10-14 15:26 ` Andreas Schwab
2015-10-29 17:58 ` Wallin, Henrik
2015-10-14 15:08 ` [RFC][PATCH 11/15] gdbserver: Add helper functions to create arm instructions henrik.wallin
2015-10-14 15:08 ` [RFC][PATCH 15/15] gdb/gdbserver: Enable tracepoint for ARM henrik.wallin
2015-10-14 15:12 ` [RFC][PATCH 14/15] gdbserver: Add linux-arm-ipa.c henrik.wallin
2015-10-27 13:36 ` Yao Qi
2015-10-14 15:15 ` [RFC][PATCH 13/15] gdbserver: Add arm_install_fast_tracepoint_jump_pad henrik.wallin
2015-10-14 15:21 ` [RFC][PATCH 09/15] gdb: Add relocate instruction helpers henrik.wallin
2015-10-27 13:30 ` Yao Qi
2015-10-29 20:40 ` Wallin, Henrik
2015-11-20 18:06 ` Simon Marchi
2015-11-23 11:00 ` Yao Qi
2015-11-24 16:29 ` Simon Marchi
2015-10-27 13:23 ` [RFC][PATCH 00/15] Fast tracepoint support for ARMv7 Yao Qi
2015-10-30 1:52 ` Wallin, Henrik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7014C13F3D22A944AFC3200B12FB0A11765B49F8@ALA-MBA.corp.ad.wrs.com \
--to=henrik.wallin@windriver.com \
--cc=gdb-patches@sourceware.org \
--cc=qiyaoltc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).