From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) by sourceware.org (Postfix) with ESMTPS id 731EB3858C54 for ; Tue, 17 Oct 2023 19:14:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 731EB3858C54 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 731EB3858C54 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.85.221.43 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697570077; cv=none; b=DIf1DsTUgzvMOLVb23amCbQiyQiwnBRoBq6S5r3/7NQNXt+uoakFmslhkFnKMaD2iLVlm1d4HnQVKzNw/6GbxRhr1W7n7VwqpX0jaaFz3w2cNmNMuxqk1aGtj79MRqyd56M4KKfT10crE4H3e5U5xmsJBIgnp6B22fb/GB/rUA8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697570077; c=relaxed/simple; bh=1WmzvdApFhEPEzBd9obX714HA+ifuDdjOnYTNQHBCOw=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=yC0eh/Z/mOT/TI3cSQbkEfm6VN4L4Akh8KCx8SNYPVhXWWXba9Wm1iEnzZv/oGfwxY52wSIKAbVPA0yItqITOcKHzvv6I8bjCDrh1W4JeK6tmoIbFNd91936KeMtk1ajykv2VeaGll3cszIwV2hmd3NfcvGCqhRSUtwC78M1NAg= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-32799639a2aso5293137f8f.3 for ; Tue, 17 Oct 2023 12:14:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697570075; x=1698174875; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QbX0TOOwePJeM8ilj+h6djmroSeSfVa4qJGI62jrR+c=; b=ivUiRzq8NvXAxy9YB5ylrkhP64iCAakg1Xbo3znyUyT2/CkQOS9Rk5Bps8geSf+EWA 1duXO7+MA3xN0t1SiFzaaNbWEFKsVMLgtKG7D59MUUyvn1BByqA2GsiVgGy4Yu23GaHL ZmzNm580W0itUhxOe9F0klS1rrcxgJaqT+S7WN1x1JhkYPSzKzRdlHKfzvEBvXIDTwO4 8VxANlbSd9F9+JTetzc/bDIFqIOiPln6M/NB3IMxAA2pV0LhSyZBT0jIff6GS1h3adiS bY/vs+E67M1/ots2MUYRa4mdKfCqwfgjdOwFmc5tW8NfOYWIv6eJ7pesTypyPpLrtrCL F0eQ== X-Gm-Message-State: AOJu0YyK5/rfzmEqav3+1XogBobEEcl2Y2voYlcjmKoAHQwC/6dVKdp2 RLSFW/J9wiwzTUH4c4Mzw2wqfPygg0aYKg== X-Google-Smtp-Source: AGHT+IFkKXAoLRnomoQdlvVmWgoC7xNRlbLhYCSipMIw3MEXbaSrNoqVu4/IGGZ2oRomc88chHFS1Q== X-Received: by 2002:a05:6000:ca:b0:32c:af13:9084 with SMTP id q10-20020a05600000ca00b0032caf139084mr2746250wrx.22.1697570075109; Tue, 17 Oct 2023 12:14:35 -0700 (PDT) Received: from ?IPV6:2001:8a0:f939:d200:5aaf:ade2:476b:3ff2? ([2001:8a0:f939:d200:5aaf:ade2:476b:3ff2]) by smtp.gmail.com with ESMTPSA id i3-20020a5d6303000000b0032db4e660d9sm401980wru.56.2023.10.17.12.14.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Oct 2023 12:14:34 -0700 (PDT) Message-ID: <708a1d8c-ab07-4e38-a352-1b58a6e189e4@palves.net> Date: Tue, 17 Oct 2023 20:14:24 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 21/24] gdb: link so_list using intrusive_list Content-Language: en-US To: Simon Marchi , gdb-patches@sourceware.org References: <20231010204213.111285-1-simon.marchi@efficios.com> <20231010204213.111285-22-simon.marchi@efficios.com> From: Pedro Alves In-Reply-To: <20231010204213.111285-22-simon.marchi@efficios.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.3 required=5.0 tests=BAYES_00,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,GIT_PATCH_0,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023-10-10 21:40, Simon Marchi wrote: > diff --git a/gdb/solist.h b/gdb/solist.h > index 9320acb7fd3e..31b823a3a482 100644 > --- a/gdb/solist.h > +++ b/gdb/solist.h > @@ -36,7 +36,7 @@ struct lm_info > > using lm_info_up = std::unique_ptr; > > -struct so_list > +struct so_list : intrusive_list_node I noticed this in patch #24: > @@ -52,7 +52,7 @@ struct so_list : intrusive_list_node > dynamic linker's tables in the inferior, and are initialized by > current_sos. */ > > - struct so_list *next = nullptr; /* next structure in linked list */ > + so *next = nullptr; /* next structure in linked list */ Err, what "next" still doing there? :-) This patch should have deleted it. Pedro Alves > { > /* Free symbol-file related contents of SO and reset for possible reloading > of SO. If we have opened a BFD for SO, close it. If we have placed SO's > @@ -121,7 +121,7 @@ struct target_so_ops > inferior --- we don't examine any of the shared library files > themselves. The declaration of `struct so_list' says which fields > we provide values for. */ > - struct so_list *(*current_sos) (void); > + intrusive_list (*current_sos) (); > > /* Find, open, and read the symbols for the main executable. If > FROM_TTY is non-zero, allow messages to be printed. */ > @@ -171,8 +171,6 @@ struct target_so_ops > void (*handle_event) (void); > }; > > -using so_list_range = next_range; > - > /* Free the memory associated with a (so_list *). */ > void free_so (so_list &so); >