From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70073.outbound.protection.outlook.com [40.107.7.73]) by sourceware.org (Postfix) with ESMTPS id EC7953856266 for ; Tue, 24 May 2022 08:39:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EC7953856266 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=FXRqVLd1Z50VIQTaDdKcV6uBz1huPrQKVPORBv7V8NuE/eQruC0Hn325LjwpwVAsUcUd8u/GUXUtwJrjurnhP2cePmxxZaIIWRAPlmAfvPStbZw63hMAimwiHSXkSTAcq+19SpO9k78vpNG8bXYWI9lMmEvFb0uvqv3VmD7+xfpTakGanuKWc9rTHzjOoe8DvewqMwRM8zUVAcmWbr6RQLiSEQ2GL+Z/aTOxFSzThhQsPvLODbJQr8skZW4egyECTLqQEk3GSXFGuogydoI3+T9STnJVjqSqyPwdrihXYgOOE8GJD1MZgIWqoSiCkZRjx/3u1C3wmSjXPCEQhBpcTQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Q/Yu6hWcmn83cabOP6fTXnpin2/f1TbuCRSXhS0nR24=; b=GyycmxHkgYLGUYaHFeA9LUJ+hUrAKQFSaa49PF08cIwqxgKJuJs+lZHP8KaT8EaLXwAs4iJMoCV+0LwBd1b57TAG6ntFakwRJ9Qb8G83KAiXJvoekmAvMmbl9Stpkawzq1OO5MkVUq3e4iJ3rkElkQwbNBOYWdfLRLQVEQpg1RLx7dHcWNxkuLU/SYmZ8bA+OAqPfCNaeoLUW4Sy9wXYzhLt0uuOfUfIHyhkznweOwsZmMgwwEDciFwlKt6lUKkZDVsMk3hN7WktX7Maop209BtOGfA4zp5bSi+NzxasC8Aw4aseiM2Jp4ZGqxKh5p/KJWuNxijAN/4QDgXXF6BV3Q== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) Received: from DB3PR06CA0011.eurprd06.prod.outlook.com (2603:10a6:8:1::24) by DB7PR08MB3289.eurprd08.prod.outlook.com (2603:10a6:5:26::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.18; Tue, 24 May 2022 08:39:02 +0000 Received: from DBAEUR03FT038.eop-EUR03.prod.protection.outlook.com (2603:10a6:8:1:cafe::21) by DB3PR06CA0011.outlook.office365.com (2603:10a6:8:1::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14 via Frontend Transport; Tue, 24 May 2022 08:39:02 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT038.mail.protection.outlook.com (100.127.143.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14 via Frontend Transport; Tue, 24 May 2022 08:39:02 +0000 Received: ("Tessian outbound 361d68419a2f:v119"); Tue, 24 May 2022 08:39:02 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 270d910e6249c762 X-CR-MTA-TID: 64aa7808 Received: from b84940ee615e.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 4C76359D-4F3E-4C88-BBBE-45852C3B0AFE.1; Tue, 24 May 2022 08:38:55 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b84940ee615e.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 24 May 2022 08:38:55 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jLcY7PXstyShqM3pE0s6RC30edsaX0WM9ehZdA3fOFM9XZO1YMKA8LNS+E0Qy52h6Z1ctCrGR8Abe8R1cvkBk9O+JMYbNSlIlajI9j8Gijl8jY674QIK4QMaH2B+7mKooI7BK8o+m1OfIFz8MBcQa8eJbdNrjSW8dUICtDlWylJ88lxRG2xuJ6Umnk0T1ZbiZDryyW7wTvndc6+CuDHGs1ywx4Ey7rzoKNaC32AW9cMK2DCZGDkCAXmQSakIFO7t+FvOCeIyH+dGX4CzwCpYbmrBhnFRPz4uq4AhhwqUylw1QGNNqxCQCAuK8Z4uGry8kZ/Rk0icA+Z1Rf7+nUjXuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Q/Yu6hWcmn83cabOP6fTXnpin2/f1TbuCRSXhS0nR24=; b=SfYWTs9O9qx7UiDzm0GAWAcn4NGj764/47AFOi/3G5XDb3XB88uQNA4CEQ6cgyEHY/Q3VwqbcNai6GNxkis3/o23w13kixFnu2kehLq1P1ajsmV/PBq2Ek/rn0MCxcI50OV35cXDVVNwdZMPA9ut3YF34VmfPvFeZoxNha74s03aVX7BbeWNwL94xDU1Kun5RuFMx+eBAHa0N6EboFyfj4ZXLx8HVE/X4oTMsJc5lLwE1EXuCpjcADPIYidSB7On9g+PFWziS0xRrYFuKHx1v1UK2sULyQidIChwjZJGIzoUZlw4AMniQPRCt/YYpD3jGXOt9uFwgqNm5zyzV51xKg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by HE1PR0801MB1945.eurprd08.prod.outlook.com (2603:10a6:3:4f::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.17; Tue, 24 May 2022 08:38:52 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::7080:6233:cf8f:a8a6]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::7080:6233:cf8f:a8a6%7]) with mapi id 15.20.5273.023; Tue, 24 May 2022 08:38:52 +0000 Message-ID: <70ddb0b0-7c7d-3bcd-ef3d-246290ae1edf@arm.com> Date: Tue, 24 May 2022 09:38:51 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 0/2] info breakpoints improvements Content-Language: en-US To: Pedro Alves , gdb-patches@sourceware.org References: <20220519215552.3254012-1-pedro@palves.net> From: Luis Machado In-Reply-To: <20220519215552.3254012-1-pedro@palves.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0207.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a5::14) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 626e1908-47df-408f-3754-08da3d60daba X-MS-TrafficTypeDiagnostic: HE1PR0801MB1945:EE_|DBAEUR03FT038:EE_|DB7PR08MB3289:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: jjn68vZ960JPhwa2SxT8ARCpv+F6LSYcv+4/uTrSHqIRi7GZavJirnQXnlatm24HihpaJ0mEXoq439z2I2EFmMhVwtk3M+6xw+iVJMabl2PuxuEK4pYaZcC9S1R8xnJf2t+Ap8A7D8P+G5IBFAPuZZjtTf+riwSfFJdq6RpB+Dt8OTRe/bIWjK1NpCSzUryaLpZQ5wjFzFUwboiKSt17Z9tYhNxax5CmDnoaSSlCxP2HhB0I0pzGlM2oyIoTL0aS1TxtUpzkfSbdt+0xen0rJOyQpHyKbBvr+pVcvf8Y4TF9NodMub76p3jmKYQYDAGjuA7wAOTwKjDb0mLfXwohWfaQVo/msp7pD+ap47ICElxB9xHBvV1F3lBcr/zpu/+9A5QB0/pvn7HM7rbRRhROV6l6facMXa5CmUnp+yn8EiTzrgSW0ANJsEXuZyGMrYz3mFOIQnjbnse2zWzKALvZe0k1HOlMQSt4YYHOw1s8i9aC5E+ExVVr6tFNt5k8cWiO4fmGavg7jCAG3qGeL6ke0fBY7KVVqcNYypvZH9vDEGwT4TU7MgcgjOJYAD4x/qiD9pq3UfDrqijjx7pXiHaB5rFf5wcY4vBiWMizknKiggDbJ1PvBSf6GyN7bzAbpGvN0+SfmhDeqNeiYOCZbf+CLk0ZmOnzO+Oh9ZEIkA8mQpQcPaXQoKAm2mnm8QB9ektvkrOoIFworJtVvs8TR57QZRDjNWZ2NNNMKZRVMur8ttmKy+eGtGlYFf6+TRQPteCVo0orub9NRzr31O3OJ54EiImqV3yaSIRJQOr8MdgR5KDXYNWUQ6eouzzgLSFSXI12 X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR08MB3919.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(8676002)(66946007)(44832011)(966005)(66556008)(2906002)(66476007)(31696002)(8936002)(38100700002)(508600001)(5660300002)(186003)(83380400001)(2616005)(26005)(6506007)(53546011)(86362001)(6512007)(316002)(6486002)(36756003)(31686004)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB1945 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT038.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: d7253899-3896-486b-fe36-08da3d60d4bb X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: onApNkvkOyGNG1vL8EF4gLDNZMgUw38pRWXpMgqj3hLrk8SQ9m4WOAdxJnkhgBBzPncYK8N1V2Wi4dMfR28POT13oJzaLTBcse43uvBENkILI1GZwtdswtveDl7Qm3az1bI354xMIEoHmu3HZMnL8XJM+e2x9c2xya3r24D5+PdcXlWkJ6jIzhdTlTtib3FnobJR0cdwgFnnUWlE/uBvKeDTLtnK4bjWwJZODstyN9rBhhLK0tT42GOvzXGeKc1t9O0pz4GJagdphqKFEHafqEXdW5wiGRQF5x5LuYGpGhR2lAezWZWwx2uXnU2t/7YuYp4Bb3t3vvzZL7dAsMQAIjom9xN7R3LW8pn14Od2ZsO4Y9EKk8LqPG/DwP60boCn2OU36Sm28Eqd/w6m7l1Kn0TXWfBLI1lRqnpf07K6IEz2Hnoc9wmtW4bv/P7bFJ7W/oID76NAv7hxTORpsGDYWxbcHZwO84PF8xPXXbmsOBD2pNQoTiSL6n/hIX5HzJ+mh1W14ok3cm7xYj+CNPnR7b7RnFpQUvAFUHW0P0yrewAVoRKvBkWf76YQR16Yz5ZiJ4Mix7i3nwFZ9i/zT1DqUMfqBAyiGyz1WCeiQm+vNS0/CSTs8m0NmgUPv9zacjmwiO8uvFiCZWixfv0Pc08LYIwDrkWZVHbiuIH42A4736JqPZId8GQKQIB/i1iZYiVsKPWlbTnQ4sDW+ZBGz/Y6qEi8geMgmaRaf64aQI09wQb6YTj9YgjmUMDsP6FNIB4v2OgjimEkH7j0MOOGeYiuOqRgtfRpYYKT8nu1K7Besmo= X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230001)(4636009)(40470700004)(36840700001)(46966006)(5660300002)(316002)(31696002)(356005)(81166007)(8676002)(44832011)(186003)(2616005)(86362001)(83380400001)(26005)(6506007)(53546011)(8936002)(36756003)(966005)(6486002)(6512007)(336012)(508600001)(31686004)(36860700001)(47076005)(2906002)(70586007)(82310400005)(70206006)(40460700003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 May 2022 08:39:02.1981 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 626e1908-47df-408f-3754-08da3d60daba X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT038.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3289 X-Spam-Status: No, score=-8.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 May 2022 08:39:09 -0000 On 5/19/22 22:55, Pedro Alves wrote: > The subject of breakpoint line number sliding came up again in an > internal discussion, which reminded me of this WIP patch that I > originally posted here: > https://sourceware.org/pipermail/gdb-patches/2019-June/158638.html > > Here's an updated version that is close to ready for merging. It > needs agreement, and, testsuite adjustments. Oh, and I realize now, > NEWS entries. Both patches already contain documentation changes. I > went through the whole "Set Breaks" chapter fixing up things to better > match current reality as I was documenting the new features. > > Patch #1 changes GDB such that instead of: > > (top-gdb) info breakpoints > 1 breakpoint keep y 0x0000000000575127 in internal_error(char const*, int, char const*, ...) at src/gdb/common/errors.c:54 > 2 breakpoint keep y 0x0000000000575127 in internal_error(char const*, int, char const*, ...) at src/gdb/common/errors.c:54 > 3 breakpoint keep y > 3.1 y 0x0000000000575127 in internal_error(char const*, int, char const*, ...) at src/gdb/common/errors.c:54 > 3.2 y 0x00007ffff6d50410 in PyErr_SetObject at /usr/src/debug/python2-2.7.15-4.fc27.x86_64/Python/errors.c:54 > 4 breakpoint keep y 0x000055555564107b in main(int, char**) at src/gdb/gdb.c:28 > (top-gdb) > > we get: > > (top-gdb) info breakpoints > Num Type Disp Enb Address What > 1 breakpoint keep y internal_error > 1.1 y 0x00000000005755a5 in internal_error(char const*, int, char const*, ...) at src/gdb/common/errors.c:54 > 2 breakpoint keep y -qualified internal_error > 2.1 y 0x00000000005755a5 in internal_error(char const*, int, char const*, ...) at src/gdb/common/errors.c:54 > 3 breakpoint keep y errors.c:54 > 3.1 y 0x00000000005755a5 in internal_error(char const*, int, char const*, ...) at src/gdb/common/errors.c:54 > 3.2 y 0x00007ffff6d50410 in PyErr_SetObject at /usr/src/debug/python2-2.7.15-4.fc27.x86_64/Python/errors.c:54 > 4 breakpoint keep y gdb.c:27 > 4.1 y 0x000055555564107b in main(int, char**) at src/gdb/gdb.c:28 > (top-gdb) > The additional information is nice to have, though I don't use it myself and I'm happy with and the fact GDB adjusts line numbers (it's just natural). Maybe others not familiar with DWARF and line tables will find it useful. Maybe even IDE's dealing with GDB. I could make a point that the patch makes things slightly more verbose, but the breakpoint display is already quite verbose. :-) So overall it looks like a good direction to go. I anticipate a lot of tedious changes to the testsuite due to changing patterns.