Re: [PATCH v2] guile: fix smob exports

[Simon Marchi <simon.marchi@polymtl.ca>]

On 2021-06-06 2:49 p.m., George Barrett via Gdb-patches wrote:
> Before Guile v2.1[1], calls to `scm_make_smob_type' implicitly
> added the created class to the exports list of (oop goops); v2.1+ does
> not implicitly create bindings in any modules. This means that the GDB
> manual subsection documenting exported types is not quite right when
> GDB is linked against Guile <v2.1 (types are exported from (oop
> goops)) instead of (gdb)) and incorrect when linked against Guile
> v2.1+ (types are not bound to any variables at all!).
> 
> This commit makes a small change to GDB's smob registration machinery
> to make sure registered smobs get exported from the current
> module. This will likely cause warnings to the user about conflicting
> exports if they load both (gdb) and (oop goops) from a GDB linked
> against Guile v2.0, but it shouldn't impact functionality (and seemed
> preferable to trying to un-export bindings from (oop goops) if v2.0
> was detected).
> 
> [1]: This changed with Guile commit
>      28d0871b553a3959a6c59e2e4caec1c1509f8595

Since nobody reviewed this, I'll go ahead.  I won't pretend that I am
able to verify everything you claim above, but I trust that you know
what you are talking about :).  I didn't understand though from your
explanation what consequence the bad behavior has.  What did it prevent
a Guile user to do?

I'm fine with you merging the patch.  If some other Guile-knowledgeable
person would like to take a look (even after it is merged), they are
more than welcome to.

Simon