From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-sender-0.a4lg.com (mail-sender-0.a4lg.com [IPv6:2401:2500:203:30b:4000:6bfe:4757:0]) by sourceware.org (Postfix) with ESMTPS id B2453384D17A for ; Thu, 6 Oct 2022 06:36:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B2453384D17A Received: from [127.0.0.1] (localhost [127.0.0.1]) by mail-sender-0.a4lg.com (Postfix) with ESMTPSA id 8FFD8300089; Thu, 6 Oct 2022 06:36:46 +0000 (UTC) From: Tsukasa OI To: Tsukasa OI , Andrew Burgess , Mike Frysinger , Stephane Carrez , "Frank Ch . Eigler" Cc: gdb-patches@sourceware.org Subject: [PATCH v2 1/7] sim: Add ATTRIBUTE_PRINTF Date: Thu, 6 Oct 2022 06:36:27 +0000 Message-Id: <7188b6a895ad46fba60e0f8ffa1a985e6dbe6eed.1665038133.git.research_trasio@irq.a4lg.com> In-Reply-To: References: Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Oct 2022 06:36:50 -0000 Clang generates a warning if the format string of a printf-like function is not a literal ("-Wformat-nonliteral"). On the default configuration, it causes a build failure (unless "--disable-werror" is specified). To avoid warnings on the printf-like wrapper, it requires proper __attribute__((format)) and we have ATTRIBUTE_PRINTF macro for this reason. This commit adds ATTRIBUTE_PRINTF to a printf-like function. --- sim/common/sim-utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sim/common/sim-utils.c b/sim/common/sim-utils.c index 259b14cce29..f079bb3f330 100644 --- a/sim/common/sim-utils.c +++ b/sim/common/sim-utils.c @@ -146,7 +146,7 @@ sim_cpu_msg_prefix (sim_cpu *cpu) /* Cover fn to sim_io_eprintf. */ -void +void ATTRIBUTE_PRINTF (2, 3) sim_io_eprintf_cpu (sim_cpu *cpu, const char *fmt, ...) { SIM_DESC sd = CPU_STATE (cpu); -- 2.34.1