From: Luis Machado <luis.machado@arm.com>
To: Thiago Jung Bauermann <thiago.bauermann@linaro.org>,
Pedro Alves <pedro@palves.net>
Cc: gdb-patches@sourceware.org, Christophe Lyon <christophe.lyon@linaro.org>
Subject: Re: [PATCH v2 1/5] gdb/aarch64: Implement software single stepping for MOPS instructions
Date: Wed, 22 May 2024 11:51:05 +0100 [thread overview]
Message-ID: <71b304a1-13c2-4e06-b9ff-0586d6183091@arm.com> (raw)
In-Reply-To: <87zfsiu9m0.fsf@linaro.org>
On 5/21/24 22:40, Thiago Jung Bauermann wrote:
> Pedro Alves <pedro@palves.net> writes:
>
>> On 2024-05-07 03:22, Thiago Jung Bauermann wrote:
>>
>>> The Arm Architecture Reference Manual says that "the prologue, main, and
>>> epilogue instructions are expected to be run in succession and to appear
>>> consecutively in memory". Therefore GDB needs to treat them as an atomic
>>> instruction sequence, and also can't do displaced stepping with them.
>>
>> Curious on this "can't". GDB could copy the whole sequence to the displaced
>> stepping buffer, and execute then in one go, and it should work, right?
>>
>> Not suggesting that you should do it as a requisite to the patch, just
>> trying to understand it, in case the issue comes up again in other contexts.
>
> Yes. I hadn't thought of that, but Luis also gave that idea. He said¹
> that "Regarding displaced stepping, we can disable displaced stepping
> temporarily for these instructions. If we find a convenient way to
> relocate the whole block of MOPS instructions, then we can add that
> later on."
>
> I'll work on it as a future improvement.
>
FTR, I'm still happy with enabling this in an upcoming patch. We might have to
think about whether displaced-stepping the block and then getting interrupted
in the middle of executing it needs special handling.
next prev parent reply other threads:[~2024-05-22 10:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-07 2:22 [PATCH v2 0/5] Add support for AArch64 " Thiago Jung Bauermann
2024-05-07 2:22 ` [PATCH v2 1/5] gdb/aarch64: Implement software single stepping for " Thiago Jung Bauermann
2024-05-10 13:23 ` Pedro Alves
2024-05-21 21:40 ` Thiago Jung Bauermann
2024-05-22 10:51 ` Luis Machado [this message]
2024-05-07 2:22 ` [PATCH v2 2/5] gdb/aarch64: Add record support " Thiago Jung Bauermann
2024-05-07 2:22 ` [PATCH v2 3/5] gdb/testsuite: Add gdb.arch/aarch64-mops-watchpoint.exp Thiago Jung Bauermann
2024-05-10 13:32 ` Pedro Alves
2024-05-21 21:03 ` Thiago Jung Bauermann
2024-05-22 9:22 ` Tom de Vries
2024-05-22 15:38 ` Tom Tromey
2024-05-22 16:43 ` Thiago Jung Bauermann
2024-05-07 2:22 ` [PATCH v2 4/5] gdb/testsuite: Add gdb.arch/aarch64-mops-atomic-inst.exp Thiago Jung Bauermann
2024-05-07 2:22 ` [PATCH v2 5/5] gdb/testsuite: Add gdb.reverse/aarch64-mops.exp Thiago Jung Bauermann
2024-05-08 8:52 ` [PATCH v2 0/5] Add support for AArch64 MOPS instructions Luis Machado
2024-05-09 3:24 ` Thiago Jung Bauermann
2024-05-10 5:20 ` Thiago Jung Bauermann
2024-05-10 13:11 ` Luis Machado
2024-05-10 15:07 ` Guinevere Larsen
2024-05-23 1:43 ` Thiago Jung Bauermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71b304a1-13c2-4e06-b9ff-0586d6183091@arm.com \
--to=luis.machado@arm.com \
--cc=christophe.lyon@linaro.org \
--cc=gdb-patches@sourceware.org \
--cc=pedro@palves.net \
--cc=thiago.bauermann@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).