From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id 6C71F3858C36 for ; Sun, 25 Dec 2022 08:06:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6C71F3858C36 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 19F052563E; Sun, 25 Dec 2022 08:06:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1671955614; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TmaZwQ5lfy94HPPq6YU+GHltR0DT86BvV1sBwqnt6P8=; b=heIXRaMM687J2jZTi39J/tziF0IF+HFMH7S4bW6ucaQrIZKpkh9ZLCgyj5obnCM0qcM8Qk zGL1GozgPp2MOj1nnlh+ydZ0MmIRDbJ2JvyC3doSBlZ+l4ZRGfKRjBB/30wbPATBMiWl5D HxNpxvUOYMSm5AJaeCNUuSqHJUsokMg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1671955614; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TmaZwQ5lfy94HPPq6YU+GHltR0DT86BvV1sBwqnt6P8=; b=3FEZ8ZlCe+3RhCiS2UpzkYm9kvwajAPuFODafrfGh1ViIUcPLg1Oh5WQGOo2MTFynrDsnF ellBj0m2RJuZUEBA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 126E9138F2; Sun, 25 Dec 2022 08:06:54 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id awlKBJ4EqGO3KAAAMHmgww (envelope-from ); Sun, 25 Dec 2022 08:06:54 +0000 MIME-Version: 1.0 Date: Sun, 25 Dec 2022 08:06:53 +0000 From: tdevries To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Add initializers to comp_unit_head In-Reply-To: <20221224224435.760523-1-tom@tromey.com> References: <20221224224435.760523-1-tom@tromey.com> User-Agent: Roundcube Webmail Message-ID: <71d0815665fb2b2c4904264b023840d1@suse.de> X-Sender: tdevries@suse.de Content-Type: multipart/mixed; boundary="=_c1580ebef80cd5664b752dda4d037616" X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --=_c1580ebef80cd5664b752dda4d037616 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; format=flowed On 2022-12-24 22:44, Tom Tromey wrote: > PR symtab/29343 points out that it would be beneficial if > comp_unit_head had a constructor and used initializers. This patch > implements this. LGTM. > I'm unsure if this is sufficient to close the bug, > but at least it's a step. > I think it's sufficient. FWIW, I've rebased the patch attached to the PR on your patch, and I'm left with the patch below, which makes the length field of comp_unit_head private. Thanks, - Tom --=_c1580ebef80cd5664b752dda4d037616 Content-Transfer-Encoding: base64 Content-Type: text/x-patch; name=0001-gdb-symtab-Make-comp_unit_head.length-private.patch Content-Disposition: attachment; filename=0001-gdb-symtab-Make-comp_unit_head.length-private.patch; size=3328 RnJvbSBiMDRjNzkxNTg2ZGEyOTE2Y2E4NzUyMWVjYTNjODJiYTcxY2QyMmZiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUb20gZGUgVnJpZXMgPHRkZXZyaWVzQHN1c2UuZGU+CkRhdGU6 IFN1biwgMjUgRGVjIDIwMjIgMDg6NTM6NDMgKzAxMDAKU3ViamVjdDogW1BBVENIXSBbZ2RiL3N5 bXRhYl0gTWFrZSBjb21wX3VuaXRfaGVhZC5sZW5ndGggcHJpdmF0ZQoKTWFrZSBjb21wX3VuaXRf aGVhZC5sZW5ndGggcHJpdmF0ZSwgdG8gZW5mb3JjZSB1c2luZyBhY2Nlc3NvciBmdW5jdGlvbgpn ZXRfbGVuZ3RoLgoKVGVzdGVkIG9uIHg4Nl82NC1saW51eC4KClBSIHN5bXRhYi8yOTM0MwpCdWc6 IGh0dHBzOi8vc291cmNld2FyZS5vcmcvYnVnemlsbGEvc2hvd19idWcuY2dpP2lkPTI5MzQzCi0t LQogZ2RiL2R3YXJmMi9jb21wLXVuaXQtaGVhZC5jIHwgIDQgKystLQogZ2RiL2R3YXJmMi9jb21w LXVuaXQtaGVhZC5oIHwgMTYgKysrKysrKysrKysrKy0tLQogZ2RiL2R3YXJmMi9yZWFkLmMgICAg ICAgICAgIHwgIDQgKystLQogMyBmaWxlcyBjaGFuZ2VkLCAxNyBpbnNlcnRpb25zKCspLCA3IGRl bGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2dkYi9kd2FyZjIvY29tcC11bml0LWhlYWQuYyBiL2dk Yi9kd2FyZjIvY29tcC11bml0LWhlYWQuYwppbmRleCBlZGIyYThhYTU1YS4uMTI4ZDYyZmNiYjEg MTAwNjQ0Ci0tLSBhL2dkYi9kd2FyZjIvY29tcC11bml0LWhlYWQuYworKysgYi9nZGIvZHdhcmYy L2NvbXAtdW5pdC1oZWFkLmMKQEAgLTQ0LDcgKzQ0LDcgQEAgcmVhZF9jb21wX3VuaXRfaGVhZCAo c3RydWN0IGNvbXBfdW5pdF9oZWFkICpjdV9oZWFkZXIsCiAgIGNvbnN0IGNoYXIgKmZpbGVuYW1l ID0gc2VjdGlvbi0+Z2V0X2ZpbGVfbmFtZSAoKTsKICAgYmZkICphYmZkID0gc2VjdGlvbi0+Z2V0 X2JmZF9vd25lciAoKTsKIAotICBjdV9oZWFkZXItPmxlbmd0aCA9IHJlYWRfaW5pdGlhbF9sZW5n dGggKGFiZmQsIGluZm9fcHRyLCAmYnl0ZXNfcmVhZCk7CisgIGN1X2hlYWRlci0+c2V0X2xlbmd0 aCAocmVhZF9pbml0aWFsX2xlbmd0aCAoYWJmZCwgaW5mb19wdHIsICZieXRlc19yZWFkKSk7CiAg IGN1X2hlYWRlci0+aW5pdGlhbF9sZW5ndGhfc2l6ZSA9IGJ5dGVzX3JlYWQ7CiAgIGN1X2hlYWRl ci0+b2Zmc2V0X3NpemUgPSAoYnl0ZXNfcmVhZCA9PSA0KSA/IDQgOiA4OwogICBpbmZvX3B0ciAr PSBieXRlc19yZWFkOwpAQCAtMTY2LDcgKzE2Niw3IEBAIGVycm9yX2NoZWNrX2NvbXBfdW5pdF9o ZWFkIChkd2FyZjJfcGVyX29iamZpbGUgKnBlcl9vYmpmaWxlLAogICAgICAgPiBzZWN0aW9uLT5z aXplKQogICAgIGVycm9yIChfKCJEd2FyZiBFcnJvcjogYmFkIGxlbmd0aCAoMHgleCkgaW4gY29t cGlsYXRpb24gdW5pdCBoZWFkZXIgIgogCSAgICIob2Zmc2V0ICVzICsgMCkgW2luIG1vZHVsZSAl c10iKSwKLQkgICBoZWFkZXItPmxlbmd0aCwgc2VjdF9vZmZzZXRfc3RyIChoZWFkZXItPnNlY3Rf b2ZmKSwKKwkgICBoZWFkZXItPmdldF9sZW5ndGggKGZhbHNlKSwgc2VjdF9vZmZzZXRfc3RyICho ZWFkZXItPnNlY3Rfb2ZmKSwKIAkgICBmaWxlbmFtZSk7CiB9CiAKZGlmZiAtLWdpdCBhL2dkYi9k d2FyZjIvY29tcC11bml0LWhlYWQuaCBiL2dkYi9kd2FyZjIvY29tcC11bml0LWhlYWQuaAppbmRl eCA3NTc5ZmU3ZmEyOS4uNTZiMzdhZTUzN2UgMTAwNjQ0Ci0tLSBhL2dkYi9kd2FyZjIvY29tcC11 bml0LWhlYWQuaAorKysgYi9nZGIvZHdhcmYyL2NvbXAtdW5pdC1oZWFkLmgKQEAgLTM0LDcgKzM0 LDkgQEAKICAgIHRyYW5zbGF0aW9uLCBsb29rcyBsaWtlIHRoaXMuICAqLwogc3RydWN0IGNvbXBf dW5pdF9oZWFkCiB7Ci0gIHVuc2lnbmVkIGludCBsZW5ndGggPSAwOworcHJpdmF0ZToKKyAgdW5z aWduZWQgaW50IG1fbGVuZ3RoID0gMDsKK3B1YmxpYzoKICAgdW5zaWduZWQgY2hhciB2ZXJzaW9u ID0gMDsKICAgdW5zaWduZWQgY2hhciBhZGRyX3NpemUgPSAwOwogICB1bnNpZ25lZCBjaGFyIHNp Z25lZF9hZGRyX3AgPSAwOwpAQCAtNjUsMTAgKzY3LDE4IEBAIHN0cnVjdCBjb21wX3VuaXRfaGVh ZAogICAgICBEV19VVF9za2VsZXRvbiBvciBEV19VVF9zcGxpdF9jb21waWxlLiAgKi8KICAgVUxP TkdFU1Qgc2lnbmF0dXJlID0gMDsKIAorICB2b2lkIHNldF9sZW5ndGggKHVuc2lnbmVkIGludCBs ZW5ndGgpCisgIHsKKyAgICBtX2xlbmd0aCA9IGxlbmd0aDsKKyAgfQorCiAgIC8qIFJldHVybiB0 aGUgdG90YWwgbGVuZ3RoIG9mIHRoZSBDVSBkZXNjcmliZWQgYnkgdGhpcyBoZWFkZXIuICAqLwot ICB1bnNpZ25lZCBpbnQgZ2V0X2xlbmd0aCAoKSBjb25zdAorICB1bnNpZ25lZCBpbnQgZ2V0X2xl bmd0aCAoYm9vbCBpbmNsdWRlX2luaXRpYWwgPSB0cnVlKSBjb25zdAogICB7Ci0gICAgcmV0dXJu IGluaXRpYWxfbGVuZ3RoX3NpemUgKyBsZW5ndGg7CisgICAgdW5zaWduZWQgaW50IHJlcyA9IG1f bGVuZ3RoOworICAgIGlmIChpbmNsdWRlX2luaXRpYWwpCisgICAgICByZXMgKz0gaW5pdGlhbF9s ZW5ndGhfc2l6ZTsKKyAgICByZXR1cm4gcmVzOwogICB9CiAKICAgLyogUmV0dXJuIFRSVUUgaWYg T0ZGIGlzIHdpdGhpbiB0aGlzIENVLiAgKi8KZGlmZiAtLWdpdCBhL2dkYi9kd2FyZjIvcmVhZC5j IGIvZ2RiL2R3YXJmMi9yZWFkLmMKaW5kZXggMjhmYWRiODg2YWEuLjUwODgxOTI5ZDQ3IDEwMDY0 NAotLS0gYS9nZGIvZHdhcmYyL3JlYWQuYworKysgYi9nZGIvZHdhcmYyL3JlYWQuYwpAQCAtNzc0 NCw3ICs3NzQ0LDcgQEAgbG9hZF9mdWxsX2NvbXBfdW5pdCAoZHdhcmYyX3Blcl9jdV9kYXRhICp0 aGlzX2N1LAogCiAgIGdkYl9hc3NlcnQgKGN1LT5kaWVfaGFzaCA9PSBOVUxMKTsKICAgY3UtPmRp ZV9oYXNoID0KLSAgICBodGFiX2NyZWF0ZV9hbGxvY19leCAoY3UtPmhlYWRlci5sZW5ndGggLyAx MiwKKyAgICBodGFiX2NyZWF0ZV9hbGxvY19leCAoY3UtPmhlYWRlci5nZXRfbGVuZ3RoIChmYWxz ZSkgLyAxMiwKIAkJCSAgZGllX2hhc2gsCiAJCQkgIGRpZV9lcSwKIAkJCSAgTlVMTCwKQEAgLTIz MDI2LDcgKzIzMDI2LDcgQEAgcmVhZF9zaWduYXR1cmVkX3R5cGUgKHNpZ25hdHVyZWRfdHlwZSAq c2lnX3R5cGUsCiAKICAgICAgIGdkYl9hc3NlcnQgKGN1LT5kaWVfaGFzaCA9PSBOVUxMKTsKICAg ICAgIGN1LT5kaWVfaGFzaCA9Ci0JaHRhYl9jcmVhdGVfYWxsb2NfZXggKGN1LT5oZWFkZXIubGVu Z3RoIC8gMTIsCisJaHRhYl9jcmVhdGVfYWxsb2NfZXggKGN1LT5oZWFkZXIuZ2V0X2xlbmd0aCAo ZmFsc2UpIC8gMTIsCiAJCQkgICAgICBkaWVfaGFzaCwKIAkJCSAgICAgIGRpZV9lcSwKIAkJCSAg ICAgIE5VTEwsCi0tIAoyLjM0LjEKCg== --=_c1580ebef80cd5664b752dda4d037616--