From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from jupiter.monnerat.net (jupiter.monnerat.net [46.226.111.226]) by sourceware.org (Postfix) with ESMTPS id ADBD43858407 for ; Fri, 13 Aug 2021 22:15:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org ADBD43858407 Received: from patrick.monnerat ([192.168.0.128]) by jupiter.monnerat.net (8.14.8/8.14.8) with ESMTP id 17DMFVhh009330 (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256 verify=OK); Sat, 14 Aug 2021 00:15:37 +0200 DKIM-Filter: OpenDKIM Filter v2.10.3 jupiter.monnerat.net 17DMFVhh009330 Subject: Re: [PATCH] Notify observer of breakpoint auto-disabling To: Simon Marchi , gdb-patches@sourceware.org References: <20210813153131.54709-1-patrick@monnerat.net> <1f4c2f9c-a2ab-6981-82d2-3ab38f1bb3e3@monnerat.net> <3e03ee4f-b922-a1b1-904a-686624733959@polymtl.ca> From: Patrick Monnerat Message-ID: <71d5f086-2931-b29e-2ffd-a717d416206f@monnerat.net> Date: Sat, 14 Aug 2021 00:15:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <3e03ee4f-b922-a1b1-904a-686624733959@polymtl.ca> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Spam-Status: No, score=-13.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, JMQ_SPF_NEUTRAL, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Aug 2021 22:16:01 -0000 On 8/13/21 8:59 PM, Simon Marchi wrote: > On 2021-08-13 12:27 p.m., Patrick Monnerat wrote: >> On 8/13/21 5:45 PM, Simon Marchi wrote: >>> On 2021-08-13 11:31 a.m., Patrick Monnerat via Gdb-patches wrote: >>>> As observer in currently notified of breakpoint stop before handling its >>>> auto-disabling after count is reached, the observer is never notified of >>>> the disabling. >>>> >>>> This patch moves the observer notification after the auto-disabling >>>> code. >>>> >>>> Fixes https://sourceware.org/bugzilla/show_bug.cgi?id=23336 >>>> >>>> * gdb/breakpoint.c (bpstat_stop_status): move observer notification >>>> after auto-disabling code. >>>> --- >>>> gdb/breakpoint.c | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c >>>> index 89af44ee4c6..feca224ccf4 100644 >>>> --- a/gdb/breakpoint.c >>>> +++ b/gdb/breakpoint.c >>>> @@ -5491,7 +5491,6 @@ bpstat_stop_status (const address_space *aspace, >>>> if (bs->stop) >>>> { >>>> ++(b->hit_count); >>>> - gdb::observers::breakpoint_modified.notify (b); >>>> /* We will stop here. */ >>>> if (b->disposition == disp_disable) >>>> @@ -5501,6 +5500,7 @@ bpstat_stop_status (const address_space *aspace, >>>> b->enable_state = bp_disabled; >>>> removed_any = 1; >>>> } >>>> + gdb::observers::breakpoint_modified.notify (b); >>>> if (b->silent) >>>> bs->print = 0; >>>> bs->commands = b->commands; >>>> >>> Is there some user-visible behavior change, that we could write a test for? >> With gdb alone, I don't think so. >> >> This impacts insight: the breakpoint GUI window does not refllect the disabling. >> >> No possible workaround here, since the observer is never notified again after breakpoint has been disabled (unless some user action on the later). >> >> As this is a GUI behavior, I don't think we can write a gdb test in this context. > Ok, thanks. I think this information should be included in the commit > message, as it justifies the need for the change. I will re-post patch with commit message updated. Patrick