From: Pedro Alves <palves@redhat.com>
To: Sergio Durigan Junior <sergiodj@redhat.com>,
GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [RFA] Adjust gdb.arch/i386-sse-stack-align.exp print statement
Date: Fri, 08 Dec 2017 10:47:00 -0000 [thread overview]
Message-ID: <71f1cec5-d299-6b08-4189-84f35e18fc4c@redhat.com> (raw)
In-Reply-To: <20171207233015.18656-1-sergiodj@redhat.com>
On 12/07/2017 11:30 PM, Sergio Durigan Junior wrote:
>
> commit 46a4882b3c7d9ec981568b8b13a3c9c39c8f8e61
> Author: Pedro Alves <palves@redhat.com>
> Date: Mon Sep 4 20:21:15 2017 +0100
>
> Stop assuming no-debug-info variables have type int
>
> We now have to explicitly tell GDB the type of the non-debug-info
> variable we want to print (by casting). This commit adjusts the
> "print" statement on gdb.arch/i386-sse-stack-align.exp to do the
> proper cast, fixing a failure that started to happen after the
> mentioned commit.
>
> gdb/testsuite/ChangeLog:
> 2017-12-07 Sergio Durigan Junior <sergiodj@redhat.com>
>
> * gdb.arch/i386-sse-stack-align.exp: Cast "print" variable to
> "int".
This is OK, except...
> ---
> gdb/testsuite/ChangeLog | 5 +++++
> gdb/testsuite/gdb.arch/i386-sse-stack-align.exp | 2 +-
> 2 files changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
> index 53f114aa15..81d23d1bb1 100644
> --- a/gdb/testsuite/ChangeLog
> +++ b/gdb/testsuite/ChangeLog
> @@ -1,3 +1,8 @@
> +2017-12-07 Sergio Durigan Junior <sergiodj@redhat.com>
> +
> + * gdb.arch/i386-sse-stack-align.exp: Cast "print" variable to
> + "int".
> +
> 2017-12-07 Keith Seitz <keiths@redhat.com>
>
> * gdb.cp/nested-types.cc: New file.
> diff --git a/gdb/testsuite/gdb.arch/i386-sse-stack-align.exp b/gdb/testsuite/gdb.arch/i386-sse-stack-align.exp
> index 47fb9f42d2..946f217ce1 100644
> --- a/gdb/testsuite/gdb.arch/i386-sse-stack-align.exp
> +++ b/gdb/testsuite/gdb.arch/i386-sse-stack-align.exp
> @@ -43,7 +43,7 @@ if ![runto_main] then {
>
> set args ""
> foreach i {0 1 2 3 4} {
> - set test "print g$i ($args)"
> + set test "print (int) g$i ($args)"
... this is printing/calling a function, not a variable:
(gdb) print g0 ()
'g0' has unknown return type; cast the call to its declared return type
So the git log and ChangeLog are inaccurate and should
reference 7022349d5c86 ("Stop assuming no-debug-info functions
return int") instead.
OK with that fixed.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2017-12-08 10:47 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-13 15:32 [PATCH v2 00/13] No-debug-info debugging improvements Pedro Alves
2017-07-13 15:32 ` [PATCH v2 06/13] evaluate_subexp_standard: Remove useless assignments Pedro Alves
2017-07-13 15:32 ` [PATCH v2 02/13] Stop assuming no-debug-info functions return int Pedro Alves
2017-07-13 15:32 ` [PATCH v2 05/13] evaluate_subexp_standard: Eliminate one goto Pedro Alves
2017-07-13 15:32 ` [PATCH v2 01/13] Fix calling prototyped functions via function pointers Pedro Alves
2017-07-13 15:32 ` [PATCH v2 11/13] Handle "p 'S::method()::static_var'" (quoted) in symbol lookup Pedro Alves
2017-07-13 15:32 ` [PATCH v2 10/13] Handle "p S::method()::static_var" in the C++ parser Pedro Alves
2017-07-13 15:32 ` [PATCH v2 03/13] Introduce OP_VAR_MSYM_VALUE Pedro Alves
2017-07-13 15:32 ` [PATCH v2 09/13] Eliminate UNOP_MEMVAL_TLS Pedro Alves
2017-07-13 15:37 ` [PATCH v2 12/13] Make "p S::method() const::static_var" work too Pedro Alves
2017-07-13 15:38 ` [PATCH v2 08/13] Stop assuming no-debug-info variables have type int Pedro Alves
2017-12-07 23:30 ` [RFA] Adjust gdb.arch/i386-sse-stack-align.exp print statement Sergio Durigan Junior
2017-12-08 10:47 ` Pedro Alves [this message]
2017-12-08 16:28 ` Sergio Durigan Junior
2017-07-13 15:38 ` [PATCH v2 13/13] Document "no debug info debugging" improvements Pedro Alves
2017-07-13 16:11 ` Eli Zaretskii
2017-07-13 16:31 ` Pedro Alves
2017-07-13 17:54 ` Eli Zaretskii
2017-07-13 15:38 ` [PATCH v2 07/13] evaluate_subexp_standard: Factor out OP_VAR_VALUE handling Pedro Alves
2017-07-13 15:39 ` [PATCH v2 04/13] Make ptype/whatis print function name of functions with no debug info too Pedro Alves
2017-09-04 19:21 ` [PATCH v2 00/13] No-debug-info debugging improvements Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71f1cec5-d299-6b08-4189-84f35e18fc4c@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=sergiodj@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).