From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk1-xa33.google.com (mail-vk1-xa33.google.com [IPv6:2607:f8b0:4864:20::a33]) by sourceware.org (Postfix) with ESMTPS id 8B7063858D28 for ; Tue, 23 Nov 2021 12:56:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8B7063858D28 Received: by mail-vk1-xa33.google.com with SMTP id b125so12314894vkb.9 for ; Tue, 23 Nov 2021 04:56:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:from:to:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=MqN+9S3prvwpTQ8ssoKpdr64C69aJX5KheIOGJB/gvY=; b=q4VkfsUftsaHCu5GTOImGrILCZXUoHOWJzj3Spgxsnhc5O+FvcGmmHdGRKgElCBaQc 50haTTc+1XCfFF+zsPhQLF+7b44Ybx57LOozLYDTKM46hEs9WJoD2DD0SQDFnHyNkMnN 74D4Bxsk9IBp734FkyGtgpdj3lQFufc12Of0nulYA4dv4XwksRAgG0aBQtcEPl8tTVOt rdfP0lvwW+uCnWH9STYiyv6zpheY2Nx4VFAsPOtEjKMKc9QWGQlpWLJsruTg5dDHuTiJ IJwoilcLgOuXj718Uh8kGC4D/b/8elBt3oXsldD/3wWtffZD3lsSy1yI6gvdFuv3RUfI 5BFQ== X-Gm-Message-State: AOAM530q2IzV8KAXgHzUbKOxG6/++NaNaXjVxLgqFRnZDt5hiv6haym/ filKAYJKKem7BIEbeVS/bCEGhUe4b6IWyA== X-Google-Smtp-Source: ABdhPJxDiaqE5CO2HFcCl4SLQzOcBP/AFgdI804GrpfDTdS96r3PWPBqby+2NftEsvnXAFOCRODgqA== X-Received: by 2002:a05:6122:507:: with SMTP id x7mr10863664vko.18.1637672197004; Tue, 23 Nov 2021 04:56:37 -0800 (PST) Received: from ?IPv6:2804:7f0:4841:5563:567:f743:51a3:5cfa? ([2804:7f0:4841:5563:567:f743:51a3:5cfa]) by smtp.gmail.com with ESMTPSA id t20sm6804824vsj.27.2021.11.23.04.56.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Nov 2021 04:56:36 -0800 (PST) Subject: Re: [pushed] [gdb/cli] Add command: show logging active From: Luis Machado To: Tom de Vries , gdb-patches@sourceware.org, Eli Zaretskii References: <20211123114603.6284-1-tdevries@suse.de> <1ca7c4e3-7db2-264c-8c71-8ff51ea5640a@linaro.org> Message-ID: <72143ae1-7b7f-7359-2e4a-ca74142194b9@linaro.org> Date: Tue, 23 Nov 2021 09:56:34 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <1ca7c4e3-7db2-264c-8c71-8ff51ea5640a@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Nov 2021 12:56:41 -0000 On 11/23/21 9:49 AM, Luis Machado wrote: > On 11/23/21 8:46 AM, Tom de Vries via Gdb-patches wrote: >> Currently, there's no gdb command that shows whether logging is >> enabled or >> disabled. >> >> There's the show logging command, but output is identical in both cases. >> With logging disabled, we have: >> ... >> (gdb) set logging off >> (gdb) show logging >> logging debugredirect:  The logging output mode is off. >> logging file:  The current logfile is "gdb.txt". >> logging overwrite: \ >>    Whether logging overwrites or appends to the log file is off. >> logging redirect:  The logging output mode is off. >> ... >> and with logging enabled we have: >> ... >> (gdb) set logging on >> Copying output to gdb.txt. >> Copying debug output to gdb.txt. >> (gdb) show logging >> logging debugredirect:  The logging output mode is off. >> logging file:  The current logfile is "gdb.txt". >> logging overwrite: \ >>    Whether logging overwrites or appends to the log file is off. >> logging redirect:  The logging output mode is off. >> ... >> >> Add a "show logging active" command, such that we have: >> ... >> (gdb) show logging >> logging active:  Logging is disabled. >> logging debugredirect:  The logging output mode is off. >> logging file:  The current logfile is "gdb.txt". >> logging overwrite: \ >>    Whether logging overwrites or appends to the log file is off. >> logging redirect:  The logging output mode is off. >> ... > > Sorry, I think these phrases need a revamp. The current text is very > confusing. I've cc-ed Eli for some feedback on documentation. > > "logging active:  Logging is disabled." reads very funny. Is logging > active? Or is it disabled? Why can't it say "Logging is active" or > "Logging is not active"? > > I think the same goes to some of the other lines. > > * "logging debugredirect:  The logging output mode is off." > > Why not say "Debug is not being redirected." or "Debug is being > redirected."? > > * "logging overwrite: Whether logging overwrites or appends to the log > file is off." > > Why not say "Logging overwrites contents of the log file" or "Logging > appends to the log file". > > * "logging redirect:  The logging output mode is off." > > I find the above cryptic as well. Why not "Log redirects ". I just noticed these messages changed relatively recently. An older GDB would show the following: Future logs will be written to gdb.txt. Logs will be appended to the log file. Output will be logged and displayed. Debug output will be logged and displayed. The above is much clearer in my opinion. The newer ones seem very cryptic. It almost looks like a documentation regression, though I can understand that the code is probably simpler.