From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 826393855598 for ; Tue, 4 Jul 2023 15:23:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 826393855598 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688484191; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kP8BHpJJMpvfjrHJOCmo4H62EqjsFTN3LgZ9yJn0NXI=; b=iL/xHirrHLgE7JOJF/aHeVMjWugiHvoqIg73fM5viPzCxch5XlMLtHUCpFn/7m8kfYhTTt PKNI+lcm6Q/cpQSRaG7zIRpVwLodWga6zCiasAXarUMn6oM51M/mGMfHLS9dZhTSoVDw4m YRTuvZFk5rMpTfry7pVOISVCONKaS24= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-512-9YkZFvgOPseF607tJ_L49w-1; Tue, 04 Jul 2023 11:23:10 -0400 X-MC-Unique: 9YkZFvgOPseF607tJ_L49w-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-3fbab56aac7so36164155e9.1 for ; Tue, 04 Jul 2023 08:23:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688484189; x=1691076189; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kP8BHpJJMpvfjrHJOCmo4H62EqjsFTN3LgZ9yJn0NXI=; b=U4ZZbkKvdgDP8GZRgxQxNCyFCcuRBDZedy64ZrQ+ysMT/pRiLzYGFci1mxCNGLOk5f P0ZRKM68CkG6moMFDLrS8LXLFWFbB21YilNPZQs3Si09PZpmzUsHhngiXFWPNB5GUFRh QPcNvZlG7g8sPtCgQ8RQWfcE91FqrwriEdVkOMtVhHDETZ/DhhP/ht0HrfLwTTNHBCjh 4lTRQv0tNqadabiLVBItowgXQ7g7i0dHEKzj09yAMtdO21/lV2xc1gEx1dbRca2GlUEn dPGgO5fBSLkXWyQs6wrNBL+WO0ZO4GhBSIv9XS4nFVLcE5OTOpFgMAobn4eWZ+mWtkYC mRVQ== X-Gm-Message-State: AC+VfDx0GG3g7kJ6KwlWFbMJH2lq7zi1ze3VTrJ/aFH/Q/kz3Nb6JFVk t11HKFgvJ470o8EGM8m3UjUDAlzmt7GaI4EEu5RO8YOm+2DeBRkTT0Ir/BNB2RfQ8q6NnOmQYVD iusJ6gcoDsh3kzj7tWwQy63VGT1VkFCZm7Tvzb6N0MRNillZFdbM/NNnVsrvZOTfIeWpDDh9sg9 bDaafaww== X-Received: by 2002:a05:600c:22c3:b0:3fa:79af:15c8 with SMTP id 3-20020a05600c22c300b003fa79af15c8mr11804093wmg.23.1688484188799; Tue, 04 Jul 2023 08:23:08 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5H3ReYsj9C+bGQFp2JFK+2vpEe+P2a/ovdrpkwsAOrTbhb9dQ1//Qkn0VZOgZ9sYPMkPYdLQ== X-Received: by 2002:a05:600c:22c3:b0:3fa:79af:15c8 with SMTP id 3-20020a05600c22c300b003fa79af15c8mr11804070wmg.23.1688484188373; Tue, 04 Jul 2023 08:23:08 -0700 (PDT) Received: from localhost (2.72.115.87.dyn.plus.net. [87.115.72.2]) by smtp.gmail.com with ESMTPSA id k16-20020a05600c0b5000b003fba6709c68sm21209216wmr.47.2023.07.04.08.23.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Jul 2023 08:23:08 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Mihails Strasuns , tankut.baris.aktemur@intel.com, Christina Schimpe Subject: [PATCHv2 4/8] gdb, infrun: refactor part of `proceed` into separate function Date: Tue, 4 Jul 2023 16:22:54 +0100 Message-Id: <72b43d4ee86a71924d83198ed771da5a8bd93469.1688484032.git.aburgess@redhat.com> X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: From: Mihails Strasuns Split the thread resuming code from proceed into new function proceed_resume_thread_checked. Co-Authored-By: Christina Schimpe --- gdb/infrun.c | 155 ++++++++++++++++++++++++++++----------------------- 1 file changed, 86 insertions(+), 69 deletions(-) diff --git a/gdb/infrun.c b/gdb/infrun.c index 5b0257076f0..010fcd7952f 100644 --- a/gdb/infrun.c +++ b/gdb/infrun.c @@ -3268,6 +3268,89 @@ check_multi_target_resumption (process_stratum_target *resume_target) } } +/* Helper function for `proceed`. Check if thread TP is suitable for + resuming, and, if it is, switch to the thread and call + `keep_going_pass_signal`. If TP is not suitable for resuming then this + function will just return without switching threads. */ + +static void +proceed_resume_thread_checked (thread_info *tp) +{ + if (!tp->inf->has_execution ()) + { + infrun_debug_printf ("[%s] target has no execution", + tp->ptid.to_string ().c_str ()); + return; + } + + if (tp->resumed ()) + { + infrun_debug_printf ("[%s] resumed", + tp->ptid.to_string ().c_str ()); + gdb_assert (tp->executing () || tp->has_pending_waitstatus ()); + return; + } + + if (thread_is_in_step_over_chain (tp)) + { + infrun_debug_printf ("[%s] needs step-over", + tp->ptid.to_string ().c_str ()); + return; + } + + /* When handling a vfork GDB removes all breakpoints from the program + space in which the vfork is being handled, as such we must take care + not to resume any thread other than the vfork parent -- resuming the + vfork parent allows GDB to receive and handle the 'vfork done' + event. */ + if (tp->inf->thread_waiting_for_vfork_done != nullptr) + { + if (target_is_non_stop_p ()) + { + /* For non-stop targets, regardless of whether GDB is using + all-stop or non-stop mode, threads are controlled + individually. + + When a thread is handling a vfork, breakpoints are removed + from the inferior (well, program space in fact), so it is + critical that we don't try to resume any thread other than the + vfork parent. */ + if (tp != tp->inf->thread_waiting_for_vfork_done) + { + infrun_debug_printf ("[%s] thread %s of this inferior is " + "waiting for vfork-done", + tp->ptid.to_string ().c_str (), + tp->inf->thread_waiting_for_vfork_done + ->ptid.to_string ().c_str ()); + return; + } + } + else + { + /* For all-stop targets, when we attempt to resume the inferior, + we will only resume the vfork parent thread, this is handled + in internal_resume_ptid. + + Additionally, we will always be called with the vfork parent + thread as the current thread (TP) thanks to follow_fork, as + such the following assertion should hold. + + Beyond this there is nothing more that needs to be done + here. */ + gdb_assert (tp == tp->inf->thread_waiting_for_vfork_done); + } + } + + infrun_debug_printf ("resuming %s", + tp->ptid.to_string ().c_str ()); + + execution_control_state ecs (tp); + switch_to_thread (tp); + keep_going_pass_signal (&ecs); + if (!ecs.wait_some_more) + error (_("Command aborted.")); +} + /* Basic routine for continuing the program in various fashions. ADDR is the address to resume at, or -1 for resume where stopped. @@ -3456,77 +3539,11 @@ proceed (CORE_ADDR addr, enum gdb_signal siggnal) resume_ptid)) { switch_to_thread_no_regs (tp); - - if (!tp->inf->has_execution ()) - { - infrun_debug_printf ("[%s] target has no execution", - tp->ptid.to_string ().c_str ()); - continue; - } - - if (tp->resumed ()) - { - infrun_debug_printf ("[%s] resumed", - tp->ptid.to_string ().c_str ()); - gdb_assert (tp->executing () || tp->has_pending_waitstatus ()); - continue; - } - - if (thread_is_in_step_over_chain (tp)) - { - infrun_debug_printf ("[%s] needs step-over", - tp->ptid.to_string ().c_str ()); - continue; - } - - /* If a thread of that inferior is waiting for a vfork-done - (for a detached vfork child to exec or exit), breakpoints are - removed. We must not resume any thread of that inferior, other - than the one waiting for the vfork-done. */ - if (tp->inf->thread_waiting_for_vfork_done != nullptr - && tp != tp->inf->thread_waiting_for_vfork_done) - { - infrun_debug_printf ("[%s] another thread of this inferior is " - "waiting for vfork-done", - tp->ptid.to_string ().c_str ()); - continue; - } - - infrun_debug_printf ("resuming %s", - tp->ptid.to_string ().c_str ()); - - execution_control_state ecs (tp); - switch_to_thread (tp); - keep_going_pass_signal (&ecs); - if (!ecs.wait_some_more) - error (_("Command aborted.")); - } - } - else if (!cur_thr->resumed () - && !thread_is_in_step_over_chain (cur_thr)) - { - /* In non-stop mode, if a there exists a thread waiting for a vfork - then only allow that thread to resume (breakpoints are removed - from an inferior when handling a vfork). - - We check target_is_non_stop_p here rather than just checking the - non-stop flag, though these are equivalent (all-stop on a - non-stop target was handled in a previous block, so at this - point, if target_is_non_stop_p then GDB must be running on - non-stop mode). By using target_is_non_stop_p it will be easier - to merge this block with the previous in a later commit. */ - if (!(target_is_non_stop_p () - && cur_thr->inf->thread_waiting_for_vfork_done != nullptr - && cur_thr->inf->thread_waiting_for_vfork_done != cur_thr)) - { - /* The thread wasn't started, and isn't queued, run it now. */ - execution_control_state ecs (cur_thr); - switch_to_thread (cur_thr); - keep_going_pass_signal (&ecs); - if (!ecs.wait_some_more) - error (_("Command aborted.")); + proceed_resume_thread_checked (tp); } } + else + proceed_resume_thread_checked (cur_thr); disable_commit_resumed.reset_and_commit (); } -- 2.25.4